diff options
author | Bowon Ryu <bowon.ryu@samsung.com> | 2018-12-05 20:28:24 +0900 |
---|---|---|
committer | Christopher Michael <cp.michael@samsung.com> | 2018-12-06 12:06:17 -0500 |
commit | e8827de96da406986605ac8b56c2e00aa06efcc7 (patch) | |
tree | be6d1e337f8d41fdf6b894287be26d76889cfbfa | |
parent | e686199a76a5f253889f595a7ba3337965275e71 (diff) |
efl_ui_tab_bar: fix error about double free
Summary:
tab is the parent of the icon.
so deleting the tab causes deleting the icon automatically.
in this case, it can cause double-freed problem once icon has deleted.
Test Plan: elementary_test -to efl.ui.tab_pager
Reviewers: cedric, Jaehyun_Cho, jpeg
Reviewed By: Jaehyun_Cho
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7407
-rw-r--r-- | src/lib/elementary/efl_ui_tab_bar.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/lib/elementary/efl_ui_tab_bar.c b/src/lib/elementary/efl_ui_tab_bar.c index 7aeb78cf5f..7d9f5c29dc 100644 --- a/src/lib/elementary/efl_ui_tab_bar.c +++ b/src/lib/elementary/efl_ui_tab_bar.c | |||
@@ -298,7 +298,6 @@ _efl_ui_tab_bar_tab_remove(Eo *obj EINA_UNUSED, Efl_Ui_Tab_Bar_Data *sd, int ind | |||
298 | _tab_unselect(sd, ti); | 298 | _tab_unselect(sd, ti); |
299 | evas_object_box_remove(sd->bx, ti->tab); | 299 | evas_object_box_remove(sd->bx, ti->tab); |
300 | efl_del(ti->tab); | 300 | efl_del(ti->tab); |
301 | efl_del(ti->icon); | ||
302 | 301 | ||
303 | sd->tab_infos = eina_list_remove(sd->tab_infos, ti); | 302 | sd->tab_infos = eina_list_remove(sd->tab_infos, ti); |
304 | sd->cnt --; | 303 | sd->cnt --; |