summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorwonguk.jeong <wonguk.jeong@samsung.com>2014-07-07 19:10:58 +0200
committerCedric BAIL <c.bail@partner.samsung.com>2014-07-07 19:11:02 +0200
commitf803ba27b7a394f1b9ab83e3e7b760e6e916fbbd (patch)
treebf33fd99959d0f9c7965ff884c498366a5a18c29
parent3e79b47e8023642590fd089c378e9fe6279e822a (diff)
ethumb: fix setup related API problem
Summary: setup related API was not working at all due to below problems 1. dbus type signature is wrong. it's array of dictionary not array of struct 2. since quality value was assigned to compress value, there was a problem during saving png image (out of bound) 3. orientation_set API was not working except NONE and ORIGINAL @fix Test Plan: make thumbnail by using elm_thumb_add -> orientation set to 90 CCW -> check whether image is rotated properly or not Reviewers: raster, cedric CC: seoz, cedric Differential Revision: https://phab.enlightenment.org/D1138 Signed-off-by: Cedric BAIL <c.bail@partner.samsung.com>
-rw-r--r--src/bin/ethumb_client/ethumbd.c2
-rw-r--r--src/lib/ethumb/ethumb.c2
-rw-r--r--src/lib/ethumb_client/ethumb_client.c2
3 files changed, 4 insertions, 2 deletions
diff --git a/src/bin/ethumb_client/ethumbd.c b/src/bin/ethumb_client/ethumbd.c
index 1b757db1b4..5e0959085a 100644
--- a/src/bin/ethumb_client/ethumbd.c
+++ b/src/bin/ethumb_client/ethumbd.c
@@ -1638,7 +1638,7 @@ _ethumb_dbus_ethumb_setup_cb(const Eldbus_Service_Interface *iface, const Eldbus
1638 request->id = -1; 1638 request->id = -1;
1639 1639
1640 r = EINA_TRUE; 1640 r = EINA_TRUE;
1641 while (eldbus_message_iter_get_and_next(array, 'r', &data) && r) 1641 while (eldbus_message_iter_get_and_next(array, 'e', &data) && r)
1642 { 1642 {
1643 if (!_ethumb_dbus_ethumb_setup_parse_element(eobject, data, request)) 1643 if (!_ethumb_dbus_ethumb_setup_parse_element(eobject, data, request))
1644 r = EINA_FALSE; 1644 r = EINA_FALSE;
diff --git a/src/lib/ethumb/ethumb.c b/src/lib/ethumb/ethumb.c
index 761d56d5a7..76538e958f 100644
--- a/src/lib/ethumb/ethumb.c
+++ b/src/lib/ethumb/ethumb.c
@@ -1611,6 +1611,8 @@ _ethumb_image_load(Ethumb *e)
1611 } 1611 }
1612#endif 1612#endif
1613 } 1613 }
1614 else
1615 orientation = e->orientation;
1614 1616
1615 if (orientation != ETHUMB_THUMB_ORIENT_NONE) 1617 if (orientation != ETHUMB_THUMB_ORIENT_NONE)
1616 _ethumb_image_orient(e, orientation); 1618 _ethumb_image_orient(e, orientation);
diff --git a/src/lib/ethumb_client/ethumb_client.c b/src/lib/ethumb_client/ethumb_client.c
index 5524370f86..cec7e7603f 100644
--- a/src/lib/ethumb_client/ethumb_client.c
+++ b/src/lib/ethumb_client/ethumb_client.c
@@ -817,7 +817,7 @@ ethumb_client_ethumb_setup(Ethumb_Client *client)
817 _setup_iterator_close(array, entry, variant); 817 _setup_iterator_close(array, entry, variant);
818 818
819 variant = _setup_iterator_open(array, &entry, "compress", "i"); 819 variant = _setup_iterator_open(array, &entry, "compress", "i");
820 compress = ethumb_thumb_quality_get(e); 820 compress = ethumb_thumb_compress_get(e);
821 eldbus_message_iter_arguments_append(variant, "i", compress); 821 eldbus_message_iter_arguments_append(variant, "i", compress);
822 _setup_iterator_close(array, entry, variant); 822 _setup_iterator_close(array, entry, variant);
823 823