summaryrefslogtreecommitdiff
path: root/configure.ac
diff options
context:
space:
mode:
authorJean Guyomarc'h <jean@guyomarch.bzh>2016-10-29 22:32:19 +0200
committerJean Guyomarc'h <jean@guyomarch.bzh>2016-10-29 23:01:38 +0200
commit403b0ecfa66530e9cd598bd013aeda76df7ee98c (patch)
tree3e9416a93d989a315f621af74e456bcb4076a5d0 /configure.ac
parent30d7410699875cce2e255e3ebf862b3e7dbd641a (diff)
ecore_audio: drop support for CoreAudio on macOS
CoreAudio support was initially introduced by commit 62e29b39f4df40fd3c0a6b17f7a16f0f8fc1d0c9 as an experimental feature. It played basic sounds, but suffered from drawbacks: it was controlling the master channel, and therefore any sound played by ecore_audio would shut down a previous sound (e.g. background music) for the time of the sound being played. So that wasn't exactly great... Also, after some time, some hangs have been reported when playing a sound on input. Most of the time, it translated as a pause in the main loop (see T3797). More recently (several months ago), ecore_audio with CoreAudio stopped working during 1.19 development... So... CoreAudio support on macOS has never been great. And now it's fully broken. Instead of trying to revive the thing, let just use PulseAudio. PulseAudio can be installed without any trouble on macOS thanks to package managers such as Homebrew. Actually, the efl package provided by Homebrew already provides PulseAudio as a dependency. And it actually just works very fine. Dropping CoreAudio seems therefore a nice option: removes unmaintained code, fixes bugs, and add features.
Diffstat (limited to 'configure.ac')
-rw-r--r--configure.ac55
1 files changed, 2 insertions, 53 deletions
diff --git a/configure.ac b/configure.ac
index 4f68b1e..d67f353 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3904,55 +3904,6 @@ AC_ARG_ENABLE([pulseaudio],
3904 ], 3904 ],
3905 [want_pulseaudio="yes"]) 3905 [want_pulseaudio="yes"])
3906 3906
3907if test "x${have_darwin}" = "xyes"; then
3908 want_pulseaudio="no"
3909 want_alsa="no"
3910 want_coreaudio="yes"
3911else
3912 want_coreaudio="no"
3913fi
3914
3915
3916# CoreAudio flags
3917if test "x${want_coreaudio}" = "xyes"; then
3918 coreaudio_ldflags=""
3919 have_coreaudio="no"
3920 LIBS_save="$LIBS"
3921 LIBS="$LIBS -framework CoreAudio"
3922 AC_LINK_IFELSE(
3923 [AC_LANG_PROGRAM(
3924 [[
3925#include <CoreAudio/CoreAudio.h>
3926 ]],
3927 [[
3928UInt32 size;
3929AudioDeviceID dev_id;
3930AudioObjectPropertyAddress prop = {
3931 kAudioHardwarePropertyDefaultOutputDevice,
3932 kAudioObjectPropertyScopeGlobal,
3933 kAudioObjectPropertyElementMaster
3934};
3935size = sizeof(AudioDeviceID);
3936AudioObjectGetPropertyData(kAudioObjectSystemObject, &prop, 0, NULL,
3937 &size, &dev_id);
3938 ]])],
3939 [
3940 have_coreaudio="yes"
3941 coreaudio_ldflags="-framework CoreAudio"
3942 ],
3943 [have_coreaudio="no"])
3944 LIBS="$LIBS_save"
3945 AC_MSG_CHECKING([whether Apple CoreAudio framework is supported])
3946 AC_MSG_RESULT([${have_coreaudio}])
3947fi
3948AC_SUBST(coreaudio_ldflags)
3949if test "x${have_coreaudio}" = "xyes"; then
3950 AC_DEFINE([HAVE_COREAUDIO], [1], [CoreAudio support enabled])
3951else
3952 AC_DEFINE([HAVE_COREAUDIO], [0], [CoreAudio support disabled])
3953fi
3954
3955
3956### Default values 3907### Default values
3957 3908
3958### Checks for programs 3909### Checks for programs
@@ -3992,7 +3943,6 @@ EFL_EVAL_PKGS([ECORE_AUDIO])
3992EFL_ADD_FEATURE([ECORE_AUDIO], [alsa]) 3943EFL_ADD_FEATURE([ECORE_AUDIO], [alsa])
3993EFL_ADD_FEATURE([ECORE_AUDIO], [pulseaudio]) 3944EFL_ADD_FEATURE([ECORE_AUDIO], [pulseaudio])
3994EFL_ADD_FEATURE([ECORE_AUDIO], [sndfile]) 3945EFL_ADD_FEATURE([ECORE_AUDIO], [sndfile])
3995EFL_ADD_FEATURE([ECORE_AUDIO], [coreaudio])
3996 3946
3997### Checks for header files 3947### Checks for header files
3998 3948
@@ -4009,7 +3959,6 @@ EFL_ADD_FEATURE([ECORE_AUDIO], [coreaudio])
4009EFL_LIB_END_OPTIONAL([Ecore_Audio]) 3959EFL_LIB_END_OPTIONAL([Ecore_Audio])
4010AM_CONDITIONAL([HAVE_ECORE_AUDIO_PULSE], [test "x${want_pulseaudio}" = "xyes"]) 3960AM_CONDITIONAL([HAVE_ECORE_AUDIO_PULSE], [test "x${want_pulseaudio}" = "xyes"])
4011AM_CONDITIONAL([HAVE_ECORE_AUDIO_SNDFILE], [test "x${want_sndfile}" = "xyes"]) 3961AM_CONDITIONAL([HAVE_ECORE_AUDIO_SNDFILE], [test "x${want_sndfile}" = "xyes"])
4012AM_CONDITIONAL([HAVE_ECORE_AUDIO_CORE_AUDIO], [test "x${want_coreaudio}" = "xyes"])
4013 3962
4014#### End of Ecore_Audio 3963#### End of Ecore_Audio
4015 3964
@@ -4913,7 +4862,7 @@ AC_ARG_ENABLE([multisense],
4913 fi 4862 fi
4914 ], 4863 ],
4915 [ 4864 [
4916 if test "x${want_pulseaudio}" = "xyes" -o "x${want_coreaudio}" = "xyes"; then 4865 if test "x${want_pulseaudio}" = "xyes"; then
4917 want_multisense="yes" 4866 want_multisense="yes"
4918 else 4867 else
4919 want_multisense="no" 4868 want_multisense="no"
@@ -6242,7 +6191,7 @@ if test -n "$CFOPT_WARNING"; then
6242 echo "Reconsider disabling audio." 6191 echo "Reconsider disabling audio."
6243 echo "_____________________________________________________________________" 6192 echo "_____________________________________________________________________"
6244 fi 6193 fi
6245 if test "x${have_darwin}" = "xno" -a "x${want_pulseaudio}" = "xno"; then 6194 if test "x${want_pulseaudio}" = "xno"; then
6246 echo "_____________________________________________________________________" 6195 echo "_____________________________________________________________________"
6247 echo "The only audio output method supported by Ecore right now on your" 6196 echo "The only audio output method supported by Ecore right now on your"
6248 echo "system is via Pulseaudio. You have disabled that and likely have" 6197 echo "system is via Pulseaudio. You have disabled that and likely have"