|author||Carsten Haitzler (Rasterman) <email@example.com>||2019-02-12 20:11:44 +0000|
|committer||Carsten Haitzler (Rasterman) <firstname.lastname@example.org>||2019-02-12 20:22:28 +0000|
Revert the env object because it's broken portability - please redo
setenv and unsetenv are not portable. i explained to you at fosdem there are issues and it's why i used putenv in the original implementation and even though it's a pain (the string tou pass to putenv is a pointer used literallt from there on in and you get it from getenv, thus making ownership a pain -this is a libc issue we can't readily solve). use putenv like the original code. then put it back in. vtorri now has windows porting issues with the setenv use. i knew there was a reason that still existed... in addition your in_sync stuff is broken. psuedocode: // assuming BLAGH env is not set to anything here c = efl_core_env_get(global_env, "BLAH"); ... putenv("BLAH=10"); ... c = efl_core_env_Get(global_env, "BLAH"); i will get NULL in both cases for c ... but i should get "10" for the 2nd in reality. reality is lots of code across application code and libraries will at times mess with the environment. it has to work with this. the prior implementation did work with this. Revert "ecore: here comes a env object" This reverts commit 2373d5db5b4cd5dfe139aa2a10017ef61b28b5ce. Revert "efl_task: remove env from this object" This reverts commit c3d69f66a69c0def357a5c373a13343e1c01ff5d.
Diffstat (limited to '')
1 files changed, 1 insertions, 2 deletions
|@@ -53,8 +53,7 @@ header_checks = [|
|60||function_checks = [||59||function_checks = [|