summaryrefslogtreecommitdiff
path: root/src/bin/edje/edje_cc_out.c
diff options
context:
space:
mode:
authorCarsten Haitzler (Rasterman) <raster@rasterman.com>2015-09-21 16:50:17 +0900
committerCarsten Haitzler (Rasterman) <raster@rasterman.com>2015-09-21 16:50:17 +0900
commit76c854433fce9c15ae1cbc872e78a916135c694f (patch)
treea3342747221ea419a5618de339942a05520d1533 /src/bin/edje/edje_cc_out.c
parent31b07f94b747cb10ab71d87381e363028f6512a4 (diff)
efl - edje_cc - fix double close of embryo script fd's to tmp files
@fix thanks to 김낙경 <nakkyong.kim@samsung.com> for pointing this out. indeed fclose() closes the fd adopted by fdopen(). it doesn't dup it. so we double-closed. it seems this never caused an issue until now. this should fix it.
Diffstat (limited to '')
-rw-r--r--src/bin/edje/edje_cc_out.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/src/bin/edje/edje_cc_out.c b/src/bin/edje/edje_cc_out.c
index f40687d86a..c0264e69b8 100644
--- a/src/bin/edje/edje_cc_out.c
+++ b/src/bin/edje/edje_cc_out.c
@@ -1701,7 +1701,6 @@ data_thread_script(void *data, Ecore_Thread *thread EINA_UNUSED)
1701 return; 1701 return;
1702 } 1702 }
1703 } 1703 }
1704 fclose(f);
1705 1704
1706 if (no_save) 1705 if (no_save)
1707 WRN("You are removing the source from this Edje file. This may break some use cases.\nBe aware of your choice and the poor kitten you are harming with it!"); 1706 WRN("You are removing the source from this Edje file. This may break some use cases.\nBe aware of your choice and the poor kitten you are harming with it!");
@@ -1725,13 +1724,16 @@ data_thread_script(void *data, Ecore_Thread *thread EINA_UNUSED)
1725 strlen(cp->original) + 1, compress_mode); 1724 strlen(cp->original) + 1, compress_mode);
1726 } 1725 }
1727 } 1726 }
1727 fclose(f);
1728 1728
1729 unlink(sc->tmpn); 1729 unlink(sc->tmpn);
1730 unlink(sc->tmpo); 1730 unlink(sc->tmpo);
1731 eina_tmpstr_del(sc->tmpn); 1731 eina_tmpstr_del(sc->tmpn);
1732 eina_tmpstr_del(sc->tmpo); 1732 eina_tmpstr_del(sc->tmpo);
1733 close(sc->tmpn_fd); 1733// closed by fclose(f) in create_script_file()
1734 close(sc->tmpo_fd); 1734// close(sc->tmpn_fd);
1735// closed by fclose(f) above
1736// close(sc->tmpo_fd);
1735} 1737}
1736 1738
1737static void 1739static void