eldbus-codegen: Free msg on error path for generated code.

If eldbus_message_arguments_append we would never unref the message.
This will fix various Coverity issues in generatd eldbus code.

@fix

CID: 1255634, 1255636, 1255637, 1255639

1 files changed, 2 insertions, 0 deletions

diff --git a/src/bin/eldbus/source_client.c b/src/bin/eldbus/source_client.c
index 50c01885db..07f5773615 100644
--- a/src/bin/eldbus/source_client.c
+++ b/src/bin/eldbus/source_client.c
@@ -161,6 +161,7 @@ source_client_simple_method_call_no_reply_generate(const DBus_Method *method, Ei
    eina_strbuf_append_printf(c_code, "   if (!eldbus_message_arguments_append(msg, \"%s\"%s))\n", eina_strbuf_string_get(full_signature), eina_strbuf_string_get(args_call));
    eina_strbuf_append_printf(c_code, "     {\n");
    eina_strbuf_append_printf(c_code, "        ERR(\"Error: Filling message.\");\n");
+   eina_strbuf_append_printf(c_code, "        eldbus_message_unref(msg);\n");
    eina_strbuf_append_printf(c_code, "        return;\n");
    eina_strbuf_append_printf(c_code, "     }\n");
    eina_strbuf_append_printf(c_code, "   eldbus_proxy_send(proxy, msg, NULL, NULL, -1);\n");
@@ -201,6 +202,7 @@ source_client_simple_method_call_generate(const DBus_Method *method, Eina_Strbuf
    eina_strbuf_append_printf(c_code, "   if (!eldbus_message_arguments_append(msg, \"%s\"%s))\n", eina_strbuf_string_get(full_signature), eina_strbuf_string_get(args_call));
    eina_strbuf_append_printf(c_code, "     {\n");
    eina_strbuf_append_printf(c_code, "        ERR(\"Error: Filling message.\");\n");
+   eina_strbuf_append_printf(c_code, "        eldbus_message_unref(msg);\n");
    eina_strbuf_append_printf(c_code, "        return NULL;\n");
    eina_strbuf_append_printf(c_code, "     }\n");
    eina_strbuf_append_printf(c_code, "   p = eldbus_proxy_send(proxy, msg, %s, cb, -1);\n", method->cb_name);