path: root/src/lib/ecore
diff options
authorYeongjong Lee <>2018-08-17 12:42:35 -0400
committerMike Blumenkrantz <>2018-08-17 12:42:35 -0400
commit15cc9a65aa8656d4183b9eada790143363c7dc06 (patch)
treeb20f79864bec445203d5fab5f6dbfd8effba348d /src/lib/ecore
parentcbe9b6f7700aaa3c87a203e69b5ab543cee68c20 (diff)
ecore_pipe: remove null check condition and fix segfualt on Windows
Summary: This reverts commit 4917910b4911905236fa099bbc16b833b056ca07. 4917910b break backward compatibility. Reproduction: void pipe_handler(...); pipe = ecore_pipe_add(pipe_handler, NULL); ecore_pipe_write(pipe, NULL, 0); Because of the null check condition, pipe_handler isn't called after 4917910b. Some apps behavior which is written to expected to call pipe_handler was broken. also, this patch fixed segfault during build on Windows Test Plan: make on Windows Reviewers: raster, zmike, vtorri Reviewed By: zmike, vtorri Subscribers: woohyun, cedric, #reviewers, #committers, zmike, vtorri Tags: #efl Differential Revision:
Diffstat (limited to 'src/lib/ecore')
1 files changed, 0 insertions, 5 deletions
diff --git a/src/lib/ecore/ecore_pipe.c b/src/lib/ecore/ecore_pipe.c
index f9aa62655a..92127b95d0 100644
--- a/src/lib/ecore/ecore_pipe.c
+++ b/src/lib/ecore/ecore_pipe.c
@@ -591,11 +591,6 @@ _ecore_pipe_handler_call(Ecore_Pipe *p,
591 unsigned char *buf, 591 unsigned char *buf,
592 size_t len) 592 size_t len)
593{ 593{
594 // on windows we seem to get a pipe wake with no data. don't pass on
595 // zero data as there is nothing useful to do with it... and it causes
596 // segfaults
597 if ((!buf) || (!len)) return;
599 void *data = (void*) p->data; 594 void *data = (void*) p->data;
600 595
601 // clear all values of pipe first. 596 // clear all values of pipe first.