path: root/src/lib/ecore_con
diff options
authorMike Blumenkrantz <>2019-02-27 13:17:09 -0500
committerMike Blumenkrantz <>2019-02-27 13:17:10 -0500
commit6326e18b3fb2a4757f8ffa22be5d55a75da23049 (patch)
tree31d586b52638aa0d0b1c759869a8e3368c9daf5d /src/lib/ecore_con
parent7924660d54500285d3844bfa384394c683825cd9 (diff)
efl.file: improve api a bit
Summary: the previous implementation/api had a number of issues: * "file" property contained both "file" and "key" values - also performed file loading operation * "load_error" property which was specific to image objects * no methods for controlling file loading/unloading this patch attempts the following changes: * split "file" property into "file" and "key" properties - also remove "key" from existing "mmap" property * remove "load_error" * directly return error codes from operations * add "load" and "unload" methods for directly controlling load state * add implicit file loading if file/mmap is set during construction * rewrite all efl.file implementations to move file loading into load() method * rewrite all usage of efl.file api based on these changes * add C extension functions to mimic previous behavior ref T7577 Reviewers: segfaultxavi, bu5hm4n, cedric Reviewed By: segfaultxavi Subscribers: vitor.sousa, #reviewers, #committers Tags: #efl_api Maniphest Tasks: T7577 Differential Revision:
Diffstat (limited to 'src/lib/ecore_con')
1 files changed, 1 insertions, 1 deletions
diff --git a/src/lib/ecore_con/ecore_con_url.c b/src/lib/ecore_con/ecore_con_url.c
index 5f94ebf2d1..b78498aa0e 100644
--- a/src/lib/ecore_con/ecore_con_url.c
+++ b/src/lib/ecore_con/ecore_con_url.c
@@ -1177,7 +1177,7 @@ ecore_con_url_ftp_upload(Ecore_Con_Url *url_con,
1177 1177
1178 file = efl_add(EFL_IO_FILE_CLASS, efl_loop_get(url_con->dialer), 1178 file = efl_add(EFL_IO_FILE_CLASS, efl_loop_get(url_con->dialer),
1179 efl_name_set(efl_added, "upload-file"), 1179 efl_name_set(efl_added, "upload-file"),
1180 efl_file_set(efl_added, filename, NULL), 1180 efl_file_set(efl_added, filename),
1181 efl_io_file_flags_set(efl_added, O_RDONLY), 1181 efl_io_file_flags_set(efl_added, O_RDONLY),
1182 efl_io_closer_close_on_invalidate_set(efl_added, EINA_TRUE), 1182 efl_io_closer_close_on_invalidate_set(efl_added, EINA_TRUE),
1183 efl_io_closer_close_on_exec_set(efl_added, EINA_TRUE)); 1183 efl_io_closer_close_on_exec_set(efl_added, EINA_TRUE));