summaryrefslogtreecommitdiff
path: root/src/lib/ecore_drm2/ecore_drm2_outputs.c
diff options
context:
space:
mode:
authorDerek Foreman <derekf@osg.samsung.com>2017-06-05 16:22:08 -0500
committerDerek Foreman <derekf@osg.samsung.com>2017-06-05 16:25:14 -0500
commite24670b1e2b720ea732517af1767214e41774779 (patch)
treec6b5e463583234fba93ebb4660829bcb28023cc8 /src/lib/ecore_drm2/ecore_drm2_outputs.c
parentde313d6296ac8a2d9a3c0f9762179ffd42a833ff (diff)
ecore_drm2: Fix error handling in _output_dpms_atomic_set
This was skipping the error path on failure and setting some state as if it was successful. Then the next attempt at a page flip was actually setting this state. So _output_dpms_atomic_set (which has always been broken) wasn't actually the function that successfully disabled dpms. This is confounding attempts to debug why dpms isn't coming back on properly. Now it won't turn *off* either, because it really never should have. Ref T5462
Diffstat (limited to 'src/lib/ecore_drm2/ecore_drm2_outputs.c')
-rw-r--r--src/lib/ecore_drm2/ecore_drm2_outputs.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/lib/ecore_drm2/ecore_drm2_outputs.c b/src/lib/ecore_drm2/ecore_drm2_outputs.c
index 39fb8471cc..263fccd30d 100644
--- a/src/lib/ecore_drm2/ecore_drm2_outputs.c
+++ b/src/lib/ecore_drm2/ecore_drm2_outputs.c
@@ -450,6 +450,7 @@ _output_dpms_atomic_set(Ecore_Drm2_Output *output, int level)
450 { 450 {
451 ERR("Could not set dpms property: %m"); 451 ERR("Could not set dpms property: %m");
452 ret = EINA_FALSE; 452 ret = EINA_FALSE;
453 goto err;
453 } 454 }
454 455
455 cstate->dpms.value = level; 456 cstate->dpms.value = level;