efl: major rewrite of efl_part.

The interface efl_part_get should not be directly called from C, but the efl_part
wrapper should. It rely on efl_noref to properly destroy the object. Binding can
control the lifecycle of the reference the way they want by either calling the
wrapper or efl_part_get directly. It also means that the ugly ___efl_auto_unref_set
doesn't need to be exposed outside of EFL anymore.

Differential Revision: https://phab.enlightenment.org/D6098

2 files changed, 29 insertions, 4 deletions

diff --git a/src/lib/efl/interfaces/efl_interfaces_main.c b/src/lib/efl/interfaces/efl_interfaces_main.c
index 4e02e1e5e1..d9b10e89d2 100644
--- a/src/lib/efl/interfaces/efl_interfaces_main.c
+++ b/src/lib/efl/interfaces/efl_interfaces_main.c
@@ -5,6 +5,9 @@
 #define EFL_CANVAS_SCENE_BETA
 #define EFL_UI_SCROLLBAR_PROTECTED
 #define EFL_UI_SCROLLBAR_BETA
+#define EFL_PART_PROTECTED
+
+#include "eo_internal.h"
 
 #include <Efl.h>
 
@@ -77,6 +80,27 @@
 #include "interfaces/efl_ui_multi_selectable.eo.c"
 #include "interfaces/efl_ui_zoom.eo.c"
 
+static void
+_noref_death(void *data EINA_UNUSED, const Efl_Event *event)
+{
+   efl_event_callback_del(event->object, EFL_EVENT_NOREF, _noref_death, NULL);
+   efl_del(event->object);
+}
+
+EAPI Efl_Object *
+efl_part(const Eo *obj, const char *name)
+{
+   Efl_Object *r;
+
+   r = efl_part_get(obj, name);
+   if (!r) return NULL;
+
+   efl_event_callback_add(r, EFL_EVENT_NOREF, _noref_death, NULL);
+   ___efl_auto_unref_set(r, EINA_TRUE);
+
+   return efl_ref(r);
+}
+
 EAPI void
 __efl_internal_init(void)
 {
diff --git a/src/lib/efl/interfaces/efl_part.eo b/src/lib/efl/interfaces/efl_part.eo
index 124dad121e..1f37e7e4ab 100644
--- a/src/lib/efl/interfaces/efl_part.eo
+++ b/src/lib/efl/interfaces/efl_part.eo
@@ -10,7 +10,10 @@ interface Efl.Part
      theme.
 
      Part proxy objects have a special lifetime that
-     is limited to one and only one function call.
+     is limited to one and only one function call. This
+     behavior is implemented in efl_part() which call
+     Efl.Part.part_get(). Calling Efl.Part.part_get() directly
+     should be avoided.
 
      In other words, the caller does not hold a reference
      to this proxy object. It may be possible, in languages
@@ -32,10 +35,8 @@ interface Efl.Part
        unref(part)
    ]]
    methods {
-      part @const {
+      part_get @protected @const {
          [[Get a proxy object referring to a part of an object.
-
-           The returned object is valid for only a single function call.
          ]]
          params {
             name: string; [[The part name.]]