Fix mem leak reported by Coverity: If we fail to create a new internal

menu, then free the previously allocated xml file.

NB: Fixes Coverity CID 1039182

Signed-off-by: Chris Michael <cp.michael@samsung.com>

1 files changed, 5 insertions, 1 deletions

diff --git a/src/lib/efreet/efreet_menu.c b/src/lib/efreet/efreet_menu.c
index fa04616bd8..feea57d3ea 100644
--- a/src/lib/efreet/efreet_menu.c
+++ b/src/lib/efreet/efreet_menu.c
@@ -569,7 +569,11 @@ efreet_menu_parse(const char *path)
 
     /* split apart the filename and the path */
     internal = efreet_menu_internal_new(NULL);
-    if (!internal) return NULL;
+    if (!internal)
+    {
+        efreet_xml_del(xml);
+        return NULL;
+    }
     internal->efreet_merged_menus = eina_hash_string_superfast_new(NULL);
     internal->efreet_merged_dirs = eina_hash_string_superfast_new(NULL);