summaryrefslogtreecommitdiff
path: root/src/lib/eina/meson.build
diff options
context:
space:
mode:
authorFelipe Magno de Almeida <felipe@expertise.dev>2020-11-25 09:35:48 -0300
committerFelipe Magno de Almeida <felipe@expertise.dev>2020-11-25 09:42:47 -0300
commitccc1849263d8019c712e0fee02673de15f30b3c5 (patch)
tree2ba060a4889090a8a86b707cd666d3f4ad1a7e41 /src/lib/eina/meson.build
parent6b1f281f175a68dc50c788010f47bc4e256905d1 (diff)
eina: Rename EAPI macro to EINA_API in Eina library
Summary: Patch from a series of patches to rename EAPI symbols to specific library DSOs. EAPI was designed to be able to pass `__attribute__ ((visibility ("default")))` for symbols with GCC, which would mean that even if -fvisibility=hidden was used when compiling the library, the needed symbols would get exported. MSVC __almost__ works like GCC (or mingw) in which you can declare everything as export and it will just work (slower, but it will work). But there's a caveat: global variables will not work the same way for MSVC, but works for mingw and GCC. For global variables (as opposed to functions), MSVC requires correct DSO visibility for MSVC: instead of declaring a symbol as export for everything, you need to declare it as import when importing from another DSO and export when defining it locally. With current EAPI definitions, we get the following example working in mingw and MSVC (observe it doesn't define any global variables as exported symbols). Example 1: dll1: ``` EAPI void foo(void); EAPI void bar() { foo(); } ``` dll2: ``` EAPI void foo() { printf ("foo\n"); } ``` This works fine with API defined as __declspec(dllexport) in both cases and for gcc defining as `__atttribute__((visibility("default")))` However, the following: Example 2: dll1: ``` EAPI extern int foo; EAPI void foobar(void); EAPI void bar() { foo = 5; foobar(); } ``` dll2: ``` EAPI int foo = 0; EAPI void foobar() { printf ("foo %d\n", foo); } ``` This will work on mingw but will not work for MSVC. And that's why EAPI is the only solution that worked for MSVC. Co-authored-by: João Paulo Taylor Ienczak Zanette <jpaulotiz@gmail.com> Co-authored-by: Ricardo Campos <ricardo.campos@expertise.dev> Co-authored-by: Lucas Cavalcante de Sousa <lucks.sousa@gmail.com> Reviewers: jptiz, lucas, woohyun, vtorri, raster Reviewed By: jptiz, lucas, vtorri Subscribers: ProhtMeyhet, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D12188
Diffstat (limited to '')
-rw-r--r--src/lib/eina/meson.build2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/lib/eina/meson.build b/src/lib/eina/meson.build
index 3bd869eed9..8d5d4383d1 100644
--- a/src/lib/eina/meson.build
+++ b/src/lib/eina/meson.build
@@ -375,7 +375,7 @@ if sys_windows == true
375endif 375endif
376 376
377eina_lib = library('eina', eina_src, 377eina_lib = library('eina', eina_src,
378 c_args : package_c_args, 378 c_args : [package_c_args, '-DEINA_BUILD'],
379 include_directories : config_dir, 379 include_directories : config_dir,
380 dependencies: eina_ext_deps + [eina_deps, evil], 380 dependencies: eina_ext_deps + [eina_deps, evil],
381 install: true, 381 install: true,