summaryrefslogtreecommitdiff
path: root/src/lib/eldbus
diff options
context:
space:
mode:
authorChristopher Michael <cp.michael@samsung.com>2019-03-15 12:14:18 -0400
committerChristopher Michael <cp.michael@samsung.com>2019-03-15 12:14:19 -0400
commit25797aaca05f293ef9c0b8ef2898f58345e55dd6 (patch)
tree2218cfb712c22d2d584b5e533e0fa75b5f94be8d /src/lib/eldbus
parent12f0dc4fdd46d66433cf9b053ed615f122b9314d (diff)
eldbus: Fix dereference after null check
Summary: Coverity reports we are passing NULL variable 'properties' to eina_array_pop here which dereferences it. Wrap the 'end' block in an if which checks for valid 'properties' variable Fixes Coverity CID1399422 @fix Depends on D8350 Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt Reviewed By: cedric Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8351
Diffstat (limited to 'src/lib/eldbus')
-rw-r--r--src/lib/eldbus/eldbus_model_proxy.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/lib/eldbus/eldbus_model_proxy.c b/src/lib/eldbus/eldbus_model_proxy.c
index d571732..00d85b4 100644
--- a/src/lib/eldbus/eldbus_model_proxy.c
+++ b/src/lib/eldbus/eldbus_model_proxy.c
@@ -662,7 +662,9 @@ _eldbus_model_proxy_property_set_load_cb(void *data,
662 signature, set_data->value, 662 signature, set_data->value,
663 _eldbus_model_proxy_property_set_cb, set_data); 663 _eldbus_model_proxy_property_set_cb, set_data);
664 pd->pendings = eina_list_append(pd->pendings, pending); 664 pd->pendings = eina_list_append(pd->pendings, pending);
665 end: 665
666end:
667 if (!properties) return;
666 while ((sp = eina_array_pop(properties))) 668 while ((sp = eina_array_pop(properties)))
667 eina_stringshare_del(sp); 669 eina_stringshare_del(sp);
668 eina_array_free(properties); 670 eina_array_free(properties);