path: root/src/lib/eo/eo_add_fallback.c
diff options
authorFelipe Magno de Almeida <>2020-12-09 13:50:29 -0300
committerFelipe Magno de Almeida <>2020-12-09 13:52:25 -0300
commit138e9e5294bcc5994853c826da013f0220042c5c (patch)
tree9f6e4f9274ac077586d2676dd0eca6c12675da21 /src/lib/eo/eo_add_fallback.c
parentcfd17f145ace345f08581cd17b9328eaf56812e2 (diff)
eo: Rename EAPI macro to EO_API in Eo library
Summary: Patch from a series of patches to rename EAPI symbols to specific library DSOs. = The Rationale = This patch is from a series of patches to rename EAPI symbols to specific library DSOs. EAPI was designed to be able to pass `__attribute__ ((visibility ("default")))` for symbols with GCC, which would mean that even if -fvisibility=hidden was used when compiling the library, the needed symbols would get exported. MSVC __almost__ works like GCC (or mingw) in which you can declare everything as export and it will just work (slower, but it will work). But there's a caveat: global variables will not work the same way for MSVC, but works for mingw and GCC. For global variables (as opposed to functions), MSVC requires correct DSO visibility for MSVC: instead of declaring a symbol as export for everything, you need to declare it as import when importing from another DSO and export when defining it locally. With current EAPI definitions, we get the following example working in mingw and MSVC (observe it doesn't define any global variables as exported symbols). Example 1: dll1: ``` EAPI void foo(void); EAPI void bar() { foo(); } ``` dll2: ``` EAPI void foo() { printf ("foo\n"); } ``` This works fine with API defined as __declspec(dllexport) in both cases and for gcc defining as `__atttribute__((visibility("default")))`. However, the following: Example 2: dll1: ``` EAPI extern int foo; EAPI void foobar(void); EAPI void bar() { foo = 5; foobar(); } ``` dll2: ``` EAPI int foo = 0; EAPI void foobar() { printf ("foo %d\n", foo); } ``` This will work on mingw but will not work for MSVC. And that's why LIBAPI is the only solution that works for MSVC. Co-authored-by: João Paulo Taylor Ienczak Zanette <> Co-authored-by: Lucas Cavalcante de Sousa <> Co-authored-by: Ricardo Campos <> Reviewers: jptiz, lucas, vtorri, woohyun Reviewed By: jptiz, lucas, vtorri Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision:
Diffstat (limited to 'src/lib/eo/eo_add_fallback.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/src/lib/eo/eo_add_fallback.c b/src/lib/eo/eo_add_fallback.c
index f3a82f25d6..f349b336b4 100644
--- a/src/lib/eo/eo_add_fallback.c
+++ b/src/lib/eo/eo_add_fallback.c
@@ -130,7 +130,7 @@ _eo_call_stack_get_thread(void)
130 return stack; 130 return stack;
131} 131}
132 132
133EAPI Eo * 133EO_API Eo *
134_efl_added_get(void) 134_efl_added_get(void)
135{ 135{
136 return _EFL_OBJECT_CALL_STACK_GET()->frame_ptr->obj; 136 return _EFL_OBJECT_CALL_STACK_GET()->frame_ptr->obj;