summaryrefslogtreecommitdiff
path: root/src/lib/eolian/eolian_api.h
diff options
context:
space:
mode:
authorFelipe Magno de Almeida <felipe@expertise.dev>2020-11-25 11:39:05 -0300
committerFelipe Magno de Almeida <felipe@expertise.dev>2020-11-25 11:43:53 -0300
commitf08f0548da7fda905e9288343424df4ddd6221d5 (patch)
tree20b0adfd178811a4c274328aa924193f128ad96f /src/lib/eolian/eolian_api.h
parent4797602e84e9da4347d9f95a94f0c0b4e545d38d (diff)
eolian: Rename EAPI macro to EOLIAN_API in Eolian library
Summary: Patch from a series of patches to rename EAPI symbols to specific library DSOs. EAPI was designed to be able to pass `__attribute__ ((visibility ("default")))` for symbols with GCC, which would mean that even if -fvisibility=hidden was used when compiling the library, the needed symbols would get exported. MSVC __almost__ works like GCC (or mingw) in which you can declare everything as export and it will just work (slower, but it will work). But there's a caveat: global variables will not work the same way for MSVC, but works for mingw and GCC. For global variables (as opposed to functions), MSVC requires correct DSO visibility for MSVC: instead of declaring a symbol as export for everything, you need to declare it as import when importing from another DSO and export when defining it locally. With current EAPI definitions, we get the following example working in mingw and MSVC (observe it doesn't define any global variables as exported symbols). Example 1: dll1: ``` EAPI void foo(void); EAPI void bar() { foo(); } ``` dll2: ``` EAPI void foo() { printf ("foo\n"); } ``` This works fine with API defined as __declspec(dllexport) in both cases and for gcc defining as `__atttribute__((visibility("default")))`. However, the following: Example 2: dll1: ``` EAPI extern int foo; EAPI void foobar(void); EAPI void bar() { foo = 5; foobar(); } ``` dll2: ``` EAPI int foo = 0; EAPI void foobar() { printf ("foo %d\n", foo); } ``` This will work on mingw but will not work for MSVC. And that's why EAPI is the only solution that worked for MSVC. Co-authored-by: João Paulo Taylor Ienczak Zanette <jpaulotiz@gmail.com> Co-authored-by: Ricardo Campos <ricardo.campos@expertise.dev> Co-authored-by: Lucas Cavalcante de Sousa <lucks.sousa@gmail.com> Reviewers: vtorri, woohyun, jptiz, lucas Reviewed By: vtorri Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D12196
Diffstat (limited to 'src/lib/eolian/eolian_api.h')
-rw-r--r--src/lib/eolian/eolian_api.h34
1 files changed, 34 insertions, 0 deletions
diff --git a/src/lib/eolian/eolian_api.h b/src/lib/eolian/eolian_api.h
new file mode 100644
index 0000000000..e2cfa7a524
--- /dev/null
+++ b/src/lib/eolian/eolian_api.h
@@ -0,0 +1,34 @@
1#ifndef _EFL_EOLIAN_API_H
2#define _EFL_EOLIAN_API_H
3
4#ifdef EOLIAN_API
5#error EOLIAN_API should not be already defined
6#endif
7
8#ifdef _WIN32
9# ifndef EOLIAN_STATIC
10# ifdef EOLIAN_BUILD
11# define EOLIAN_API __declspec(dllexport)
12# else
13# define EOLIAN_API __declspec(dllimport)
14# endif
15# else
16# define EOLIAN_API
17# endif
18# define EOLIAN_API_WEAK
19#else
20# ifdef __GNUC__
21# if __GNUC__ >= 4
22# define EOLIAN_API __attribute__ ((visibility("default")))
23# define EOLIAN_API_WEAK __attribute__ ((weak))
24# else
25# define EOLIAN_API
26# define EOLIAN_API_WEAK
27# endif
28# else
29# define EOLIAN_API
30# define EOLIAN_API_WEAK
31# endif
32#endif
33
34#endif