summaryrefslogtreecommitdiff
path: root/src/lib/evas/cache2
diff options
context:
space:
mode:
authorJean-Philippe Andre <jp.andre@samsung.com>2013-10-29 13:54:15 +0900
committerJean-Philippe Andre <jp.andre@samsung.com>2013-10-29 15:08:14 +0900
commit10f80df01825066987452b11a9ec785555540c64 (patch)
tree0c3638f3c40ddca5f80b64e20f414d97c10a5c6d /src/lib/evas/cache2
parent73c2ae44e0ae7404c64e2da1c0220301392a2220 (diff)
evas/cserve2: Fix new Coverity issues
Nothing extraordinary here. Most potential crashes are extremely unlikely. - Fix CID 1113444 - Fix CID 1113442 - Fix CID 1113441 (Logically dead code, can not be NULL) - Fix CID 1113440: Explicit null dereferenced This is actually an impossible situation. Fixed by checking for nullity and printing out some error messages instead of just crashing. - Fix CID 1113439: Dereference after null check Logically impossible code as both idxpath and datapath must be either set or null at the same time. Change the if logic to tell Coverity there's no bug. - Fix CID 1113438 (Argument cannot be negative) Fix wrong check of return value from shm_open. - Fix CID 1113437 (Argument cannot be negative) Fix wrong check of return value from shm_open. - Fix CID 1113436 (Dereference null return value) This case really shouldn't happen. But the extra check does not hurt. - Fix CID 1113435 (Dereference before null check) Check for nullity after map open. - Fix CID 1113434 (Extra sizeof expression) Debug buggy debug tool :) - Fix CID 1113433 (Uninitialized scalar variable) Insignificant issue: only prints wrong debug logs :) - Fix CID 1113431 (Uninitialized scalar value) Check if (!found) only to print out logs. Not a big deal if found was invalid. - Fix CID 1039462 (Logically dead code)
Diffstat (limited to 'src/lib/evas/cache2')
-rw-r--r--src/lib/evas/cache2/evas_cache2.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/lib/evas/cache2/evas_cache2.c b/src/lib/evas/cache2/evas_cache2.c
index e1a9d01120..35cceb6e65 100644
--- a/src/lib/evas/cache2/evas_cache2.c
+++ b/src/lib/evas/cache2/evas_cache2.c
@@ -657,7 +657,7 @@ evas_cache2_image_open(Evas_Cache2 *cache, const char *path, const char *key,
657 Image_Timestamp tstamp; 657 Image_Timestamp tstamp;
658 Evas_Image_Load_Opts prevent; 658 Evas_Image_Load_Opts prevent;
659 659
660 if ((!path) || ((!path) && (!key))) 660 if (!path)
661 { 661 {
662 *error = EVAS_LOAD_ERROR_GENERIC; 662 *error = EVAS_LOAD_ERROR_GENERIC;
663 return NULL; 663 return NULL;