summaryrefslogtreecommitdiff
path: root/src/lib/evas/file/evas_module.c
diff options
context:
space:
mode:
authorFelipe Magno de Almeida <felipe@expertise.dev>2020-12-15 23:02:20 -0300
committerFelipe Magno de Almeida <felipe@expertise.dev>2020-12-15 23:06:12 -0300
commit0363fd8238c3df734c856a48cbb831b9651ed089 (patch)
tree951895156f0a5dd6aa7e88d8a602c58d79251c50 /src/lib/evas/file/evas_module.c
parent75f07e41c0242123f9e4e5dcbc303ad46ea0849b (diff)
evas: Rename EAPI macro to EVAS_API in Evas library
Summary: Patch from a series of patches to rename EAPI symbols to specific library DSOs. = The Rationale = This patch is from a series of patches to rename EAPI symbols to specific library DSOs. EAPI was designed to be able to pass `__attribute__ ((visibility ("default")))` for symbols with GCC, which would mean that even if -fvisibility=hidden was used when compiling the library, the needed symbols would get exported. MSVC __almost__ works like GCC (or mingw) in which you can declare everything as export and it will just work (slower, but it will work). But there's a caveat: global variables will not work the same way for MSVC, but works for mingw and GCC. For global variables (as opposed to functions), MSVC requires correct DSO visibility for MSVC: instead of declaring a symbol as export for everything, you need to declare it as import when importing from another DSO and export when defining it locally. With current EAPI definitions, we get the following example working in mingw and MSVC (observe it doesn't define any global variables as exported symbols). Example 1: dll1: ``` EAPI void foo(void); EAPI void bar() { foo(); } ``` dll2: ``` EAPI void foo() { printf ("foo\n"); } ``` This works fine with API defined as __declspec(dllexport) in both cases and for gcc defining as `__atttribute__((visibility("default")))`. However, the following: Example 2: dll1: ``` EAPI extern int foo; EAPI void foobar(void); EAPI void bar() { foo = 5; foobar(); } ``` dll2: ``` EAPI int foo = 0; EAPI void foobar() { printf ("foo %d\n", foo); } ``` This will work on mingw but will not work for MSVC. And that's why LIBAPI is the only solution that works for MSVC. Co-authored-by: João Paulo Taylor Ienczak Zanette <jpaulotiz@gmail.com> Co-authored-by: Lucas Cavalcante de Sousa <lucks.sousa@gmail.com> Co-authored-by: Ricardo Campos <ricardo.campos@expertise.dev> Reviewers: vtorri, woohyun, jptiz, lucas Reviewed By: vtorri, lucas Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D12214
Diffstat (limited to '')
-rw-r--r--src/lib/evas/file/evas_module.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/src/lib/evas/file/evas_module.c b/src/lib/evas/file/evas_module.c
index 83f1d804df..6292c1bb42 100644
--- a/src/lib/evas/file/evas_module.c
+++ b/src/lib/evas/file/evas_module.c
@@ -38,7 +38,7 @@ struct _Evas_Module_Task
38 38
39static Eina_TLS task = 0; 39static Eina_TLS task = 0;
40 40
41EAPI Eina_Bool 41EVAS_API Eina_Bool
42evas_module_task_cancelled(void) 42evas_module_task_cancelled(void)
43{ 43{
44 Evas_Module_Task *t; 44 Evas_Module_Task *t;
@@ -49,7 +49,7 @@ evas_module_task_cancelled(void)
49 return t->cancelled(t->data); 49 return t->cancelled(t->data);
50} 50}
51 51
52EAPI void 52EVAS_API void
53evas_module_task_register(Eina_Bool (*cancelled)(void *data), void *data) 53evas_module_task_register(Eina_Bool (*cancelled)(void *data), void *data)
54{ 54{
55 Evas_Module_Task *t; 55 Evas_Module_Task *t;
@@ -63,7 +63,7 @@ evas_module_task_register(Eina_Bool (*cancelled)(void *data), void *data)
63 eina_tls_set(task, t); 63 eina_tls_set(task, t);
64} 64}
65 65
66EAPI void 66EVAS_API void
67evas_module_task_unregister(void) 67evas_module_task_unregister(void)
68{ 68{
69 Evas_Module_Task *t; 69 Evas_Module_Task *t;
@@ -803,7 +803,7 @@ evas_module_shutdown(void)
803 } 803 }
804} 804}
805 805
806EAPI int 806EVAS_API int
807_evas_module_engine_inherit(Evas_Func *funcs, char *name, size_t info) 807_evas_module_engine_inherit(Evas_Func *funcs, char *name, size_t info)
808{ 808{
809 Evas_Module *em; 809 Evas_Module *em;
@@ -824,7 +824,7 @@ _evas_module_engine_inherit(Evas_Func *funcs, char *name, size_t info)
824 return 0; 824 return 0;
825} 825}
826 826
827EAPI const char * 827EVAS_API const char *
828_evas_module_libdir_get(void) 828_evas_module_libdir_get(void)
829{ 829{
830 if (!pfx) pfx = eina_prefix_new 830 if (!pfx) pfx = eina_prefix_new
@@ -845,7 +845,7 @@ _evas_module_datadir_get(void)
845} 845}
846 846
847/* deprecated */ 847/* deprecated */
848EAPI const char * 848EVAS_API const char *
849evas_cserve_path_get(void) 849evas_cserve_path_get(void)
850{ 850{
851 return NULL; 851 return NULL;