path: root/src/lib/evil/evil_locale.c
diff options
authorFelipe Magno de Almeida <>2020-11-12 13:47:38 -0300
committerFelipe Magno de Almeida <>2020-11-12 17:40:21 -0300
commit8f9255e2c16efed25a26ad39eaa37b07cf670c38 (patch)
tree47c50ec1439d701158c2c7aa4e5fe910a5ed9e6b /src/lib/evil/evil_locale.c
parent64ce7a2c45e1de3167f64feb08d7e2223aac5b60 (diff)
evil: Rename EAPI macro to EVIL_API in Evil library
Summary: Patch from a series of patches to rename EAPI symbols to specific library DSOs. EAPI was designed to be able to pass ```__attribute__ ((visibility ("default")))``` for symbols with GCC, which would mean that even if -fvisibility=hidden was used when compiling the library, the needed symbols would get exported. MSVC __almost__ works like GCC (or mingw) in which you can declare everything as export and it will just work (slower, but it will work). But there's a caveat: global variables will not work the same way for MSVC, but works for mingw and GCC. For global variables (as opposed to functions), MSVC requires correct DSO visibility for MSVC: instead of declaring a symbol as export for everything, you need to declare it as import when importing from another DSO and export when defining it locally. With current EAPI definitions, we get the following example working in mingw and MSVC (observe it doesn't define any global variables as exported symbols). ``` Example 1: dll1: ``` EAPI void foo(void); EAPI void bar() { foo(); } ``` dll2: ``` EAPI void foo() { printf ("foo\n"); } ``` This works fine with API defined as __declspec(dllexport) in both cases and for gcc defining as ```__atttribute__((visibility("default")))``` However, the following: Example 2: dll1: ``` EAPI extern int foo; EAPI void foobar(void); EAPI void bar() { foo = 5; foobar(); } ``` dll2: ``` EAPI int foo = 0; EAPI void foobar() { printf ("foo %d\n", foo); } ``` This will work on mingw but will not work for MSVC. And that's why EAPI is the only solution that worked for MSVC. Co-authored-by: João Paulo Taylor Ienczak Zanette <> Co-authored-by: Ricardo Campos <> Co-authored-by: Lucas Cavalcante de Sousa <> Reviewers: raster, vtorri, jptiz, lucas, woohyun Reviewed By: vtorri, jptiz Subscribers: ProhtMeyhet, cedric, #reviewers, #committers Tags: #efl Differential Revision:
Diffstat (limited to 'src/lib/evil/evil_locale.c')
1 files changed, 3 insertions, 16 deletions
diff --git a/src/lib/evil/evil_locale.c b/src/lib/evil/evil_locale.c
index c932b27a69..388c7f5ef3 100644
--- a/src/lib/evil/evil_locale.c
+++ b/src/lib/evil/evil_locale.c
@@ -12,21 +12,7 @@
12#include <windows.h> 12#include <windows.h>
13#undef WIN32_LEAN_AND_MEAN 13#undef WIN32_LEAN_AND_MEAN
14 14
15#ifdef EAPI 15#include "evil_private.h" /* LC_MESSAGES */
16# undef EAPI
19#ifdef EFL_BUILD
20# ifdef DLL_EXPORT
21# define EAPI __declspec(dllexport)
22# else
23# define EAPI
24# endif
26# define EAPI __declspec(dllimport)
29#include "evil_locale.h" /* LC_MESSAGES */
30 16
31/* 17/*
32 * LOCALE_SISO639LANGNAME and LOCALE_SISO3166CTRYNAME need at least a buffer 18 * LOCALE_SISO639LANGNAME and LOCALE_SISO3166CTRYNAME need at least a buffer
@@ -37,7 +23,8 @@ static char _evil_locale_buf[18];
37 23
38#undef setlocale 24#undef setlocale
39 25
40char *evil_setlocale(int category, const char *locale) 26EVIL_API char *
27evil_setlocale(int category, const char *locale)
41{ 28{
42 char buf[9]; 29 char buf[9];
43 int l1; 30 int l1;