summaryrefslogtreecommitdiff
path: root/src/modules/eeze
diff options
context:
space:
mode:
authorTom Hacohen <tom@stosb.com>2015-10-09 12:32:37 +0100
committerTom Hacohen <tom@stosb.com>2015-10-09 12:32:37 +0100
commit896c18045aafb9c677d8d41b4876c47db2b4d5ce (patch)
treefd86d1362ec6311b7d308d007815d5453aa3f3d6 /src/modules/eeze
parente54fd09c34ab3580736cf1205c5c1edb621a65b8 (diff)
Eeze sensor udev: Fix memory leak and possible crash.
Due to a misplaced semicolon, EINA_LIST_FREE was doing nothing and only the last part was freed if there was one, and probably a crash if there wasn't. This shows again that having statements without {} is dangerous. We need to force {} and add a lint rule, or at the very least, add a rule to put the ; in a new line (like clang warns about by default anyway). (Same as issue found in previous commit) @fix
Diffstat (limited to 'src/modules/eeze')
-rw-r--r--src/modules/eeze/sensor/udev/udev.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/modules/eeze/sensor/udev/udev.c b/src/modules/eeze/sensor/udev/udev.c
index 3e7e6b3e17..cf52cd349f 100644
--- a/src/modules/eeze/sensor/udev/udev.c
+++ b/src/modules/eeze/sensor/udev/udev.c
@@ -48,7 +48,7 @@ udev_shutdown(void)
48{ 48{
49 char *data; 49 char *data;
50 50
51 EINA_LIST_FREE(devices, data); 51 EINA_LIST_FREE(devices, data)
52 free(data); 52 free(data);
53 53
54 return EINA_TRUE; 54 return EINA_TRUE;