path: root/src/tests/efl_mono/ValueEolian.cs
diff options
authorXavi Artigas <xavierartigas@yahoo.es>2019-01-11 14:28:38 +0100
committerXavi Artigas <xavierartigas@yahoo.es>2019-01-11 14:51:22 +0100
commit48b303eeb50961776026548023b15733bea340e2 (patch)
tree13c6b560214d3390ae1467c6b18ca29b608a6148 /src/tests/efl_mono/ValueEolian.cs
parentefl: refactor all mixins (diff)
efl-mono: Add extra constructors to Eina.Value
Summary: new Eina.Value(0) is a special case. The 0 is silently converted to an enum (Eina.ValueType) and therefore the call is ambiguous with the 0 being first converted to an Eina.Value via the implicit conversion operator (calling the Eina.Value deep copy constructor). Adding constructors for all supported types solves the problem because they have higher priority. Also, they avoid one deep copy of the Eina.Value. Includes test case to catch this problem in the future. This was discovered in the tutorials, where new Eina.Value(0) is being used. Test Plan: The src/efl_reference_core_event.exe example from the examples repo was not compiling before, and now it is. make check and make examples still work as expected. Reviewers: lauromoura Reviewed By: lauromoura Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D7598
Diffstat (limited to '')
1 files changed, 8 insertions, 1 deletions
diff --git a/src/tests/efl_mono/ValueEolian.cs b/src/tests/efl_mono/ValueEolian.cs
index 4d33dfacde..ea178d4ac9 100644
--- a/src/tests/efl_mono/ValueEolian.cs
+++ b/src/tests/efl_mono/ValueEolian.cs
@@ -151,7 +151,14 @@ public static class TestEinaValueEolian {
Test.AssertEquals(expected, received);
Test.AssertEquals(Eina.ValueType.Double, received.GetValueType());
+ // Check for 0
+ // This is a special value, since C# can silently convert it to an enum
+ // leading to collisions with Eina.ValueType
+ expected = new Eina.Value(0);
+ obj.SetValue(0);
+ obj.OutValue(out received);
+ Test.AssertEquals(expected, received);
+ Test.AssertEquals(Eina.ValueType.Int32, received.GetValueType());
#pragma warning restore 1591