summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorCarsten Haitzler (Rasterman) <raster@rasterman.com>2015-06-24 18:35:46 +0900
committerCarsten Haitzler (Rasterman) <raster@rasterman.com>2015-06-24 19:28:04 +0900
commitc6011926bad960136af132a97b54cb38199638fe (patch)
tree55008e19698ade8e7c6e38e01060c38d0847ab47 /src
parent7bb28711023254a023bc7578da5f52fd8f7479c4 (diff)
eo - silence ERR logs on constructor fail - this is valid behavior
@fix XXX: Given EFL usage of objects, construction is a perfectly valid thing to do. we shouldn't complain about it as handling a NULL obj creation is the job of the caller. a perfect example here is ecore_con and ecore_ipc where you create a con or ipc obj then set up type/destination/port and the finalize of the constructor does the actual connect and thus this fails or succeeds based on if service is there. until there is a better solution - don't complain here.
Diffstat (limited to 'src')
-rw-r--r--src/lib/eo/eo.c13
1 files changed, 11 insertions, 2 deletions
diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c
index 9609138..b5e24a9 100644
--- a/src/lib/eo/eo.c
+++ b/src/lib/eo/eo.c
@@ -974,8 +974,17 @@ _eo_add_internal_end(Eo *eo_id)
974 974
975 if (!eo_id) 975 if (!eo_id)
976 { 976 {
977 ERR("Object of class '%s' - Finalizing the object failed.", 977// XXX: Given EFL usage of objects, construction is a perfectly valid thing
978 klass->desc->name); 978// to do. we shouldn't complain about it as handling a NULL obj creation is
979// the job of the caller. a perfect example here is ecore_con and ecore_ipc
980// where you create a con or ipc obj then set up type/destination/port and
981// the finalize of the constructor does the actual connect and thus this
982// fails or succeeds based on if service is there.
983//
984// until there is a better solution - don't complain here.
985//
986// ERR("Object of class '%s' - Finalizing the object failed.",
987// klass->desc->name);
979 goto cleanup; 988 goto cleanup;
980 } 989 }
981 } 990 }