summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorChris Michael <cpmichael@osg.samsung.com>2016-06-30 10:51:29 -0400
committerChris Michael <cpmichael@osg.samsung.com>2016-06-30 10:51:29 -0400
commit1fb3c3328604c56d20ea4a0e35925d4b9f94b185 (patch)
tree2c94c583762e84f0131b089450ab2d54f3415659 /src
parent837108050b7037b83976960ab7586bf4ea283898 (diff)
ecore-evas: Fix error handling issues in wayland_shm engine
This patch fixes 2 Coverity issues where engine_info_set was being called, but the return was never being checked. Fixes Coverity CID1357141 and CID1357142 @fix Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
Diffstat (limited to 'src')
-rw-r--r--src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_shm.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_shm.c b/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_shm.c
index e18c06c..05e60f6 100644
--- a/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_shm.c
+++ b/src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_shm.c
@@ -443,7 +443,8 @@ _ecore_evas_wl_show(Ecore_Evas *ee)
443 if ((!einfo->info.wl_surface) || (einfo->info.wl_surface != surf)) 443 if ((!einfo->info.wl_surface) || (einfo->info.wl_surface != surf))
444 { 444 {
445 einfo->info.wl_surface = surf; 445 einfo->info.wl_surface = surf;
446 evas_engine_info_set(ee->evas, (Evas_Engine_Info *)einfo); 446 if (!evas_engine_info_set(ee->evas, (Evas_Engine_Info *)einfo))
447 ERR("Failed to set Evas Engine Info for '%s'", ee->driver);
447 evas_damage_rectangle_add(ee->evas, 0, 0, ee->w + fw, ee->h + fh); 448 evas_damage_rectangle_add(ee->evas, 0, 0, ee->w + fw, ee->h + fh);
448 } 449 }
449 } 450 }
@@ -482,7 +483,10 @@ _ecore_evas_wl_hide(Ecore_Evas *ee)
482 if (einfo) 483 if (einfo)
483 { 484 {
484 einfo->info.wl_surface = NULL; 485 einfo->info.wl_surface = NULL;
485 evas_engine_info_set(ee->evas, (Evas_Engine_Info *)einfo); 486 if (!evas_engine_info_set(ee->evas, (Evas_Engine_Info *)einfo))
487 {
488 ERR("Failed to set Evas Engine Info for '%s'", ee->driver);
489 }
486 } 490 }
487 491
488 if (wdata->win) 492 if (wdata->win)