gfx: Remove size hint request (EO)

This hint is simply not supported by any container.
Add the EO API back if the containers support it.

Ref T5487

4 files changed, 16 insertions, 43 deletions

diff --git a/src/lib/efl/interfaces/efl_gfx_size_hint.eo b/src/lib/efl/interfaces/efl_gfx_size_hint.eo
index 7431e3658e..fad4376edc 100644
--- a/src/lib/efl/interfaces/efl_gfx_size_hint.eo
+++ b/src/lib/efl/interfaces/efl_gfx_size_hint.eo
@@ -111,24 +111,6 @@ interface Efl.Gfx.Size.Hint
             h: int; [[Integer to use as the maximum height hint.]]
          }
       }
-      @property hint_request {
-         [[Hints for the object's optimum size.
-
-           This is not a size enforcement in any way, it's just a hint
-           that should be used whenever appropriate.
-
-           Values 0 will be treated as unset hint components, when
-           queried by managers.
-
-           Note: This property is meant to be set by applications and not by
-           EFL itself. Very few containers actually implement support for
-           this requested size, see @.hint_min instead.
-         ]]
-         values {
-            w: int; [[Integer to use as the preferred width hint.]]
-            h: int; [[Integer to use as the preferred height hint.]]
-         }
-      }
       @property hint_restricted_min {
          [[Internal hints for an object's minimum size.
 
diff --git a/src/lib/evas/canvas/efl_canvas_object.eo b/src/lib/evas/canvas/efl_canvas_object.eo
index cf92e6f2c7..6eb174caab 100644
--- a/src/lib/evas/canvas/efl_canvas_object.eo
+++ b/src/lib/evas/canvas/efl_canvas_object.eo
@@ -683,7 +683,6 @@ abstract Efl.Canvas.Object (Efl.Object, Efl.Gfx, Efl.Gfx.Stack, Efl.Animator,
       Efl.Gfx.Size.Hint.hint_min { get; set; }
       Efl.Gfx.Size.Hint.hint_max { get; set; }
       Efl.Gfx.Size.Hint.hint_margin { get; set; }
-      Efl.Gfx.Size.Hint.hint_request { get; set; }
       Efl.Gfx.Size.Hint.hint_weight { get; set; }
       Efl.Input.Interface.seat_event_filter { get; set; }
       Efl.Loop_User.loop { get; }
diff --git a/src/lib/evas/canvas/evas_object_main.c b/src/lib/evas/canvas/evas_object_main.c
index f129cfb5bd..794dc4a105 100644
--- a/src/lib/evas/canvas/evas_object_main.c
+++ b/src/lib/evas/canvas/evas_object_main.c
@@ -1486,9 +1486,12 @@ _efl_canvas_object_efl_gfx_size_hint_hint_max_set(Eo *eo_obj, Evas_Object_Protec
    evas_object_inform_call_changed_size_hints(eo_obj);
 }
 
-EOLIAN static void
-_efl_canvas_object_efl_gfx_size_hint_hint_request_get(Eo *eo_obj EINA_UNUSED, Evas_Object_Protected_Data *obj, Evas_Coord *w, Evas_Coord *h)
+EAPI void
+evas_object_size_hint_request_get(const Eo *eo_obj, Evas_Coord *w, Evas_Coord *h)
 {
+   Evas_Object_Protected_Data *obj = EVAS_OBJECT_DATA_SAFE_GET(eo_obj);
+   EVAS_OBJECT_DATA_VALID_CHECK(obj);
+
    if ((!obj->size_hints) || obj->delete_me)
      {
         if (w) *w = 0;
@@ -1499,11 +1502,12 @@ _efl_canvas_object_efl_gfx_size_hint_hint_request_get(Eo *eo_obj EINA_UNUSED, Ev
    if (h) *h = obj->size_hints->request.h;
 }
 
-EOLIAN static void
-_efl_canvas_object_efl_gfx_size_hint_hint_request_set(Eo *eo_obj, Evas_Object_Protected_Data *obj, Evas_Coord w, Evas_Coord h)
+EAPI void
+evas_object_size_hint_request_set(Eo *eo_obj, Evas_Coord w, Evas_Coord h)
 {
-   if (obj->delete_me)
-     return;
+   Evas_Object_Protected_Data *obj = EVAS_OBJECT_DATA_SAFE_GET(eo_obj);
+   EVAS_OBJECT_DATA_ALIVE_CHECK(obj);
+
    evas_object_async_block(obj);
    if (EINA_UNLIKELY(!obj->size_hints))
      {
@@ -2081,7 +2085,7 @@ _efl_canvas_object_efl_object_dbg_info_get(Eo *eo_obj, Evas_Object_Protected_Dat
    unsigned int m;
    int r, g, b, a;
    int w, h;
-   int requestw, requesth;
+   //int requestw, requesth;
    int minw, minh;
    int maxw, maxh;
    int x, y;
@@ -2101,7 +2105,7 @@ _efl_canvas_object_efl_object_dbg_info_get(Eo *eo_obj, Evas_Object_Protected_Dat
    scale = efl_canvas_object_scale_get(eo_obj);
    efl_gfx_size_hint_restricted_min_get(eo_obj, &minw, &minh);
    efl_gfx_size_hint_max_get(eo_obj, &maxw, &maxh);
-   efl_gfx_size_hint_request_get(eo_obj, &requestw, &requesth);
+   //efl_gfx_size_hint_request_get(eo_obj, &requestw, &requesth);
    efl_gfx_size_hint_align_get(eo_obj, &dblx, &dbly);
    efl_gfx_size_hint_weight_get(eo_obj, &dblw, &dblh);
    efl_gfx_color_get(eo_obj, &r, &g, &b, &a);
@@ -2137,9 +2141,9 @@ _efl_canvas_object_efl_object_dbg_info_get(Eo *eo_obj, Evas_Object_Protected_Dat
    EFL_DBG_INFO_APPEND(node, "w", EINA_VALUE_TYPE_INT, maxw);
    EFL_DBG_INFO_APPEND(node, "h", EINA_VALUE_TYPE_INT, maxh);
 
-   node = EFL_DBG_INFO_LIST_APPEND(group, "Request size");
-   EFL_DBG_INFO_APPEND(node, "w", EINA_VALUE_TYPE_INT, requestw);
-   EFL_DBG_INFO_APPEND(node, "h", EINA_VALUE_TYPE_INT, requesth);
+   //node = EFL_DBG_INFO_LIST_APPEND(group, "Request size");
+   //EFL_DBG_INFO_APPEND(node, "w", EINA_VALUE_TYPE_INT, requestw);
+   //EFL_DBG_INFO_APPEND(node, "h", EINA_VALUE_TYPE_INT, requesth);
 
    node = EFL_DBG_INFO_LIST_APPEND(group, "Align");
    EFL_DBG_INFO_APPEND(node, "x", EINA_VALUE_TYPE_DOUBLE, dblx);
@@ -2612,18 +2616,6 @@ evas_object_size_hint_max_get(const Evas_Object *obj, Evas_Coord *w, Evas_Coord
 }
 
 EAPI void
-evas_object_size_hint_request_set(Evas_Object *obj, Evas_Coord w, Evas_Coord h)
-{
-   efl_gfx_size_hint_request_set(obj, w, h);
-}
-
-EAPI void
-evas_object_size_hint_request_get(const Evas_Object *obj, Evas_Coord *w, Evas_Coord *h)
-{
-   efl_gfx_size_hint_request_get(obj, w, h);
-}
-
-EAPI void
 evas_object_size_hint_min_set(Evas_Object *obj, Evas_Coord w, Evas_Coord h)
 {
    efl_gfx_size_hint_restricted_min_set(obj, w, h);
diff --git a/src/lib/evas/include/evas_inline.x b/src/lib/evas/include/evas_inline.x
index f17e8b3949..74eb25a7f9 100644
--- a/src/lib/evas/include/evas_inline.x
+++ b/src/lib/evas/include/evas_inline.x
@@ -16,7 +16,7 @@
 #define EVAS_OBJECT_DATA_GET(eo_o) \
    efl_data_scope_get((eo_o), EFL_CANVAS_OBJECT_CLASS)
 #define EVAS_OBJECT_DATA_SAFE_GET(eo_o) \
-   (((eo_o) && efl_isa((eo_o), EFL_CANVAS_OBJECT_CLASS)) ? efl_data_scope_get((eo_o), EFL_CANVAS_OBJECT_CLASS) : NULL)
+   efl_data_scope_safe_get((eo_o), EFL_CANVAS_OBJECT_CLASS)
 
 static inline Eina_Bool
 _evas_render_has_map(Evas_Object_Protected_Data *obj)