summaryrefslogtreecommitdiff
path: root/src/lib/edje/edje_text.c
diff options
context:
space:
mode:
Diffstat (limited to 'src/lib/edje/edje_text.c')
-rw-r--r--src/lib/edje/edje_text.c24
1 files changed, 23 insertions, 1 deletions
diff --git a/src/lib/edje/edje_text.c b/src/lib/edje/edje_text.c
index 45e32ac..0825c16 100644
--- a/src/lib/edje/edje_text.c
+++ b/src/lib/edje/edje_text.c
@@ -411,7 +411,29 @@ _edje_text_recalc_apply(Edje *ed, Edje_Real_Part *ep,
411 text, font, size, 411 text, font, size,
412 sw, sh, &free_text); 412 sw, sh, &free_text);
413 } 413 }
414 else 414 /* when evas ellipsis support was added in efl 1.8 and used to replace
415 * previous support, SOMEONE, who I shall call "cedric", borked ellipsis
416 * defaults. as a result, edje_cc continued using 0.0 (left-most) as its default value
417 * for ellipsis while evas used -1.0 (no ellipsizing).
418 * this was moderately okay for a time because nobody was using it or GROUP parts
419 * with text in them very frequently, and so nobody noticed that the mismatch was breaking
420 * sizing in some cases when the edje ellipsis value failed to be applied,
421 * which ocurred any time text.min_x was set; in this case, ellipsis would NEVER be
422 * correctly applied, and instead the text object would only ever get the first
423 * ellipsis_set(0), permanently breaking the part.
424 * the only way to fix this while preserving previous behavior was to bump
425 * the edje file minor version and then check it here to ignore "unset" ellipsis
426 * values from old file versions.
427 * the downside is that this will break old files which have text.min_x set to 0...maybe.
428 * it also breaks documentation since the default value for edje has "become" -1.0 in order
429 * to preserve the expected behavior of leaving it alone permanently except for the initial
430 * set to 0.0.
431 *
432 * -zmike
433 * 22 April 2014
434 */
435 else if (((ed->file->version >= 3) && (ed->file->minor >= 6)) ||
436 params->type.text.elipsis)
415 eo_do(ep->object, 437 eo_do(ep->object,
416 evas_obj_text_ellipsis_set(params->type.text.elipsis)); 438 evas_obj_text_ellipsis_set(params->type.text.elipsis));
417 439