summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-11-28efl_ui_popup_alert_scroll: check sizing evaluation while scroller is changedTaehyub Kim
Summary: add a sizing check variable for safety of sizing evaluation when the min size of scroller is changed. Test Plan: 1. run elementary_test 2. search the sample with "popup" keyword 3. click the Efl Ui Popup Alert Scroll sample Reviewers: Jaehyun_Cho, jpeg, woohyun, thiepha, Blackmole, cedric Reviewed By: Jaehyun_Cho Differential Revision: https://phab.enlightenment.org/D5204
2017-11-28efl_ui_popup: remove efl_ui_popup_position_setJinYong Park
Summary: Remove efl_ui_popup_position_set. Its functionality is replaced with efl_gfx_position_set. Test Plan: 1. elementary_test -to efluipopup Reviewers: Jaehyun_Cho, herb, thiepha, woohyun, jpeg, cedric Reviewed By: Jaehyun_Cho Differential Revision: https://phab.enlightenment.org/D5129
2017-11-28efl_ui_popup: use efl_data_scope_get instead of using 'self' objectJinYong Park
Summary: Use efl_data_scope_get to get Efl_Ui_Popup_Data structure. There is no reason using "self" object in Efl_Ui_Popup_Data. Reviewers: Jaehyun_Cho, herb, thiepha, woohyun, jpeg, cedric Reviewed By: cedric Differential Revision: https://phab.enlightenment.org/D5128
2017-11-28efl_ui_popup_alert_text: add Efl.Ui.Popup.Alert.Text ClassTaehyub Kim
Summary: Add initial code for Efl.Ui.Popup.Alert.Text Class. It supports setting texts on the content area. Test Plan: 1. run elementary_text -to efluipopupalerttext Reviewers: Jaehyun_Cho, jpeg, thiepha, cedric, woohyun, Blackmole Reviewed By: Jaehyun_Cho Differential Revision: https://phab.enlightenment.org/D5124
2017-11-28efl_ui_popup_alert_scroll: add Efl.Ui.Popup.Alert.Scroll classTaehyub Kim
Summary: Add initial code for Efl.Ui.Popup.Alert.Scroll Class. It supports scrolling content. Test Plan: 1. run elementary_test -to efluipopupalertscroll Reviewers: Jaehyun_Cho, jpeg, thiepha, cedric, Blackmole, woohyun Reviewed By: Jaehyun_Cho Differential Revision: https://phab.enlightenment.org/D5123
2017-11-28efl_ui_popup: cover the corner case of popup sizing evaluationTaehyub Kim
Summary: cover the corner case of popup sizing evaluation Test Plan: 1. run elementary_test -to efluipopup Reviewers: Jaehyun_Cho, jpeg, thiepha, Blackmole, woohyun, cedric Reviewed By: Jaehyun_Cho Differential Revision: https://phab.enlightenment.org/D5146
2017-11-28efl_ui_popup_alert: add Efl.Ui.Popup.Alert classTaehyub Kim
Summary: Add initial code for Efl.Ui.Popup.Alert class. It supports setting title and buttons. Test Plan: 1. run elementary_test -to efluipopupalert Reviewers: Jaehyun_Cho, jpeg, cedric, thiepha, Blackmole, woohyun Differential Revision: https://phab.enlightenment.org/D5108
2017-11-28efl_ui_popup: make popup size expandableTaehyub Kim
Summary: make popup size expandable Reviewers: Jaehyun_Cho, jpeg, cedric, thiepha, Blackmole, woohyun Differential Revision: https://phab.enlightenment.org/D5107
2017-11-28efl_ui_popup: add align and position propertiesTaehyub Kim
Summary: add align feature and position properties (center, left, right, top, bottom) efl_ui_popup_position_set should be seperated from evas_object_move since evas_object_move can be called internally. Test Plan: 1. run elementary_test -to efluipopup Reviewers: Jaehyun_Cho, jpeg, cedric, thiepha, Blackmole, woohyun Reviewed By: Jaehyun_Cho Differential Revision: https://phab.enlightenment.org/D5105
2017-11-28efl_ui_popup: add bg_set and bg_repeat_events_set/get APIJinYong Park
Summary: add bg_set and bg_repeat_events_set/get API bg_set enables user change popup's outside bg bg_repeat_events_set enables popup's outside bg repeat events Test Plan: 1. run elementary_test -to efluipopup 2. click outside area of popup 3. click button in popup Reviewers: Jaehyun_Cho, herb, thiepha, woohyun, cedric, jpeg, singh.amitesh Reviewed By: Jaehyun_Cho Subscribers: jpeg Tags: #efl Differential Revision: https://phab.enlightenment.org/D5054
2017-11-28efl_ui_popup: add Efl.Ui.Popup classTaehyub Kim
Summary: add initial code for Efl.Ui.Popup class Test Plan: 1. run elementary_test -to efluipopup Reviewers: Jaehyun_Cho, Blackmole, thiepha, woohyun, cedric Reviewed By: Jaehyun_Cho Subscribers: bu5hm4n, cedric, jpeg Differential Revision: https://phab.enlightenment.org/D5037
2017-11-28Efl.Ui.Format: do format check once only.Amitesh Singh
2017-11-28Efl.Ui.Format: do proper checking for string template.Amitesh Singh
Add support to take action based on string format specifier. If string template is '%d' and value type is double, do safe conversion to int from double.
2017-11-28elc_combobox: use elm_legacy_add for internal componentSungtaek Hong
Summary: elm_combobox has entry, genlist, hover as its component. Those components should be marked as legacy during efl_add. Test Plan: Run elementary test. Run combobox test. Reviewers: jpeg, cedric, woohyun Differential Revision: https://phab.enlightenment.org/D5542
2017-11-28elm_entry : Added access action interface in entry.Prasoon Singh
Summary: Added access action interface in entry. On activate action from atspi client , entry will emit click signal and input panel would be shown. Test Plan: When activate action comes, entry will emit click signal and input panel should be shown. Reviewers: shilpasingh, kimcinoo Reviewed By: shilpasingh Subscribers: cedric, jpeg, rajeshps, govi Differential Revision: https://phab.enlightenment.org/D5544
2017-11-27elm_code: Reload grid colours on theme changeAndy Williams
2017-11-27efl_wl: Silence ridiculous warningDerek Foreman
Including wayland client code before wayland server code causes spurious "struct wl_buffer deprecated" nonsense. Recent ecore_wl2 changes brought wayland client code into Ecore_Wl2.h which caused the warning to trigger here. Simply re-ordering the include files should resolve with no functional change.
2017-11-27Provide a meaningful labelAndy Williams
2017-11-27elementary: Be consistent for the display of test widgetsAndy Williams
2017-11-27efl_ui_spin: Add new spin and spin_button widgetsWoochan Lee
Summary: https://phab.enlightenment.org/T5900 Creating base class(efl_ui_spin) to support various shape of spinner. Added button interaction widget efl_ui_spin_button inherited from efl_ui_spin. Test Plan: Add tests in elementary_test. Reviewers: Jaehyun_Cho, woohyun, jpeg, singh.amitesh Subscribers: jenkins, id213sin, cedric, jpeg Differential Revision: https://phab.enlightenment.org/D5424
2017-11-27evas: Fix sign mismatch in evas between.c and .h definitionsRoss Vandegrift
Summary: Parameters w and h are declared as int for evas_common_rgba_image_from_data and evas_common_rgba_image_from_copied_data in evas_image_data.c. This does not match the prototypes in evas_image_private.h which declares them unsigned. Original report: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=748026 Reviewers: jpeg Reviewed By: jpeg Subscribers: cedric, jpeg Differential Revision: https://phab.enlightenment.org/D5540
2017-11-27elementary: fixed single typos in few modulesPawel Aksiutowicz
Reviewers: stanluk, lukasz.stanislawski Reviewed By: lukasz.stanislawski Subscribers: cedric, jpeg Differential Revision: https://phab.enlightenment.org/D5534
2017-11-27Efl.Ui.Format: remove the dupicalte codeAmitesh Singh
struct tm check is already done at the beginning of the function.
2017-11-27efl_ui_bg: add Efl.Gfx.color_get.Sungtaek Hong
Summary: since legacy elm_bg_color_set/get is changed to efl_gfx_color_set/get, efl_gfx_color_get also should get color of inner rect. @fix Test Plan: 1) run elementary test. 2) run Bg EO API(Efl.Ui.Bg) 3) set/unset "Bg color" check. 4) observe printed color values. Reviewers: jpeg, woohyun, cedric Differential Revision: https://phab.enlightenment.org/D5429
2017-11-26elm: fix legacy codeMarcel Hollerbach
earlier elm_object_focused_object_get returned gengrid genlist toolbar objects if a item of them is focused. This should fix that. thank you @davemds for the report!
2017-11-26ecore-wl2: Fix resource leakChris Michael
Coverity detected a resource leak here because we were not freeing the malloc'd 'obo' variable. Fixes Coverity CID1382907 Signed-off-by: Chris Michael <cp.michael@samsung.com>
2017-11-26elm_code: set the color scheme from the default edc.Al Poole
This allows us to override in the application also. Work from myself and @ajwillia.ms.
2017-11-26ecore ipc/con: fix nasty ... they dont mutually excludeCarsten Haitzler (Rasterman)
by deleting the socket they wont mutually exclude at bind which means eny new server just nides the pror one and you can get lots of copies of the same server. this wasnt the case before. it shouldnt have been. i think ther was an rm path for stale sockets when connecting failed or something. anyway... this here was causing multilpe efreetd's and all sorts of nastiness. this is the root cause. so... fix it. @fix
2017-11-24elm ifrace scrollable - fix uninitialized values on scroll asjustCarsten Haitzler (Rasterman)
dragable values were invalid (not fetched) so vx/y were junk and this was making decisions based on that. guarantee it to be 0. @fix
2017-11-24efl ui slider - fix crashes with fmt callback data and class dataCarsten Haitzler (Rasterman)
the format free cb was passed the class data (sd) as the callback data but this was freed by the time _indi_default_format_free_cb was called causing an invalid access. fix this by looking it up from the obj which is probably invalid at this point...
2017-11-24elua: correctly wrap gettext funcsDaniel Kolesa
Now, we cannot directly register funcs defined by a different signature than the lua standard (int (*)(lua_State *)) so we have to correctly wrap those with proper conversions etc.
2017-11-24elua - use safeptr with lightuserdata to work around luajit 64bit issueCarsten Haitzler (Rasterman)
luajit only supports 47bits on 64bit for lightuser data (bad! don't mess with opaque pointers... really unexpected and bad and probably should be fixed in luajit by doing things like on 32bit where pointers are not messed with etc.)
2017-11-24eina safepointer - mimic 47 bit eoid patchCarsten Haitzler (Rasterman)
same thing as b209b9a92286209281c12e81fd9dd72dc28c7495 but for safeptr
2017-11-24eo - by default on 64bit only use 47 bits because of luajitCarsten Haitzler (Rasterman)
luajit wants to check the upper 17 bits of pointers and assume they are all 0 if on a 64bit architecture. it will panic and barf if they are used. we have been using them in our eoid's for a long time. my take on this is that this is unportable. assuming how many bits are or are not valid in an opaque pointer (void *) that is simply passed to you and you cannot dereference or use (no size information even for what amount of data it points to etc.), is just wrong. it's not portable and it's trying to be too smart and creating such issues. my take is that luajit needs a fix for this in the longer term. but for now let's have a 47 bit mode and go with that. it does mean i have to drop our generation counter to 10 bits on 64bit (from 27 bits) which increases likelihood of eoid re-use being falsely detected as valid (before on 64bit it was 1 in 130 million or so chance, with this 47 bit change it's 1 in 1000. but to be fair on 32bit it's 7 bits for gen count so 1 in 127 ... so still more than 10x "safer" than on 32bit... but still...). the relevant check in luajit is: (((uint64_t)(p) >> 47) ? (lj_err_msg(L, LJ_ERR_BADLU), NULL) : (p)) it ONLY does this on 64bit. on 32bit pointers are not checked for validity at all. as an aside, armv8.2 seemingly will bring 52bit addresses so luajit is going to fall over flat on a newer rev of armv8. it may be x86 also uses more bits. last i knew it was 48bits so the 47 bit check luajit does i think is even wrong for x86-64. to be detailed i read: amd64 arch == 48 bits (so luajit is wrong). even better In addition, the AMD specification requires that the most significant 16 bits of any virtual address, bits 48 through 63, must be copies of bit 47 (in a manner akin to sign extension). so if the upper bit of 48 is set THEN all the 16 upper bits must be 1... breaking luajit, even if it were 47bit and this rule applied. I read the architecture allows for up to 52bits of actual addresses so architecture-wise this is even wrong... So I smell a core bug here in luajit. Certainly in the number of bits it insists must be 0 (the upper 17 bits where on amd64/x86-64 it should be the upper 16 bits... and even then these may NOT be 0 if bit 47 (the upper bit of the lower 48 is 1).... so the whole check is invalid... :( at least the above is at a theoretical level. i believe that the addresses divide the 48 bits into 2 chunks (thus 47)... but at the PHYSICAL level with no mmu and virtual memory. arm64 has this: https://www.kernel.org/doc/Documentation/arm64/memory.txt note in all cases the 2nd chunk of memory has at leats some upper bits of physical addresses beign 1 ... which makes luajit invalid tyo use without virtual memory remapping these away from high bits. @fix
2017-11-24mbe: Fix invalid part handlingJean-Philippe Andre
Only the text parts need special handling. Ping @CHAN :)
2017-11-24win: Fix window background EO APIsJean-Philippe Andre
Broken in a previous commit
2017-11-24elm: add custom access state for Elm.HoverLukasz Stanislawski
Reviewers: jpeg Subscribers: cedric Differential Revision: https://phab.enlightenment.org/D5523
2017-11-24layout: Fix erroneous warnings (from earlier patch)Jean-Philippe Andre
Oops. Bad check :)
2017-11-24elm_part: Mark as auto-unref before finalizeJean-Philippe Andre
This simplifies the IMPLEMENT macro, which can now be a proper function. Also, do not set a parent for the part object, as it's not useful and could mess up the refcount.
2017-11-24eo: Make sure auto_unref only applies after finalizeJean-Philippe Andre
It would be pretty stupid to create an object that dies before it even gets created. Auto-unref is for parts and should probably not be used anywhere else :)
2017-11-24part bg: Fix up some unnecessary complexityJean-Philippe Andre
See previous commit :) Note: right now the background part has a small 3d indent which comes from the legacy theme being used. This will be fixed soon.
2017-11-24efl_ui_layout: create efl_ui_bg when efl_part for background is called.Sungtaek Hong
Reviewers: woohyun, jpeg, cedric Subscribers: felipealmeida, cedric, jpeg Differential Revision: https://phab.enlightenment.org/D5151
2017-11-24Efl.Ui.Format: add string format checking for user inputAmitesh Singh
2017-11-24widget: Add EINA_UNUSEDJean-Philippe Andre
2017-11-24efl_ui_widget: secure elm_legacy_add flagSungtaek Hong
Summary: _elm_legacy_add goes back to EINA_FALSE after setting sd->legacy. if constructor get called again after going back to EINA_FALSE, sd->legacy should remain EINA_TRUE. also, elm_legacy_add() should not be called non-elm_widget. Test Plan: Run elementary test->Efl.Ui.Text.Label. Check legacy flag in _elm_theme_object_set() for efl_ui_win. Check legacy flag for efl_ui_text after scrollable text is added. Reviewers: jpeg, woohyun Reviewed By: jpeg Subscribers: cedric Differential Revision: https://phab.enlightenment.org/D5529
2017-11-23evas: remove warning from image_loaders/png/evas_image_load_pngPawel Aksiutowicz
Reviewers: stanluk, lukasz.stanislawski, cedric Reviewed By: cedric Subscribers: cedric, jpeg Differential Revision: https://phab.enlightenment.org/D5501 Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
2017-11-23efl_ui_bg: fix unclipped image on EFL_UI_IMAGE_SCALE_TYPE_NONESungtaek Hong
@fix Summary: efl_ui_bg has internal image and image may be larger than resize_obj when EFL.UI.IMAGE.SCALE_TYPE is none. Now resize_obj clips the internal image. Test Plan: 1.Run elementary_test, part background(will be added soon) 2.Create a bg in a box with other widgets. Set bg as EFL_UI_IMAGE_SCALYE_TYPE_NONE. Reviewers: jpeg, cedric Reviewed By: cedric Subscribers: woohyun Differential Revision: https://phab.enlightenment.org/D5509 Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
2017-11-23elementary: fix typos in elm_win_legacyPawel Aksiutowicz
Reviewers: stanluk, lukasz.stanislawski, cedric Reviewed By: cedric Subscribers: cedric, jpeg Differential Revision: https://phab.enlightenment.org/D5511 Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
2017-11-23elementary: fix typos in elm_gesture_layerPawel Aksiutowicz
Reviewers: stanluk, lukasz.stanislawski Subscribers: cedric, jpeg Differential Revision: https://phab.enlightenment.org/D5512 Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
2017-11-23elementary: fix typos in elm_atspi_bridgePawel Aksiutowicz
Reviewers: stanluk, lukasz.stanislawski Reviewed By: lukasz.stanislawski Subscribers: cedric, jpeg Differential Revision: https://phab.enlightenment.org/D5513 Signed-off-by: Cedric Bail <cedric@osg.samsung.com>