summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-11-18remove efl_canvas_animation_playerdevs/bu5hm4n/animation_workMarcel Hollerbach
this now all migrated to Efl.Canvas.Object.Animation Differential Revision: https://phab.enlightenment.org/D10667
2019-11-18evas: migrate the vg json exampleMarcel Hollerbach
Summary: i was not able to run the example before this commit, nor after this commit. However, i had to migrate this, as i want to remove the player object. Depends on D10637 Reviewers: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10666
2019-11-18efl_ui_spotlight_manager stack: move away from player objectMarcel Hollerbach
with this commit we move from using the player object to using the mixin that was introduced a few commits before. The new mixin is way easier to use here, we safe a lot of code, we also only need 1 object instead of 4. (And overall, everything just gets sooooo much more easier). Differential Revision: https://phab.enlightenment.org/D10637
2019-11-18elementary: move away from normal player to the new animation mixinMarcel Hollerbach
the mixin can handle the same things as the player. Additionally, the usage of the mixin simplifies the animation usage alot. Differential Revision: https://phab.enlightenment.org/D10636
2019-11-18introduce efl_canvas_object_animationMarcel Hollerbach
this brings the animation to the canvas object. All the controls of the animation now do now require a player object anymore, you can just use the API that is directly on the Efl.Canvas.Object object. wip animation player replacement Differential Revision: https://phab.enlightenment.org/D10615
2019-11-18Unify "animated" flagsXavi Artigas
There exist several flags to indicate whether an object should be animated, with inconsistent names: Efl.Canvas.Layout.animation: bool indicating if Edje animations should be played Efl.Ui.Spotlight_Manager.animation_enabled: bool indicating if page transitions should be animated Efl.Canvas.Animation_Player.animation: Efl.Canvas.Animation object This commit unifies all of them: "animated" is now a flag, and "animation" is an object. Note: Animation_Player is in the process of being replaced by an "animation" property in the Efl.Canvas.Object, hence the need for non-clashing animation flags. Differential Revision: https://phab.enlightenment.org/D10645
2019-11-18slider: fix value error from stepBowon Ryu
Summary: When the slider moves using step, _drag_value_fetch(), _val_fetch() calculates a value from position of edje_part. Then the calculated value is updated. However, this causes a slight error. This patch updates value ​​first when moving with steps. * Test Example ``` Evas_Object *sl = elm_slider_add(bx); elm_slider_min_max_set(sl, -5, 5); elm_slider_value_set(sl, 0.0); elm_slider_step_set(sl, 0.1); evas_object_size_hint_align_set(sl, EVAS_HINT_FILL, EVAS_HINT_FILL); evas_object_size_hint_weight_set(sl, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND); evas_object_smart_callback_add(sl, "changed", _change_cb, NULL); ``` ``` void _change_cb(void *data, Evas_Object *obj, void *event_info EINA_UNUSED) { double val = elm_slider_value_get(obj); if (val == -5.0) printf("val[%f] == -5.0 \n", val); if (val == -4.0) printf("val[%f] == -4.0 \n", val); if (val == -3.0) printf("val[%f] == -3.0 \n", val); if (val == -2.0) printf("val[%f] == -2.0 \n", val); if (val == -1.0) printf("val[%f] == -1.0 \n", val); if (val == 0.0) printf("val[%f] == 0.0 \n", val); if (val == 1.0) printf("val[%f] == 1.0 \n", val); if (val == 2.0) printf("val[%f] == 2.0 \n", val); if (val == 3.0) printf("val[%f] == 3.0 \n", val); if (val == 4.0) printf("val[%f] == 4.0 \n", val); if (val == 5.0) printf("val[%f] == 5.0 \n", val); } ``` If you move the slider using step in this test, You can see that some logs are not visible. (Some values ​​are incorrect) Test Plan: elementary_test -to slider elementary_test -to efl.ui.slider Reviewers: woohyun, cedric, bu5hm4n Reviewed By: woohyun, bu5hm4n Subscribers: bu5hm4n, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10662
2019-11-18docs: Typos in ninja doc screen outputXavi Artigas
2019-11-18doxygen: Prevent auto-linking of invalid linksXavi Artigas
Anything starting with http://, ftp:// or file:// is automatically converted into a link by doxygen. However, we have a few instances where we do not want this. Fortunately, doxygen allows using % to forbid specific words from being linked.
2019-11-18eldbus: only free the data when the future is resolved or rejected.Cedric BAIL
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D10684
2019-11-18evas image cache: drop cache properly,Hermet Park
the default reference is 1, thus we should drop it unless if it's more than 1,
2019-11-18evas vg: improve caching methods for better precise behaviors.Hermet Park
Previously, json file data won't be shared between instances. Now, objects can share the json data if they use the same file resource.
2019-11-18Revert "evas: migrate the vg json example"Hermet Park
This reverts commit a1f1cd6dd67de8eac0e302d47ce2aebf44aead16. Eeek, this shouldn't be pushed yet.
2019-11-18evas: migrate the vg json exampleMarcel Hollerbach
Summary: i was not able to run the example before this commit, nor after this commit. However, i had to migrate this, as i want to remove the player object. Depends on D10637 Reviewers: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10666
2019-11-17eo: do not over compute the hash when propagating events.Cedric BAIL
This should slightly improve speed in theory. In practice, I have not seen a benchmark which would budge by 5%, so I am not sure it improve speed that much. Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10660
2019-11-17eo: no need to oversize type.Cedric BAIL
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10659
2019-11-17eo: refactor shortcut for EFL_EVENT_DESTRUCT event.Cedric BAIL
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10658
2019-11-17ci/travis: remove no longer needed travis keywordsStefan Schmidt
Highlighted by the new build config validation feature we can see that sudo is no longer needed and on_cancel is not a valid keyowrk for IRC notifications. Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com> Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10665
2019-11-17ci/travis: Enable the new build config validation beta featureStefan Schmidt
This feature wil enable the validation of our config files (only .travis.yml in our case) and give out warnings and errors on problematic parts in the "View Config" tab on the Travis UI. Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com> Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10664
2019-11-17ci: cleanup the check for old meson versionsStefan Schmidt
We install the newest version via pip on our CI docker images. No longer need to check for this. Differential Revision: https://phab.enlightenment.org/D10681 Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
2019-11-17ci: remove logic for doing coverity builds only on SaturdayStefan Schmidt
We had this disabled for the release and I think having it run every nice is quite nice to give fast feedback on Coverity issues. Differential Revision: https://phab.enlightenment.org/D10680 Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
2019-11-16The header was filled with the standard template, now it's filled with ↵maxerba
correct infos
2019-11-16edje - box - calc min size correctly at start ...Carsten Haitzler (Rasterman)
this fixes a logic hole where no chosen desc has been applied yet to a box and thus it has no start layout thus no way to calc a min size. this breaks min size calcs you do when setting up and object. this fixes that by forcing the chosen desk on a min size calc so there is one. @fix
2019-11-16ecore-x - add some xi2 api's for fiddling with device propertiesCarsten Haitzler (Rasterman)
add some infra to be able to get and set device properties (as well as know if devices changed to we can refersh a gui or re-apply saved settings etc.). it doesn't do everything but... it adds enough to build on in e.
2019-11-16efreet - consider ctime changes as changes tooCarsten Haitzler (Rasterman)
some distros do odd things with source desktop files and set their mtime timestamps to 0... thus we can't tell that there is a change. thier ctimes do change, so consider the newer of either of these as the modification time to not miss updates @fix
2019-11-16strings - be cleaere we are initialising buffers not appendingCarsten Haitzler (Rasterman)
also should silence possible code checkers.
2019-11-16elm theme - ensure hotspot is visible so it is calculatedCarsten Haitzler (Rasterman)
new changes to avoid calcs on invisible parts means the hotspot doesnt recalc thus doesnt move thus... is wrong. make it visible in the theme to ensure it is.
2019-11-16add .uuid files to ignoreCarsten Haitzler (Rasterman)
2019-11-15Eina_Matrix : Use math header for cosf and sinf of rotate function.JunsuChoi
The local cos and sin functions differ from the math header cos and sin functions by result values The 4th decimal place is different. Computing large numbers can cause errors. Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10467
2019-11-15gl_drm: remove dead return statementStefan Schmidt
Summary: This return can never be reached in this function. CID: 1402607 Depends on D10682 Reviewers: raster, devilhorns Reviewed By: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10683
2019-11-15examples: efl_exe: fix out of bounds writeStefan Schmidt
Summary: Buf is 4096 in size and rw_slice.len also evaluates to 4096. Write at the last byte and not over bound instead. CID: 1403895 Reviewers: raster, bu5hm4n, devilhorns Reviewed By: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10682
2019-11-15eolian: fix memory leak when using error objectsDaniel Kolesa
2019-11-15efreet: fix typoBoris Faure
Summary: efreet: fix typo Test Plan: None Reviewers: cedric, raster, lauromoura, devilhorns, marcelhollerbach, segfaultxavi, zmike, vtorri Reviewed By: segfaultxavi, vtorri Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10676
2019-11-15csharp: FunctionPtr wrappers are not IDisposableLauro Moura
Summary: They don't actually store unmanaged memory and we already rely on the GC to free them (not calling Dispose() directly through the managedCb closure, so we don't need IDisposable. Just making sure we release the Function Pointer data in the main loop as the GC runs in a different thread. Ref T8423 Depends on D10672 Reviewers: brunobelo, felipealmeida, YOhoho Reviewed By: brunobelo Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8423 Differential Revision: https://phab.enlightenment.org/D10673
2019-11-15csharp: Silence CA2000 in testsLauro Moura
Summary: These objects are expected to leave scope while alive. Ref T8423 Depends on D10671 Reviewers: brunobelo, felipealmeida, YOhoho Reviewed By: brunobelo Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8423 Differential Revision: https://phab.enlightenment.org/D10672
2019-11-15csharp: Suppress CA2000 in native wrappers.Lauro Moura
Summary: These methods may instantiate `IDisposable` classes like `Array`, `Iterator` to pass to user-overriden C# methods. As we can't guarantee the user stored the object or not, we can't call Dispose directly on them. Ref T8423 Depends on D10670 Reviewers: brunobelo, felipealmeida, YOhoho Reviewed By: brunobelo Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8423 Differential Revision: https://phab.enlightenment.org/D10671
2019-11-15csharp: More CA2000 fixesLauro Moura
Summary: For eldbus.Proxy.Send, as the native function takes ownership of the message, we Ref it so it can still be used afterwards. Ref T8423 Reviewers: brunobelo, felipealmeida, YOhoho Reviewed By: brunobelo Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8423 Differential Revision: https://phab.enlightenment.org/D10670
2019-11-15Edje : textblock_styles strncmp improvementabdulleh Ghujeh
Summary: Improve string comparison Reviewers: cedric, ali.alzyod, woohyun, bu5hm4n Reviewed By: woohyun Subscribers: bu5hm4n, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10635
2019-11-14edje: Remove warningsLauro Moura
Missing declaration from another file and removing unused variable. After D10605 Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10674
2019-11-14csharp: Disposing IDisposable objects.Bruno da Silva Belo
Summary: ref T8423 Reviewers: lauromoura, felipealmeida, YOhoho Reviewed By: lauromoura Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8423 Differential Revision: https://phab.enlightenment.org/D10644
2019-11-14edje_calc: Exception handling if no calculation is required.Woochanlee
If there is no object swllowed, do not run part_calc on it. This swallow will be calculated if there is an associated part, otherwise it will not need to be calculated. When the app is launched, a lot of edje calculation logic is executed. Most of the edje size is missing, so the calculation result is meaningless. Added code to prevent this. Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10605
2019-11-14ecore-drm2: Fix issue of shifting 1 by more than 32bitsChris Michael
Based on 9ca573f40f1065cc717c0c5aabb787671bab852b, this patch fixes potential undefined behaviour on 64 bit systems. @fix
2019-11-14eo: fix UB in the eo event code (edje_cc hangs etc.)Daniel Kolesa
Today I started experiencing mysterious hanging of edje_cc during build. "The French are at it again" I thought, and after spending a while bisecting, I found the culprit. It's 7f53d9158395504151e1ff3dcae715a799d913a8. So, what is happening in here? The idea here was fundamentally sound; compute a special hash value for event descriptors, taking range between 0 and 63 (on 64-bit systems) and 0 and 31 (on 32-bit systems), then use a mask sized 32-bit or 64-bit (depending on your system) and check early if to bail out from callback_call, saving some resources. So far so good. The problem is in the way the mask is handled. We're applying the hash as the shift value like, `x |= (1 << hash)`. On 32-bit systems this is okay, but on 64-bit systems, C's dumb silent coercion rules kick in, since the left side of the expression is 1, a literal with type signed int; that means our shifting range is limited to 31 and what we get is... undefined behavior. This is obviously not what we want, so take a 1ULL value as a base. The previous thing seemingly worked on x86_64 (nobody reported any issues) and interestingly it worked for me too for a while (on ppc64le), but undefined behavior can be unpredictable, so... This shouldn't need a commit message as long as this, but I'm making it proportional to the amount of time I wasted on this.
2019-11-14efl_canvas_vg_node: Prevent access to NULL object for remove warningJunsuChoi
Summary: For remove this warning WRN<3378>:eo ../src/lib/eo/eo.c:644 _efl_object_call_resolve() NULL passed to function efl_invalidated_get(). Test Plan: elementary_test -> animation_view Reviewers: Hermet, kimcinoo, smohanty Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10627
2019-11-13efl: improve Efl.BooleanModel test by checking the child del case.Cedric BAIL
This has detected the bug that previous commit fix. Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10634
2019-11-13efl: remove useless printf from Efl Container Model tests.Cedric BAIL
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10633
2019-11-13ecore: correctly apply the offset on the upper part of the boolean mask for ↵Cedric BAIL
Efl.BooleanModel. The upper mask is the one that should actually move as the gap is between the lower and the upper mask when removing an element from the array. Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10632
2019-11-13ecore: remove the composited children from the source of an Efl.CompositeModel.Cedric BAIL
The composite model was erroneously giving the reference to a children composited model instead of the origianl children which made it impossible for the composited model to delete the right child. Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10631
2019-11-13elementary: fix initialization order and memory leak when setting model on ↵Cedric BAIL
Efl.Ui.CollectionView. This patch use volatile model to make sure that a model is properly cleaned once it is not used anymore. Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10625
2019-11-13elementary: fix recursive case during model fetch in Efl.Ui.CollectionView.Cedric BAIL
Figuring out why model fetch was sometime not working recursively allow to reduce the amount of request that need to be made. In this case, notifying the position manager or lack of notification was triggering a case where the item would not show up (Joice of nested asynchronous behavior). Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10624