summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-04-19HACK: remove broken APIdevs/bu5hm4n/eo_file_updatesMarcel Hollerbach
cannot correctly work
2020-04-19eo-files: convert all Eina.Strbuf & Eina.BinbufMarcel Hollerbach
these structs should not be used, but rather the builtin types that exist for it.
2020-04-19efl_ui_win: declare constructors not optionalMarcel Hollerbach
they cannot be optional, or in later languages types will collide.
2020-04-19elementary: fix string definitionMarcel Hollerbach
eolian is note made to have ptr(char) be the same as string.
2020-04-19eina: add new definitions to a old arrayMarcel Hollerbach
this is sadly needed due to the fact that we have a .eo defnition in the .eot file which contains the flags keyword.
2020-04-19elementary: these definitions are in real header filesMarcel Hollerbach
there is no reason to have them in the .eot files. They are also not namespaced in the way we want to have types.
2020-04-19evas: remove dead struct definitionMarcel Hollerbach
this is not used anywhere
2020-04-19eo: install eot files correctlyMarcel Hollerbach
eina_types.eot is needed in order to fetch all needed informations.
2020-04-19elementary: do not install legacy .eo filesMarcel Hollerbach
they do not have any purpose to be installed on the filesystem.
2020-04-19eo: make the parent a optional constructorMarcel Hollerbach
this is needed in order to sanely bind parent calls to some objejcts, but not all. However, from the canvas structure up we *need* a parent, so we can fetch the evas from it. So declare it there a none optional
2020-04-19meson: do not install .eo files of not installed header filesMarcel Hollerbach
2020-04-19efl_ui_focus_manager_calc: correctly flag elements usedMarcel Hollerbach
when setting the relation from two widgets a<->b a is used as well as b. This now correctly sets these flags.
2020-04-19exactness-inspect: remove abscure xor checkMarcel Hollerbach
this is a obscure check, if this was ever reached, then it would simply crash, because one pointer will be NULL, but strcmp will be called on it. CID 1419854 Differential Revision: https://phab.enlightenment.org/D11722
2020-04-19eolian: globally enable eolian_state_check, except for beta classesDaniel Kolesa
Beta classes won't have their namespaces validated at this point. It is possible to set EOLIAN_CHECK_NAMESPACES_BETA=1 to enable checking those as well, if you want to fix them all.
2020-04-19remove unused imports in eo/eot filesDaniel Kolesa
2020-04-19eolian: add composites into hard deps when checkingDaniel Kolesa
This prevents composites from being considered unused imports.
2020-04-18evas_textblock/evas_text/evas_textgrid: pick textrun fontsCarsten Haitzler (Rasterman)
Summary: Picking font on textrun, will now give priority into font picked by the user, regardless of script type. picking font due script can cause many inconvenient results Example of wrong results: (User font is **NotoColorEmoji**) {F3847118} -> add 'a' at the end (notice how text render is wrong) {F3847119} -> add tab before 'a' (text rendering now is right) {F3847120} After Change results: (User font is **NotoColorEmoji**) {F3847118} -> add 'a' at the end -> {F3847122}-> add tab before 'a' -> {F3847123} Also now the following lines will be shown exactly the same, regardless of characters order ``` "가123A321" "A321가123" "123가A321" "A가123321" ``` Test Plan: ``` #include <Elementary.h> /* gcc -o example test.c `pkg-config --cflags --libs elementary` */ EAPI_MAIN int elm_main(int argc EINA_UNUSED, char **argv EINA_UNUSED) { Evas_Object *win, *en; elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED); win = elm_win_util_standard_add("", ""); elm_win_autodel_set(win, EINA_TRUE); en = elm_entry_add(win); elm_entry_scrollable_set(en, EINA_TRUE); evas_object_size_hint_weight_set(en, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND); evas_object_size_hint_align_set(en, EVAS_HINT_FILL, EVAS_HINT_FILL); elm_entry_text_style_user_push(en,"DEFAULT='font=NotoColorEmoji font_size=30 color=red'"); elm_object_text_set(en, "&#x262a;123456a"); evas_object_show(en); elm_object_content_set(win, en); evas_object_resize(win, 400, 200); evas_object_show(win); elm_run(); return 0; } ELM_MAIN() ``` Reviewers: woohyun, bowonryu, tasn, raster, cedric Reviewed By: tasn Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8556 Differential Revision: https://phab.enlightenment.org/D11302
2020-04-18evas_textgrid: update text props to use current script fontAli
Summary: This update make the textgrid same as evas_text and evas_textblock to use current picked font for text_props instead of script_font This patch will fix terminology emoji rendering when used applying D11302. Reviewers: raster, woohyun Reviewed By: woohyun Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11729
2020-04-18evas render - flush, dont clear unref/clean arrays on render doneCarsten Haitzler (Rasterman)
we build these arrays to hold tjhings to clean up when done ... but if one frame happens ot have a lot - the allocation stays huge as we only clean not flush, so flush to keep memory down. @optimize
2020-04-18Fixing POTFILES and updating italian translationmaxerba
2020-04-17Revert "evas_textblock: pick textrun fonts"Carsten Haitzler (Rasterman)
This reverts commit 9b987c67e1e38602ba2e4c9c990798e99d938bbe. this breaks color emoji in terminology (evas textgrid).
2020-04-17exactness-inspect: unit1 can never be NULLMarcel Hollerbach
checkinf for it beeing NULL means that we would have to equip every usage of unit1 with a check, but that is useless. CID 1419859 Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11721
2020-04-17exactness-inspect: fix NULL accessMarcel Hollerbach
ii might be NULL so we should ensure it is not NULL to call item_select CID 1419865 Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11720
2020-04-17exactness-inspect: sanitize if clauseMarcel Hollerbach
these if clause where a bit bottom up, and the xor operation here seemed totally wrong, with this code we are simply displaying both entiteis of the two structs when they are there. *or* we are replacing it with the fallback. CID1419875 Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11719
2020-04-17elm - genlist test - handl g_data being nullCarsten Haitzler (Rasterman)
fix CID 1396944 1396946
2020-04-17ecore - examples - fix gnutls fd handler example warningsCarsten Haitzler (Rasterman)
just error returns not being checked. not an issue really, but this silences warnings. fix CID 1164185 715896 98094 1400818
2020-04-17ecore - proc env - fix values return NULL case - coverityCarsten Haitzler (Rasterman)
this fixes CID 1419857
2020-04-17ecore evas - wl - fix useless iff case for rotationCarsten Haitzler (Rasterman)
rotationis handled later on in the func thsi fixes CID 1419870
2020-04-17evas cache - up padding just in case i was off by oneCarsten Haitzler (Rasterman)
coverity was complaining but it's a false positive - it seems to not realze the loadopts_append does nul terminate at the end.
2020-04-17edje: fix cursor scrollingBowon Ryu
If there is a string larger than the size of entry and when the entry is auto scrolling, cursor is not visible. Using _edje_entry_cursor_geometry_get guarantees the minimum size of the cursor, and guarantee the size from edje. (min_restricted_calc) Reviewed-by: Ali Alzyod <ali198724@gmail.com> Differential Revision: https://phab.enlightenment.org/D11649
2020-04-17tests/elm: add image tests to verify internal object size is clamped to ↵Mike Blumenkrantz
object size ensure that this doesn't break again ref 11587 Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11599
2020-04-17canvas svg: fix memory leak.Hermet Park
free svg node commands & points data after usage. @fix
2020-04-17evas_textblock: prevent segfault if there are no styleAli
``` #include <Elementary.h> EAPI_MAIN int elm_main(int argc EINA_UNUSED, char **argv EINA_UNUSED) { Evas_Object *win, *textblock; elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED); win = elm_win_util_standard_add("", ""); elm_win_autodel_set(win, EINA_TRUE); textblock = evas_object_textblock_add(win); evas_object_resize(textblock, 360, 360); evas_object_show(textblock); evas_object_textblock_text_markup_set(textblock, "<b>b</b>"); evas_object_resize(win, 360, 360); evas_object_show(win); elm_run(); return 0; } ELM_MAIN() ``` this application will crash. Any font format specified in text, if there are now style will cause the crash. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11686
2020-04-17eina/value: use correct time types when comparing time typesMike Blumenkrantz
these functions all expect struct timeval, as the name implies ../src/lib/eina/eina_value.c: In function ‘_eina_value_type_tm_compare’: ../src/lib/eina/eina_value.c:3358:19: warning: array subscript 1 is outside array bounds of ‘time_t[1]’ {aka ‘long int[1]’} [-Warray-bounds] 3358 | struct timeval ret = *input; | ^~~ ../src/lib/eina/eina_value.c:3569:11: note: while referencing ‘ta’ 3569 | time_t ta, tb; | ^~ ../src/lib/eina/eina_value.c:3358:19: warning: array subscript 1 is outside array bounds of ‘time_t[1]’ {aka ‘long int[1]’} [-Warray-bounds] 3358 | struct timeval ret = *input; | ^~~ ../src/lib/eina/eina_value.c:3569:15: note: while referencing ‘tb’ 3569 | time_t ta, tb; Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11715
2020-04-17eina_content: free eina content in the test:Marcel Hollerbach
Fix the unbelievable High prioritized CID 1420314
2020-04-17elm/win: declare prototype for ecore_evas_dnd_mark_motion_usedMike Blumenkrantz
../src/lib/elementary/efl_ui_win.c: In function ‘_motion_cb’: ../src/lib/elementary/efl_ui_win.c:9271:14: warning: implicit declaration of function ‘ecore_evas_dnd_mark_motion_used’ [-Wimplicit-function-declaration] 9271 | ecore_evas_dnd_mark_motion_used(ee, seat); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Differential Revision: https://phab.enlightenment.org/D11717
2020-04-17exactness: limit length for font_path to stay in bufferStefan Schmidt
We get fonts_dir from a getenv() without and length check. Make sure that we stay in the given buffer size when stitching the file path together. CID: 1422195 Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11718
2020-04-17exactness: fix typo in function nameStefan Schmidt
Simple spelling mistake. overlay instead of overloay. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11714
2020-04-17exactness: remove no longer used code since move to preloadStefan Schmidt
This has been around for prg handling before we switched to preload. No need for it anymore. Found when looking for a Coverity issue, which also got fixed now by luck. :-) CID: 1421994 Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11713
2020-04-17evas_textblock: remove special treat for variation sequence text runAli
Summary: Now there are no need for special care for variation sequence text run break. General method will care about all types of characters\ this is also related to D11096 Reviewers: woohyun, bowonryu Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11602
2020-04-17evas_textblock: pick textrun fontsAli Alzyod
Summary: Picking font on textrun, will now give priority into font picked by the user, regardless of script type. picking font due script can cause many inconvenient results Example of wrong results: (User font is **NotoColorEmoji**) {F3847118} -> add 'a' at the end (notice how text render is wrong) {F3847119} -> add tab before 'a' (text rendering now is right) {F3847120} After Change results: (User font is **NotoColorEmoji**) {F3847118} -> add 'a' at the end -> {F3847122}-> add tab before 'a' -> {F3847123} Also now the following lines will be shown exactly the same, regardless of characters order ``` "가123A321" "A321가123" "123가A321" "A가123321" ``` Test Plan: ``` #include <Elementary.h> /* gcc -o example test.c `pkg-config --cflags --libs elementary` */ EAPI_MAIN int elm_main(int argc EINA_UNUSED, char **argv EINA_UNUSED) { Evas_Object *win, *en; elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED); win = elm_win_util_standard_add("", ""); elm_win_autodel_set(win, EINA_TRUE); en = elm_entry_add(win); elm_entry_scrollable_set(en, EINA_TRUE); evas_object_size_hint_weight_set(en, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND); evas_object_size_hint_align_set(en, EVAS_HINT_FILL, EVAS_HINT_FILL); elm_entry_text_style_user_push(en,"DEFAULT='font=NotoColorEmoji font_size=30 color=red'"); elm_object_text_set(en, "&#x262a;123456a"); evas_object_show(en); elm_object_content_set(win, en); evas_object_resize(win, 400, 200); evas_object_show(win); elm_run(); return 0; } ELM_MAIN() ``` Reviewers: woohyun, bowonryu, tasn, raster, cedric Reviewed By: tasn Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8556 Differential Revision: https://phab.enlightenment.org/D11302
2020-04-16evas_test: change START_TEST to EFL_START_TESTAli
Summary: evas_test: change START_TEST to EFL_START_TEST Reviewers: zmike Reviewed By: zmike Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11716
2020-04-16ecore_evas: fix fallback codeMarcel Hollerbach
this was using a stringshare reference that was deleted. While that is true, the stringshare reference will always be alive, because 2 people took a reference. Anyways, this code is now searching the other way arround, which makes the code also easier. fixes: CID1420331 Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11712
2020-04-16tests/elm: explicitly destroy hoversel while activeMike Blumenkrantz
verify that there's no errors when this happens Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11704
2020-04-16tests/elm: add hoversel test to verify edge of canvas positioningMike Blumenkrantz
ensure that T8642 doesn't reoccur Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11647
2020-04-16elm/hoversel: force calc on internal hover object during activateMike Blumenkrantz
hoversel can't accurately determine its location until the hover object has been calculated, so this needs to always happen before the hoversel is made visible in order to correctly position the hover fix T8642 Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11646
2020-04-16tests/elm: add hoversel behavior testsMike Blumenkrantz
this verifies all smart callbacks for a hoversel to ensure they're triggered as expected Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11644
2020-04-16elm/hoversel: remove unnecessary internal callback deletionMike Blumenkrantz
this already happens automatically on every item destruction and passes the item data through there to ensure the correct callback is removed Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11643
2020-04-16elm/hoversel: use a wref to accurately track internal hover objectMike Blumenkrantz
this pointer is never unset, which can cause errors when attempting to access it after the hoversel has been deactivated Differential Revision: https://phab.enlightenment.org/D11642
2020-04-16tests/elm: add callback tests for elm_listMike Blumenkrantz
basic tests to verify behavior for triggering callbacks when selecting items Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11703