summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-02-28doxygen: fix duplicated intro sectionsXavi Artigas
2020-02-27edje_entry: avoid memory leak on error pathStefan Schmidt
In commit 8cb0b193ea0 the logic was changed and we could return here without free'ing the plain_text resource we allocated. Make sure we handle this even on the error case and early return. CID: 1408481 Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11433
2020-02-27exactness: inspect: use logical OR instead bitwise XORStefan Schmidt
Coverity pointed these out as we deferences after null check. Looking into it showed these use of a bitwise operator on vars where it does not make any sense (to me). They look like wrongly done NULL checks. Switchign them over to a logical OR operator. CID: 1419876, 1419869, 1419868, 1419862, 1419854, 1419849 Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11432
2020-02-27exactness: inspect: remove unreachable codeStefan Schmidt
If dt equals EX_FONTS_DIR we would have returned already. CID: 1419879 Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11430
2020-02-27exactness: handle error cases for saving an imageStefan Schmidt
Handle the error case and propagate the error upwards. CID: 1419855 Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11428
2020-02-27evas_model_load_ply: Prevent memory leakJunsuChoi
Summary: If use ein_str_split, have to free the first element of the array and free the array. Test Plan: N/A Reviewers: Hermet, YOhoho, bu5hm4n, zmike Reviewed By: zmike Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11419
2020-02-26exactness: use eina_strdup() to avoid extra NULL checkingStefan Schmidt
strdup() would not be happy about a NULL to copy, but we have eina_strdup in place already to handle this gracefully. CID: 1419846 Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11421
2020-02-26exactness: check return code from ecore_evas_initStefan Schmidt
Check if we can initialize correctly and return failure if not. CID: 1419872, 1419864, 1419867, 1419850 Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11420
2020-02-26exactness: avoid leak on leaving scopeStefan Schmidt
Before we leave the fucntion here we need to free our temporaray paths variable. CID: 1419860 Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11411
2020-02-26exactness: player: allow space for the terminating nullStefan Schmidt
Allocate extra space for the terminating null byte and / of the string. Switch to snprintf() as well. CID: 1419863 Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11410
2020-02-26edje_load: fix possible null pointer dereferenceJaehyun Cho
2020-02-26elm_slider: Add return value checkJunsuChoi
Summary: Calling eina_value_get() without checking return value. CID: 1400991 Test Plan: N/A Reviewers: YOhoho, Hermet, Jaehyun_Cho, CHAN Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11416
2020-02-26test/suite_helpers : Fix warnings about use to uninitialized value.JunsuChoi
Summary: remove warnings. ../src/tests/elementary/suite_helpers.c:779:86: warning: ?idy2? may be used uninitialized in this function [-Wmaybe-uninitialized]. ... Test Plan: N/A Reviewers: YOhoho, Hermet, Jaehyun_Cho Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11417
2020-02-26elementary_test/ui_spotlight: Fix warnings about use to uninitialized value.JunsuChoi
Summary: remove warnings. ../src/bin/elementary/test_ui_spotlight.c:1126:9: warning: 'view' may be used uninitialized in this function [-Wmaybe-uninitialized] ... Test Plan: N/A Reviewers: YOhoho, Hermet, Jaehyun_Cho Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11418
2020-02-25exactness: injector: free local buffersStefan Schmidt
Make sure we free local resources before we break. CID: 1419845 Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11414
2020-02-25exactness: inspect: free image before leaving scopeStefan Schmidt
We need to amke sure we free this images before we return. CID: 1419848 Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11413
2020-02-25exactness: close file we openedStefan Schmidt
We only opened it read only, but this should still be closed before leaving. CID: 1419853 Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11412
2020-02-25evas: software_engine: free allocation on error pathStefan Schmidt
When we allocated s but fail to allocate l we need to make sure to free the first allocation before erroring out. CID: 1419874 Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11409
2020-02-25exactness: inspect: free local allocation before leaving scopeStefan Schmidt
Before we leave the scope here this needs to get free'd up or it will leak. CID: 1419877 Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11408
2020-02-25exactness: inspect: fix memory leak of buffer in error pathStefan Schmidt
If we hit this error path we need to release the allocated buffer. CID: 1419878 Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11407
2020-02-25Ecore_Win32: free 'compose' field when needed, fix memory leakVincent Torri
Reviewers: raster, zmike Reviewed By: zmike Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11415
2020-02-25Evil: add evil_utf8_to_utf16() API ; use evil_utf16_to_utf8() in Ecore_Win32Vincent Torri
Summary: use existing utf-16 to utf-8 conversion function in Ecore_Win32. Add API to convert utf-8 to utf-16 in Evil for copy'n paste on Windows Test Plan: compilation Reviewers: raster, zmike Reviewed By: zmike Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11406
2020-02-25tests/elm: verify image file_set -> memfile_set -> file_setMike Blumenkrantz
Summary: ref D11392 Depends on D11397 Reviewers: kimcinoo, Hermet Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11398
2020-02-25tests/elm: fix elm_icon testMike Blumenkrantz
Summary: * this was left as a duplicated efl_ui_image test * elm_image doesn't have a legacy api for setting icons * elm_icon doesn't actually have any tests for icon loading Depends on D11396 Reviewers: kimcinoo, Hermet Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11397
2020-02-25test_efl_gfx_vg_value_provider: expand buffer to avoid truncation by snprintfYeongjong Lee
Test Plan: compile with `-Wformat-truncation` Reviewers: raster, Hermet, segfaultxavi Reviewed By: segfaultxavi Subscribers: segfaultxavi, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11405
2020-02-25elm/image: restore legacy behavior of elm_image_file_getMike Blumenkrantz
Summary: this should operate on the internal image object to reflect the file state there instead of the outer object Reviewers: kimcinoo, Hermet Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11396
2020-02-25vg_common_json: Fix to duplication of mask and matte.JunsuChoi
Summary: There is a case that uses a mask and a mat at the same time. One of them did not apply. This patch modifies two attributes to be parent-child. Test Plan: N/A Reviewers: Hermet, smohanty, kimcinoo Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11399
2020-02-24Summary: code refactoring - get rid of unneccessary Efl.Access.Value interface.Mateusz Denys
reviewers_: l.oleksak, stanluk, bu5hm4n, zmike Reviewed By: l.oleksak Subscribers: zmike, l.oleksak, cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8578 Reviewed-by: Lukasz Oleksak <Lukas.Oleksak> Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11304
2020-02-24database_expr: fix memory leak when type error happensJaehyun Cho
Summary: Memory leak is fixed when type error happens. Reviewers: q66 Reviewed By: q66 Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11400
2020-02-24efl_ui/image_zoomable: add icon setting fallback for fdo iconsMike Blumenkrantz
Summary: same as D11381 ref 697308a16f77e3e7b7dac6e74293850a3950e3d3 Reviewers: segfaultxavi Reviewed By: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11403
2020-02-24Efl.Ui.Image: Add fallback when icon is not found in default themeXavi Artigas
Summary: If _icon_standard_set() fails, _icon_freedesktop_set() is tried. This was causing missing icons in the homescreen example, which uses application icons which are obviously not present in the default theme. Thanks to @bu5hm4n! Test Plan: The homescreen sample application from the examples repository now correctly shows all missing icons. Reviewers: bu5hm4n, zmike Reviewed By: zmike Subscribers: cedric, #reviewers, #committers, bu5hm4n Tags: #efl Differential Revision: https://phab.enlightenment.org/D11381
2020-02-24elm : move unrealize callback call before the content caching.SangHyeon Jade Lee
Summary: item edje and contents are cached for performance improvement in genlist & gengrid. but to provide elm_genlist(gengrid)_all_contents_unset method before the contents are being cached, unrealize callback must be come before the unrealize process. currently, item_unrealize 1.unrealize process 2.contents cached 3.unrealize callback 4.all_contents_unset : nothing to unset in the item. by this patch, item_unrealize 1.unrealize callback 2.all_contents_unset : contents are unset. 3.unrealize process 4.contents(null) cached Reviewers: bu5hm4n, cedric, eagleeye, zmike Reviewed By: zmike Subscribers: zmike, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11402
2020-02-24edje/style: Fix a problem where embedded font does not load in edjBowon Ryu
Summary: When edje_font_is_embedded the path of the font must be "font=edje/fonts/%s" The previous code is "font=%s" This causes the font to not load properly when edje_font_is_embedded. Test Plan: edje_cc test.edc edje_player test.edj collections { group { "main"; fonts { // Set any two fonts in your local path. font: "ANYFONT_1.TTF" "font_1"; font: "ANYFONT_2.TTF" "font_2"; } styles { style { name: "textblock_style_1"; base: "font=font_1 font_size=30 color=#ffffff"; } style { name: "textblock_style_2"; base: "font=font_2 font_size=30 color=#ffffff"; } } parts { spacer { "base"; scale; desc { "default"; min: 600 250; max: 600 250; } } rect { "bg"; scale; desc { "default"; rel.to: "base"; color: 5 5 5 255; } } textblock { "tb1"; scale; desc { "default"; rel.to: base; rel1.relative: 0 0; rel2.relative: 1 0.5; text.text: "THIS IS FONT 1"; text.style: "textblock_style_1"; } } textblock { "tb2"; scale; desc { "default"; rel.to: base; rel1.relative: 0 0.5; rel2.relative: 1 1; text.text: "THIS IS FONT 2"; text.style: "textblock_style_2"; } } } } } Reviewers: smohanty, CHAN, Hermet Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11401
2020-02-24Revert "elm_spinner: Fixed to apply the %d format."Jaehyun Cho
This reverts commit b8a24679a6f7995ccc1da19eb86c6c2ef6826d1a. Differential Revision: https://phab.enlightenment.org/D11394
2020-02-23eina: Fix warnings about unused variables on WindowsChristopher Michael
NB: Patch from vtorri
2020-02-21ci: travis: ensure we update brew as well to avoid a problem on Travisdevs/stefan/ci-macos-fixStefan Schmidt
We normally did not use update as it could take up a few minutes for every macos build and the packages have been recent enough. Since a few hours we see build problems now on Travis: Error: Unknown command: bundle A way to get them fixed (until Travis updates their images for macos) is to use the update command. https://travis-ci.community/t/macos-build-fails-because-of-homebrew-bundle-unknown-command/7296/9 Also moving to a newer osx image here to avoid falling further behind on the dependencies.
2020-02-21efl_ui_image: unload file before memfile_setShinwoo Kim
Summary: If memfile_set does not remove prev file information, it is not possilbe to load image using the same file information after memefile_set. It means that below line 3 does not work because the same file information remains for Efl.Ui.Image_Legacy. 1 | elm_image_file_set(obj, "1.jpg", NULL) 2 | elm_image_memfile_set(obj, img, size, "jpg", NULL) 3 | elm_image_file_set(obj, "1.jpg", NULL) This patch removes line calling _efl_ui_image_file_set_do becasue it is called in efl_file_unload > _efl_ui_image_efl_file_unload. Test Plan: [Sample Code] {F3848315} [Reproduce Step] 1. File2 2. Memfile 3. File2 Reviewers: Hermet, jsuya Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11392
2020-02-20efl_ui_exact_model: use eina APIs to get the nth dataYeongjong Lee
Summary: Also, fixes a compiler warning ``` ../src/lib/elementary/efl_ui_exact_model.c:60:17: warning: variable 'tbuf' set but not used [-Wunused-but-set-variable] ``` Test Plan: ninja Reviewers: cedric, zmike, bu5hm4n Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11380
2020-02-20canvas proxy: fix broken proxy source clipping function.Hermet Park
The issue is proxy source clipping is not applied properly, Obviously that is a regression bug by the code refactoring. Found out this condition is insane, looks like a wrongly introduced. @fix
2020-02-20edje: guarantee the theme abi compatility.Hermet Park
if old edj doesn't include "zoom_center" properly, the initial value will be set with zero, We can overwrite it in that case since zoom_center initial value is -1.
2020-02-20Efl.Ui.Spotlight: Fix indicator initializationXavi Artigas
This caused incorrectly-centered indicator icons in the homescreen example.
2020-02-19edje: modify to respect user set fixed propertyWonki Kim
Summary: this patch is related with @D11365. rather than undoing optimization edje calc, this patch introduces a user_set property which enables edje_calc to respect user set property. Reviewers: bu5hm4n, eagleeye, YOhoho, Hermet, zmike Reviewed By: zmike Subscribers: zmike, cedric, #reviewers, #committers, woohyun, eagleeye, bu5hm4n Tags: #efl Differential Revision: https://phab.enlightenment.org/D11366
2020-02-19docs: A bit more info and formatting for Eina_Process_CbXavi Artigas
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11063
2020-02-19eina: introduce eina_iterator_processMarcel Hollerbach
this brings a functional-map function to the iterator implementations. https://en.wikipedia.org/wiki/Map_(higher-order_function) Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D11062
2020-02-19efl_ui_draggable: move these events back to legacyMarcel Hollerbach
they are not used yet in efl.ui. namespace, and they are needed for different events. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11196
2020-02-19Adding "elm,calendar,ch_%d,weekend" and "elm,calendar,ch_%d,weekday" signals ↵rafspiny
from "elm". The calendar object in elementary needs to know which days are weekdays and which are weekend days in order to properly change the state of the header's labels. This code add a signal emission from e_calendar.c when setting the header. Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11375
2020-02-19elementary: use array instead of list for subchildrenMarcel Hollerbach
this safes in the runtime of elm_test round about 9kb (*). Additionally, using a array here is jumping way fewer times arround in memory, as we do not need to jump from node to node in a list. Additionally, this commit replaces a few abort disabler macros with a error checking macro. (which cleans the log). *: explanation: we have round about 600 widgets in elm_test, every widget is normally refered once, every list node has 4 pointer, makes round about 9600 bytes or rougly 9 KB. So the messured savings are more or less explaining the reality. Reviewed-by: Carsten Haitzler (Rasterman) <rasterman.com> Differential Revision: https://phab.enlightenment.org/D11374
2020-02-19eina_array: interpret the count of a NULL array as 0Marcel Hollerbach
this makes the usage way more convinient. Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es> Differential Revision: https://phab.enlightenment.org/D11373
2020-02-19ecore_con: fix to check a return value of functionsWonki Kim
this path fixes to check a return value of functions. Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11371
2020-02-19efl_con: add a default condition to switch statementWonki Kim
this patch modifies conditions to extract range conditions out of switch statement Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11370