summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-04-14ecore_evas_x: add safety check for data in converterdevs/bu5hm4n/work_dndMarcel Hollerbach
since the existance of seleciton manager, the converter callbacks from ecore_x are expecting custom struct pointers. However, enlightenment never updated to use the elm dnd API for client side usages. Which results in the fact that sometimes, when a client sents Notify, and e_dnd is active, that this converter is executed with the wrong data. With this commit the data passed in is ensured to have the correct magic number. The proper solution for this would either be registering the correct converters in enlightenment, or update to elm_drag. However, since the continues cried river over the last 5 days has raised enough hydro power to add these changes. This leaves us with just one question: How was it possible to generate so many messages about a problem that can be solved in a fraction of charaters that have been written? fixes <a-issue-that-was-never-created> Differential Revision: https://phab.enlightenment.org/D11701
2020-04-14ecore_evas_x: reject the promise instead of returnMarcel Hollerbach
this is needed in order to tell the API user that this is not going to be completed. Differential Revision: https://phab.enlightenment.org/D11700
2020-04-14ecore_evas: add API for finding out if event is usedMarcel Hollerbach
ecore_x_dnd_send_status can be used to indicate if a item can be dropped on a client or not. However, we should only indicate that this can be dropped, if there is a object we signaled that a drop is in. Long story short: there is no assertion that after indicating that things can be dropped, that a notify for the data is sent. A drag implementation should always listen to a mouse up event, and abort the drag if no further operations are sent. Differential Revision: https://phab.enlightenment.org/D11699
2020-04-14elm_dnd: support target setting on none evas_objectsMarcel Hollerbach
before this only worked for elm widgets. This however is the same behaviour as in efl_ui_selection_manager.c. So this restores the behaviour prior to selection_manager. Differential Revision: https://phab.enlightenment.org/D11698
2020-04-14ecore_evas_x: allow parsing of links form the link listMarcel Hollerbach
this is needed in order to return the data the same way the legacy impl did. This however has the annoying sideeffect that ecore_evas_x now depends on efreet, and we had to change the build order. Differential Revision: https://phab.enlightenment.org/D11697
2020-04-14build: fix libraries of efreet-mime -trashMarcel Hollerbach
the dependencies were simply wrong. Differential Revision: https://phab.enlightenment.org/D11696
2020-04-14elm_dnd: complete the list of text typesMarcel Hollerbach
the text types added here were present as "TEXT" in selection manager, so add them here again. Differential Revision: https://phab.enlightenment.org/D11684
2020-04-14elm_slider: create timer for hiding laterMarcel Hollerbach
_popup_show deletes the hide timer, hence we need to create the timer later on, or this will not automatically hide the indicator. Differential Revision: https://phab.enlightenment.org/D11679
2020-04-14evas_main: add null check for safetyWooHyun Jung
2020-04-13eo: null check for vtable allocationYeongjong Lee
Reviewers: bu5hm4n, Jaehyun_Cho Reviewed By: Jaehyun_Cho Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11687
2020-04-13elm_cnp: fix memory leaksTaehyub Kim
Summary: In copy and paste logic, there are some memory leaks logic. so fixed. @fix Reviewers: bu5hm4n, Jaehyun_Cho Reviewed By: Jaehyun_Cho Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11690
2020-04-13evas text: fix memory leak.Hermet Park
Summary: free used memory properly. Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11691
2020-04-13Ector: Refer to visibility of Ector_Renderer when doing rle_update.JunsuChoi
Summary: An object with visibility false may not have a normal path or data. It can cause invalid access or affect other ector renderers. This is a patch to prevent them. Test Plan: N/A Reviewers: Hermet, kimcinoo, herb Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11689
2020-04-13elm_atspi_bridge: fix memory leakShinwoo Kim
Summary: Dynamic memory is allocated by calling function 'eldbus_message_iter_container_new' and lost by returning without free. Reviewers: Hermet, woohyun, jsuya, herb Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11688
2020-04-13edje_calc: add null check after eet_readWooHyun Jung
2020-04-12fix buid on bsdCarsten Haitzler (Rasterman)
2020-04-12ecore con - clean up file lock andunlock on failed bindCarsten Haitzler (Rasterman)
didnt do this if bind failed... so do it now.
2020-04-12ecore-evas - x dnd/cnp - handle null data content and not segvCarsten Haitzler (Rasterman)
2020-04-10evas: fix dereference after null checkShinwoo Kim
Summary: Static analysis tool reports passing a null pointer 'im->gc' to _evas_gl_image_cache_add which directly dereferences it, so lets be sure that 'im->gc' is valid before passing it to cache_add Reviewers: Hermet, jsuya, herb, zmike Reviewed By: zmike Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11676
2020-04-10efreetd - ensure on bsd where connects succed despite daemon being goneCarsten Haitzler (Rasterman)
just get it to work... getting unamused with this.
2020-04-09efreet - try less chaotic efreetd restart and delay 0.5-1.0 rand secCarsten Haitzler (Rasterman)
try work on T8490
2020-04-09tests: popupAlastair Poole
I missed this warning on this machine apologies for the unnecessary noise.
2020-04-09tests: Add case to match ephoto behaviour.Alastair Poole
2020-04-08elm_dnd: null check for safetyYeongjong Lee
Also, it needs to keep backward compatibility. Reviewed-by: Christopher Michael <devilhorns@comcast.net> Differential Revision: https://phab.enlightenment.org/D11666
2020-04-08release: Update NEWS and bump version for 1.24.0-beta1 releasev1.24.0-beta1Stefan Schmidt
2020-04-07elm_entry, accessibility: Send utf8 text instead of markup to ATSPI clientShilpa Singh
Summary: Markup text cannot be read as per expectation by a text to speech engine, hence send text in UTF8 format Test Plan: Test the text returned by connecting to object:text-changed:insert and object:text-changed:delete events in ATSPI-clients Reviewers: kimcinoo Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11660
2020-04-07efl_ui_dnd: cleanup when backend failed to create dnd opMarcel Hollerbach
this is needed to not have a dead window on the screen. Differential Revision: https://phab.enlightenment.org/D11654
2020-04-07ecore_evas_cocoa: be aware of NULL dataMarcel Hollerbach
this will now result in the promise beeing rejected. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11653
2020-04-07meson: do no build upower on macosMarcel Hollerbach
this is just causing errors and nothing usefull, upower is not available on macos. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11652
2020-04-07meson: build modules on macos as .soMarcel Hollerbach
this is needed in order to support ecore-evas loading of .so modules Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11651
2020-04-07meson: support unified suffixes for modulesMarcel Hollerbach
A long story in a few words: sometimes on macos modules will be compiled into .dylib, sometimes, into .so suffix. We did not set the suffix everywhere in our meson build instructions, hence our suffixes have been differently, which resulted in random load fails on different maschines. With this commit, we ensure that we suffix all modules the same way. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11650
2020-04-07ci: force system zlib on osxMike Blumenkrantz
osx doesn't ship a pkgconfig file for its own zlib, so now we're shipping a pkgconfig file for their zlib to avoid future issues Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11661
2020-04-07evas: prepare for cur beeing NULLMarcel Hollerbach
debug name could be called during any time, even before the constructor, of this super class is hit. So cur can be NULL here. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11659
2020-04-07eo: only prepare a empty nodeMarcel Hollerbach
Summary: do not take over complete vtables. This might fix wrong vtable settings when a type is not in the inheritance of another type, but the function is implemented. Reviewers: woohyun Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11657
2020-04-06elm icon/image efl ui image - respect aspect hints at all if setCarsten Haitzler (Rasterman)
these did not even look at aspect hints when calculating sizing. that means any attempt to set them would lead to... nothing useful. this handles horiz/vert/both cases (as best as is possible). @fix This reverts previous commit and fixes it in the box layout to respect aspect in elm boxes. note - this probably needs doing in other containers too like table... Revert "elm icon/image efl ui image - respect aspect hints at all if set"
2020-04-06elm icon/image efl ui image - respect aspect hints at all if setCarsten Haitzler (Rasterman)
these did not even look at aspect hints when calculating sizing. that means any attempt to set them would lead to... nothing useful. this handles horiz/vert/both cases (as best as is possible). @fix
2020-04-06efl.ui.textbox: add test case for copy/paste resultsAli
since paste is now working when called from user source code, this test case can be added Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11625
2020-04-06ui textpath: removed unused var.Hermet Park
2020-04-06ui textpath: update map before rendering begins.Hermet Park
previously, textpath delays the map calculation to avoid duplicated jobs. some cases, this job could be delayed to the next frame that occured a wrong frame result. This render_pre event gurantees the textpath to update frames exactly. @fix
2020-04-06build: add version to exactness libsMarcel Hollerbach
this patch was submitted through the bugtracker by Andrew Brouwers. Thank you! fixes T8644
2020-04-06emile: fix a potentional resource leaking.Wonki Kim
'ctx' can be leaked in some case. this pathc fixes it. Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11368
2020-04-06ecore_evas: fix leaks in macos and win32Marcel Hollerbach
memory is duplicated in eina_content_new. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11641
2020-04-03tests/hover: add behavior tests for elm_hoverMike Blumenkrantz
verify geometry and smart callback triggering Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11632
2020-04-03tests/layout: add explicit test for freeze and thaw no-op correctnessMike Blumenkrantz
this shouldn't trigger any canvas changes since nothing is happening during the freeze Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11631
2020-04-03tests/elm: add wrapper for forcing manual render in testsMike Blumenkrantz
this can be useful when a test needs to immediately verify whether a render is occurring Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11630
2020-04-03tests/elm: add helper macros for asserting size and position of objectsMike Blumenkrantz
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11629
2020-04-03efl_ui/layout: correctly batch object changed state when using freeze/thawMike Blumenkrantz
previously this would always queue a recalc when calling thaw even if the object hadn't changed also mimic edje internal behavior with unsetting 'frozen' during force calc for possible future handling even though it has no effect presently Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11628
2020-04-03eo: use eina_prefetchMarcel Hollerbach
we should prefetch the func pointer here. Later on we are accessing the func pointer in a streak, after that, we do not use it anymore. Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11593
2020-04-03Replace strncmp codeMarcel Hollerbach
the structure "!strcmp(X, "foo", strlen("foo"))" is equal to "eina_has_prefix(X, "foo")", and the later is nicer to read, hence this replaces it. Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11620
2020-04-03evas/text: remove paragraph_direction inherit during renderMike Blumenkrantz
this is unnecessary: * for the text object itself, the value is correctly set whenever the paragraph_direction property is changed * for inheritance, smart object already implements propagation which triggers on member add or property change Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11549