summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-12-20efl_ui_progressbar: remove pulse_modedevs/bu5hm4n/work_progressbarMarcel Hollerbach
pulse_mode is now implicit with pulse, if you set the progressbar to pulse, the state is internally adjusted in a way that the theme is put into the correct state. Legacy is not impacted by this because of the previous commit. ref T8501
2019-12-20elm_progressbar: make pulse and pulse_mode independend from legacyMarcel Hollerbach
the next commit will refactor this API for Efl.Ui namespace. ref T8501
2019-12-19scroller: add missing efl_content_unsetHosang Kim
When efl_content_unset(scroller) is called, efl_content_unset for Efl.Ui.Pan class should be called also. Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10906
2019-12-19efl: add @since tags for stabilized classesYeongjong Lee
Summary: Add missing @since tags. Test Plan: meson build Reviewers: bu5hm4n, cedric, segfaultxavi Reviewed By: segfaultxavi Subscribers: q66, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10917
2019-12-19ector software: catch up losing tasks among the threads.Hermet Park
Summary: ector sw uses thread pool internally to process rle job parallel. First of all, we lost task handles which allocated to each threads, we must free the task data after thread done. Secondly, tasks can be managed by one shape instance, the instance can't catch upon multiple instances alive. only last task can be attached to the shape instance. Thus, obvisouly the instance doesn't expect to handle multiple tasks at the same time, one instance only take care of one task on threading pool. Reviewers: jsuya, cedric, smohanty, kimcinoo Reviewed By: jsuya Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10916
2019-12-19csharp: remove unused code in workaroundYeongjong Lee
Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true Reviewers: lauromoura, Jaehyun_Cho Reviewed By: Jaehyun_Cho Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10914
2019-12-19eolina_mono: prevent empty ExtensionMethods classYeongjong Lee
Test Plan: Check the code below is removed from `efl_ui_box_stack.eo.cs`. ``` #if EFL_BETA #pragma warning disable CS1591 public static class CoreUI_UIBoxStack_ExtensionMethods { } #pragma warning restore CS1591 #endif ``` Reviewers: lauromoura, Jaehyun_Cho Reviewed By: Jaehyun_Cho Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10905
2019-12-18efl_ui_format: make this usable with the standard behaviour of accessorsMarcel Hollerbach
a accessor is never delivering a value, only the pointer to a value. This makes format working with accessors for list array carray. Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10909
2019-12-18eina_accessor: make carray accessor work properlyMarcel Hollerbach
a accessor is not really helpfull if it operates like the carray accessor before this commit. What it was doing is to fill the content of the "current line" into the data pointer. In a carray the "current line" is the content of its carray-member. However, accessors like for inarray array list or inlist do work completly differently. They are returning the pointer to the "current line" not the value of the current line. The only case where this worked is efl_ui_format.c which was only tested with this accessor, and this accessor also only worked with this accessor. Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10908
2019-12-18efl: make sure all index for Efl_Model are unsigned int.Cedric BAIL
T8469 Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com> Differential Revision: https://phab.enlightenment.org/D10869
2019-12-18tests/ecore_wl2: Fix memory leakChris Michael
Coverity reports that we leak 'ret_rots' here because ecore_wl2_window_available_rotations_get allocates space for the return, so we should free this here. Fixes CID1408025
2019-12-18docs: Formatting issues in Efl.Text.Attribute.FactoryXavi Artigas
2019-12-18docs: Fix typos and whitespace in Efl.Text_CursorXavi Artigas
2019-12-18docs: Polish Efl.Text_Interactive docsXavi Artigas
Ref T8521 Ref D10711
2019-12-18elm_test: small whitespace issueXavi Artigas
2019-12-18csharp: Fix passing acessor with ownershipLauro Moura
Summary: When passing an owned acessor from a converted collection we need a way to unpin the passed data when the accessor is freed. This commits adds a thin wrapper around the CArray accessor that unpins the data when freed. Depends on D10900 Reviewers: YOhoho, felipealmeida Reviewed By: YOhoho Subscribers: cedric, #reviewers, #committers, jptiz, brunobelo Tags: #efl Maniphest Tasks: T8486 Differential Revision: https://phab.enlightenment.org/D10901
2019-12-18csharp: Fix accessor IEnumerable implementation.Lauro Moura
Summary: Fixed after `data_get` marshalling changed (correctly) the data parameter to `out IntPtr` instead of manually marshalling the double pointer. The existing test (`basic_accessor_list`) passed due to the empty enumerable behavior, which made the `foreach` running no iterations. Reviewers: brunobelo, jptiz, felipealmeida, YOhoho Reviewed By: jptiz, YOhoho Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10900
2019-12-18evas vg: fix memory leak.Hermet Park
2019-12-18ci: refactor the early exit on specific build jobsStefan Schmidt
Should be no functional change only making all early checks a bit shorter. Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com> Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10866
2019-12-18ci: refactor configuration scriptStefan Schmidt
Re-factor if-else block for easier reading, update comments and check that we are on osx when executing that part. Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com> Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10865
2019-12-18ci: travis: merge two if clausesStefan Schmidt
A left-over from the various works in this file. All of these commands are under the same conditions. Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com> Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10864
2019-12-18ci: enable benchmark target againStefan Schmidt
It only runs after efl is installed and we need to ensure running with Elm buffer engine in our docker build for the graphical collection benchmark. Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com> Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10848
2019-12-18benchmarks: increase timeout value for running elementary benchmarksStefan Schmidt
Default is 30s and I run into timeouts all the time. Increasing it to 60s for the elementary benchmarks. On my local machine its around 45s for the slower one. Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com> Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10847
2019-12-17efl.text.format: rename methods and propertiesAli Alzyod
Summary: efl.text.format: rename methods and properties this change will avoid conflict in the future with other interfaces or class methods. T8533 Reviewers: woohyun, segfaultxavi, zmike, bu5hm4n Reviewed By: segfaultxavi Subscribers: cedric, #committers, #reviewers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10895
2019-12-17csharp : add move tag info to EinaAccessor, EinaIterator converterYeongjong Lee
Summary: Included commits in devs/lauromoura/remove_eina_mono-rebased ``` commit ed6679db1901c710cc6ddb50e7001cfd20caa77a Author: Lauro Moura <lauromoura@expertisesolutions.com.br> Date: Mon Dec 2 13:58:04 2019 -0300 csharp: add move information to EnumerableToAccessor Still need to fix the converted accessor ownership, maybe by creating a custom accessor class that released the pinned memory when is freed. ``` ref T8486 Depends On D10878 Co-authored-by: Lauro Moura <lauromoura@expertisesolutions.com.br> Test Plan: meson build -Dbindings=mono,cxx -Dmono-beta=true Reviewers: YOhoho Reviewed By: YOhoho Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8486 Differential Revision: https://phab.enlightenment.org/D10879
2019-12-17eina_mono: replace EinaAccessor and EinaIerator with IEnumerableYeongjong Lee
Summary: Eina.Accessor<T> => System.Collections.IEnumerable<T> Eina.Iterator<T> => System.Collections.IEnumerable<T> Unit test will work with D10879. ref T8486 Test Plan: meson build -Dbindings=mono,cxx -Dmono-beta=true Reviewers: lauromoura Reviewed By: lauromoura Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8486 Differential Revision: https://phab.enlightenment.org/D10878
2019-12-17examples: js: fix variable nameStefan Schmidt
Summary: Simple mispell in the example. Depends on D10882 Reported-By: https://lgtm.com/projects/g/Enlightenment/efl Reviewers: felipealmeida, lauromoura Reviewed By: felipealmeida Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10883
2019-12-17csharp: Suppressing non-events Raise methods.Bruno da Silva Belo
Summary: ref T8390 Reviewers: lauromoura, felipealmeida, YOhoho, jptiz Reviewed By: jptiz Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8390 Differential Revision: https://phab.enlightenment.org/D10717
2019-12-17csharp:Suppressing Warning and Add suffix collection.Bruno da Silva Belo
Summary: ref T8408 Reviewers: lauromoura, felipealmeida, YOhoho, jptiz Reviewed By: jptiz Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8408 Differential Revision: https://phab.enlightenment.org/D10669
2019-12-17docs: Add detailed text styling informationXavi Artigas
Summary: More detailed descriptions for each attribute. Relationship between attributes. Default values. Links to direct API methods for the corresponding property. General text overhaul and formatting. Test Plan: Builds and passes tests. Generate docgen or DocFX documentation and enjoy your new Text styling descriptions! Reviewers: ali.alzyod Reviewed By: ali.alzyod Subscribers: AbdullehGhujeh, cedric, #reviewers, #committers, woohyun, bu5hm4n Tags: #efl Differential Revision: https://phab.enlightenment.org/D10873
2019-12-17docs: Add missing docs for Efl.Canvas.Object_AnimationXavi Artigas
2019-12-17csharp: apply same form of "Since EFL" to all manual bindings .cs filesJaehyun Cho
The following form of "Since EFL" is applied to descriptions of all manual bindings .cs files. /// <para>Since EFL 1.XX.</para>
2019-12-17ecore_evas: add double header include safetyStefan Schmidt
Reported-By: https://lgtm.com/projects/g/Enlightenment/efl Reviewed-by: Chris Michael <cp.michael@samsung.com> Differential Revision: https://phab.enlightenment.org/D10887
2019-12-17evas mapping: fix memory leak.Hermet Park
These two dynamically allocated properties were not freed. free them when cow data is reset.
2019-12-16efl_canvas_textblock: allow style_apply with wrap=noneAli Alzyod
Summary: 1- passing style_apply("wrap=none") had no effect previously, and now disable wraping 2- style_all_get() by default return "wrap=word", but now return "wrap=none" refer to T8523 Reviewers: segfaultxavi, woohyun, cedric Reviewed By: segfaultxavi Subscribers: segfaultxavi, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10888
2019-12-16elm_test: workarounds for canvas_textblock styleXavi Artigas
The horizontally scrollable single-line text input box does not currently visible. This patch turns it into a vertically scrollable multiline input box, with an arbitrary minsize. Also, make the label unselectable.
2019-12-16elm_slider: remove unused fileWooHyun Jung
Summary: Just removed elm_slider_eo.legacy.h which did not have any dependency with other files Test Plan: 1. sudo ninja install 2. elementary_test 3. Slider Reviewers: segfaultxavi, bu5hm4n, zmike Reviewed By: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10876
2019-12-16ui position_manager: fix doc typo.Hermet Park
2019-12-16efl_ui : stablized factory classes.SangHyeon Jade Lee
Summary: for mvvm publizing, caching factory and layout factory need to be out of beta. Reviewers: cedric, bu5hm4n, segfaultxavi Reviewed By: cedric Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10855
2019-12-13edje_entry: real part protection checkali
Fix T8524 Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10875
2019-12-13efl_ui: docuement codeMarcel Hollerbach
there was the request that this needs to be documented, here we are. Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10874
2019-12-13efl_ui_widget: do not execute up handler when on destructionMarcel Hollerbach
otherwise we would cause an error. Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10846
2019-12-13evas_focus: protect against faulty focus objectMarcel Hollerbach
the problem is that we only remove ourselfs from the focused list in the invalidator. However, we allowed invalidated objects to be part of this hash, which made everything go boom. With this commit you at least only get one error and you should fix up this case. This fixes random errors in enlightenment (That are appearing theire since seats have been introduced to evas, the problem before invalidate was that the object was already destructor called, but not fully destructed yet). Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10845
2019-12-13efl_ui_spotlight_manager_*: do not keep ptr of dead pointerMarcel Hollerbach
when content is deleted, we should not keep a dangling pointer of it. Setting it to NULL here is enough, as later on a swtich_to reuest will be sent. Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10844
2019-12-13efl_datetime_manager: how did that ever work?Marcel Hollerbach
seriously, it sometimes might be worth at least *reading* what code does, this was initializating a private data struct on one single global boolean flag. How was that ever intended to work ? How could that ever slip through review ? This is not the only madness in these widget arround time and date, you cannot even select hours in 24h mode, you also cannot cannot select the 0 hour, which is kind of normal for the one or another region? the datetimemanager (which is IMO a complete misconcept) is full of FIXMEs and API calls that are defined and never called at all. Again what is this ? And how did that ever get into the codebase ?! With this commit the widget *finally* can be created more than once without exploding and erroring one. Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10843
2019-12-13efl_ui_spec_test: make this test workMarcel Hollerbach
I do not know what i was thinking when i initially wrote that test. It never worked, the test created a widget captured all elements, deleted the widget, then checked if there are elements left that are not knon on the canvas yet. Not the test first captures all elements, then creates the widget, then deletes the widget, and checks if there are more elements than expected. This found all the fix leaks prior to this leak. Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10842
2019-12-13efl_ui_collection: do not leakMarcel Hollerbach
this fixes leaking of membership to a pan object, additionally this also fixes the leaking of the pan object. This code was written with the thought that edje deletes its children, long story short: no it does not. While fixing the leak of the pan object, the error was found that the membership of the item to the pan object was leaked, which ended up in the item beeing deleted, even if its not part of the object anymore. Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10841
2019-12-13efl_ui_scroller: free pan object correctlyMarcel Hollerbach
we need to free the object in the invalidate, not in the destructor. Otherwise we might leak objects in bindings. Reviewed-by: Jaehyun Cho <jae_hyun.cho@samsung.com> Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10840
2019-12-13collection_view: free pan object correctlyMarcel Hollerbach
edje will not take over this part, edje will just reparent it to the ML and go on. Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10839
2019-12-13efl_ui_pan: stop leaking contentMarcel Hollerbach
pans implementation of Efl.Content is different to each other implementation, setting the content to NULL is not really deleting the obejct, since this is done at those widgets that are actaully using the pan. This is weird and fine in the same way, as the pan is only internal. However, when we are shutting down, we must free the content here. Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10838