AgeCommit message (Collapse)Author
2017-03-24Efl.Observable: Delay deletion of inner list not to break iterationdevs/conr2d/observerJeeyong Um
2017-03-23Efl.Observable: Extract method deleting observerJeeyong Um
2017-03-23Efl.Observable: Add key to the data of the list of observersJeeyong Um
2017-03-23Efl.Observable: Replace inner hash with listJeeyong Um
2017-03-23Efl.Observable: Delay creation of observers hashJeeyong Um
2017-03-22evas: Fix a rare issue with GL and map and maskJean-Philippe Andre
The things you learn to love... The situation was: - An object is mapped (naviframe in an animation) - One of its children has a mask - The window is rotated by 90 or 270 degrees (landscape) The mask glsl code to invert the x,y coordinate depends on the screen rotation and this somehow was wrong. Tested on Tizen and in elm_test "Masking", made with @jiin.moon. @fix
2017-03-21elm_code: fix keyboard selection forwardAndy Williams
2017-03-21elm_map: Fix work of elm_map_overlay_icon_set if icon is
Summary: Delete check on NULL for icon object due to incorrect work. Function must delete icon in map overlay (according to documentation) if we set NULL, but with this check - nothing happening and after elm_map_overlay_icon_get we have not NULL returned value. @fix Reviewers: cedric, Hermet, raster, jpeg Reviewed By: cedric Subscribers: artem.popov Differential Revision:
2017-03-21ecore: proper macro usage for double comparision. Summary: The comparisions ↵Umesh Tanwar
are done between doubles. EINA_FLT_EQ -> EINA_DBL_EQ Summary: Signed-off-by: Umesh Tanwar <> Reviewers: singh.amitesh, cedric Subscribers: jpeg, atulfokk Differential Revision: Signed-off-by: Cedric BAIL <>
2017-03-21ecore_evas_extn: do not update plug image when lockfile is invalid.Minkyoung Kim
Summary: This prevent invalid shared memory access. Invalid access occur when server is resized sequentially from now to A-size to B-size, and client receive A resize message after resizing B. Then client try to render plug image with A-size, but shared memory is B-size buffer. Size are mismatch. This makes segmentation fault when uploading texture(gl) or rendering image(sw). Test Plan: Indicator rendering on Tizen3.0 platform. Reviewers: jypark, wonsik, dkdk,, jiin.moon, jpeg, cedric Reviewed By: cedric Subscribers: cedric, jpeg Differential Revision: Signed-off-by: Cedric BAIL <>
2017-03-20genlist: Fix another issue with insert sortedJean-Philippe Andre
Fixes T5274 @fix
2017-03-20evas gl: Fix a compilation warningJean-Philippe Andre
The fallback lib handle is not required unless EGL/GLES is used.
2017-03-18eina_debug: do not leak a spinlock when the path is not givenMarcel Hollerbach
2017-03-17gl_drm: Fix KHR partial update supportDerek Foreman
I fixed this in other engines but missed this one. The result is some terrible flickering on gl_drm on recent mali drivers.
2017-03-17ecore_drm2: Move function call after the NULL checkDerek Foreman
Was dereferencing ob before NULL checking it. What could possibly go wrong?
2017-03-17gl_drm: Properly disable EGL_EXT_buffer_age when we don't have itDerek Foreman
If we don't have EGL_EXT_buffer_age then we don't have buffer age - it's a completely independent extension to KHR partial update. This partially fixes partial update on recent mali drivers.
2017-03-17theme: remove event gaps in enlightenment window framesMike Blumenkrantz
2017-03-17efreet: CRI and fail after 10 attempts to connect to efreetdMike Blumenkrantz
if efreetd cannot be connected to, stop infinitely trying to spawn it since this generates crazy cpu load probably this path should also send some cache events so that watchers do not simply idle forever ref T5200
2017-03-17ecore-evas: handle title_set and name_class_set for buffer engineMike Blumenkrantz
2017-03-17theme: make bryce vertical clipping work as expectedMike Blumenkrantz
ref a94351a789ae7c11efb72c1b9f35cd7fae4d7fa2
2017-03-17evas table: CRI when attempting to pack a table child into another tableMike Blumenkrantz
2017-03-17elm_code: Update and demo status messages inlineAndy Williams
2017-03-17elementary: enhance atspi accessible documentationShinwoo Kim
2017-03-17gengrid: avoid call select callback twice in mode ↵Vyacheslav Reutskiy
ELM_OBJECT_MULTI_SELECT_MODE_WITH_CONTROL If multi select mode is ELM_OBJECT_MULTI_SELECT_MODE_WITH_CONTROL and user code try unselect a item and select another part which not realized select callback calls twice in this case. For avoid this no needs focus newly selected item. @fix
2017-03-16luncher: improving engage animationsAndy Williams
2017-03-15eina_file: fixed T2244Ivan Furs
Summary: dirty fix for 'eet' problems with file deletion on WINDOWS to work with the commit: D4698, D4699 Reviewers: cedric, NikaWhite, rimmed, vtorri, raster Reviewed By: cedric Subscribers: artem.popov, cedric, jpeg Maniphest Tasks: T2244 Differential Revision: Signed-off-by: Cedric BAIL <>
2017-03-15evas: drop redundant pointer checkBryce Harrington
Summary: The function already has a precondition test for !font, so this additional test will never trigger. @fix CID1371525 Reviewers: cedric, jpeg Subscribers: jpeg, cedric Differential Revision: Signed-off-by: Cedric BAIL <>
2017-03-14elementary: Fix minor typo in efl_ui_win.eoChris Michael
Small patch to fix a minor typo in the "noblank" property of efl_ui_win.eo @fix Signed-off-by: Chris Michael <>
2017-03-14genlist: Fix a leakJean-Philippe Andre
Thanks @herdsman
2017-03-14ecore: Fix memory leak and logicJean-Philippe Andre
@cedric... how could this even happen??
2017-03-14release: Update NEWS and bump version for 1.19.0-beta3 releasev1.19.0-beta3Stefan Schmidt
2017-03-14ecore_animator: improve comparision check for stopping animator.Umesh Tanwar
Summary: Time cmparision does not ensure the corrctness of posotion. It is beacuse of double number calculation. Double number calculation are not convertable.for example: 1/39 = 0.02564102564; but 0.02564102564 * 39 = 0.99999999996 != 1; The addition check for pos ensure the pos to be reached at its correct position. @fix Signed-off-by: Umesh Tanwar <> Reviewers: cedric, singh.amitesh, jpeg, raster Reviewed By: raster Subscribers: atulfokk, cedric, jpeg Differential Revision: Signed-off-by: Amitesh Singh <>
2017-03-14evas gl: Add a hack for GLES 3.1 with NVIDIA + GLVNDJean-Philippe Andre
I believe there's a limitation in libglvnd where it doesn't propagate the calls to eglGetProcAddress() properly to the vendor library. See also 265c851a8f2ac3cd1f93d523736d4cce0454fe2c
2017-03-14evas: Fix crash with events on the canvasJean-Philippe Andre
Since ecore now uses efl events to feed input events to the canvas, anyone can now listen to any event on the evas. But when using the legacy API the event info needs to be the legacy struct, and not the eo event info otherwise crashes will happen. While this is a new use of events, I consider it valid and it's better to fix it rather than disallowing it. Fixed by wrapping evas events the same way evas object events were handled. Fixes T5266
2017-03-14evas gl: Fix usage of OSMesaJean-Philippe Andre
It seems OSMesa was recently updated to not expose symbols statically, so dlsym() returns invariably NULL. GetProcAddress must be used. Note though that the extension "EGL_KHR_get_all_proc_addresses" is not present (OSMesa is OpenGL, not GLES), and there is anyway no list of extensions in OSMesa (at the WSI level, glGetString() returns a ton of GL extensions as expected). My OSMesa version is 11.2.0 (mesa 17.0.1). This fixes make check. @fix
2017-03-14edje: Move prev_description out of ephysics ifdefJean-Philippe Andre
prev_description was used when HAVE_EPHYSICS is set, which is the default, but I also added a use in 7072fbc2bfe25881 where the map was not properly reset. This removes an ugly #ifdef and opens the door to other fixes similar to that map one.
2017-03-14genlist: Fix some more decorate mode issuesJean-Philippe Andre
The item, after having been unswallowed from its decorate item, becomes unclipped and unparented. The parent was well reset, but the clip wasn't. Test case: elementary_test -to "Genlist Decorate Item Mode" I'm sure some bugs are still lurking. Genlist is so lovely. Fixes T1551
2017-03-14edje: Fix rare issue with mapJean-Philippe Andre
In the following sequence, the swallowed object map property is never reset as it should have been: - swallow object - start program, change state to have a map - do something - start program, change state to have no map but before render, unswallow the object At this point, the object will never be un-mapped. This is weird. Somehow edje_calc avoids calling evas_object_map_[enable_]_set excessively, but I believe the issue is that the object does not need recalc. Its container needed recalc, not the child (which is mapped). I'm not 100% sure. Test case: elementary_test -to "Genlist Decorate Item Mode" Click on rotate, select a few items, scroll up and down. Enjoy. Ref T1551 @fix
2017-03-14genlist: Make sure only one item is decoratedJean-Philippe Andre
In "Genlist Decorate Item Mode" after decorating a few items (rotate or slide, doesn't matter), only one item or none should be decorated. Scrolling up and down the genlist should work just fine. This fixes massive render issues and inconsistent states of the items in this test case. "rotate" mode is still going nuts. Ref T1551
2017-03-14genlist: Make logic more readableJean-Philippe Andre
2017-03-14genlist: Fix invalid call to stack above/belowJean-Philippe Andre
Test process: elementary_test -to "Genlist Decorate Item Mode" Slide any item to the right, observe error logs. Ref T1551
2017-03-14evas: Add more debug info to an ERR message (stack)Jean-Philippe Andre
Also use eina_safety as those are safety checks. Helps with GDB (single breakpoint in eina_safety).
2017-03-13Revert "ecore-evas reduce modifier modification on every event to cut cpu"Cedric BAIL
This reverts commit 3a9d54085b8751cbd0bca4698a8ff702d9bdc7b4. I got crash and a lot of valgrind warning with this patch. All in all, I think we can just wait for next release and do a proper cleanup of our API to not rely on strings at all. For references this is the first valgrind warning I get (Not going to past the 100 following one) : ==11860== Invalid write of size 4 ==11860== at 0xB10DDD1: _ecore_event_evas_modifier_lock_update (ecore_input_evas.c:432) ==11860== by 0xB10E3DD: ecore_event_evas_mouse_move (ecore_input_evas.c:725) ==11860== by 0x5D5115D: _ecore_call_handler_cb (ecore_private.h:317) ==11860== by 0x5D5115D: _ecore_event_call (ecore_events.c:518) ==11860== by 0x5D5CC47: _ecore_main_loop_iterate_internal (ecore_main.c:2381) ==11860== by 0x5D5D42E: ecore_main_loop_begin (ecore_main.c:1289) ==11860== by 0x5D5D490: _efl_loop_begin (ecore_main.c:2831) ==11860== by 0x5D59555: efl_loop_begin (efl_loop.eo.c:32) ==11860== by 0x14F275: main (test.c:1188) ==11860== Address 0x19a36828 is 7 bytes after a block of size 1 alloc'd ==11860== at 0x4C2AACE: malloc (in /usr/lib/valgrind/ ==11860== by 0x4C2CC81: realloc (in /usr/lib/valgrind/ ==11860== by 0xB10DDA8: _ecore_event_evas_modifier_lock_update (ecore_input_evas.c:425) ==11860== by 0xB10E3DD: ecore_event_evas_mouse_move (ecore_input_evas.c:725) ==11860== by 0x5D5115D: _ecore_call_handler_cb (ecore_private.h:317) ==11860== by 0x5D5115D: _ecore_event_call (ecore_events.c:518) ==11860== by 0x5D5CC47: _ecore_main_loop_iterate_internal (ecore_main.c:2381) ==11860== by 0x5D5D42E: ecore_main_loop_begin (ecore_main.c:1289) ==11860== by 0x5D5D490: _efl_loop_begin (ecore_main.c:2831) ==11860== by 0x5D59555: efl_loop_begin (efl_loop.eo.c:32) ==11860== by 0x14F275: main (test.c:1188)
2017-03-13eina: Fix more typo in doxygenChris Michael
The eina_(rw)_slice_startswith functions both incorrectly describe how the 'prefix' parameter is used, so fix those also @fix Signed-off-by: Chris Michael <>
2017-03-13eina: Fix typo in doxygenChris Michael
eina_(rw)_slice_startswith functions both incorrectly describe the return value as 'slice ends with', when clearly the function is used to find if a slice 'starts with' a prefix @fix Signed-off-by: Chris Michael <>
2017-03-13ecore-evas reduce modifier modification on every event to cut cpuCarsten Haitzler (Rasterman)
this only modifiers modifiers if the modifier mask changed. it stores it per seat and matches up before deciding to actually modifier the modifiers. this SHOULD fix T5252 @fix
2017-03-12elementary: refactor code to avoid duplication in elm_code_widget.Cedric Bail
2017-03-12ecore_evas: keep VNC API BETA until multi evas output is in, just in case.Cedric Bail
2017-03-12elm_code: Don't leak rows when we resize downAndy Williams
Thanks Cedric :) @fix
2017-03-11elementary: force elm_code line fill on object resize.Cedric Bail
This fix elementary_test use of elm_code where the object needed to get clicked to have their content displayed. The reason was that the line where appended while the object size was 0 and once it was resized the line where not displayed.