summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-03-26fix pathdevs/stefan/circleciStefan Schmidt
2020-03-26bump to trigger ciStefan Schmidt
2020-03-26testing only, revertStefan Schmidt
2020-03-26ci: circle: initial config file to test out setupStefan Schmidt
2020-03-26evas_textblock: prevent updating cursor unless they are ready during markup_setAli
Summary: During Markup_set at text block level, we will not update the cursors, unless their status is updated and ready. This can cause serious issues, especially if a cursor also depends on another cursor for some calculations, (like the segfault happening in TextBox T8637) Reviewers: woohyun, bu5hm4n, zmike Reviewed By: woohyun Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8637 Differential Revision: https://phab.enlightenment.org/D11598
2020-03-25efl_ui_spin_button: add tests for direct input featureMarcel Hollerbach
this simply passes in some key sequences and checks if the validation is working. Additionally the output value is checked. Depends on D11009 Differential Revision: https://phab.enlightenment.org/D11010
2020-03-25suite_helpers: add helper for key down eventsMarcel Hollerbach
usefull for emulating key events.
2020-03-25suite_helper: do not use stacked values hereMarcel Hollerbach
this is ending up beeing garbage pointers when not properly overwritten. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11597
2020-03-25evas_textblock_tests: do not free a text cursor hereMarcel Hollerbach
the cur_obj would have been always dead at this point, as the textblock was freed. This now moved the textcursor object to a previous point. However, we could also remove the explicit cursor deletion... Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11596
2020-03-25efl_check: unset the callback hereMarcel Hollerbach
this is needed in order to not accidently overwrite stack values. This never showed up while running the test suite, as erroring would have aborted anyways. However, when we are running with CK_FORK=no, this may leak into another test. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11595
2020-03-25evas: free font lists correctlyMarcel Hollerbach
sometimes a canvas object is zombying, and does not get freed correctly. If this is right now happening in our test suite, we are going to free the list, but do not clean up the pointer in there. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11594
2020-03-25edje/multisense: track and destroy multisense inputs on shutdownMike Blumenkrantz
leaking these means leaking file references, and there's no reason for it Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11533
2020-03-25edje/multisense: free multisense output on shutdownMike Blumenkrantz
this comment has now been addressed Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11532
2020-03-25ecore/audio: rewrite pulseaudio output to not use global variablesMike Blumenkrantz
this breaks down immediately when calling init/shutdown in quick succession due to the async nature of pulseaudio. we have object-based private data, so we can just use that instead Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11531
2020-03-25ecore/audio: correctly handle sndfile error when setting new vioMike Blumenkrantz
need to immediately call the free here to avoid leaking the callback data Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11530
2020-03-25ecore/audio: remove duplicated vio code from sndfile inputMike Blumenkrantz
this is already done in the base implementation Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11529
2020-03-25ecore/audio: add a couple more functions to the pulse callback structMike Blumenkrantz
to be used later Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11528
2020-03-25ecore/audio: free vio on in/out object destructionMike Blumenkrantz
ensure we don't leak these since that means we also leak the user's free data and callback Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11527
2020-03-25ecore/audio: add ERR messages when trying to overwrite existing vioMike Blumenkrantz
this probably causes a crash or a leak at some point Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11526
2020-03-25exactness: handbuild a new argv array instead of reassemling the new oneMarcel Hollerbach
this commit removes the code that was changing argv values, and replaces it with a new array. Which is absolutly fine, as the argv / argc values are never accessed later on. Only the copies that have been passed to efl_main or elm_main. This resolves several issues: 1. the for loop is useless, every single array element that gets initialized with it, is some offset from argv[0] this may also crash when argv[i] - argv[opt_args] is bigger strlen argv[0]. 2. The memcpy here is super dangerous, the dest array is not garanteed to have the same size as argv[0], this only works if the client application name is shorter than the name "exactness_recorder" 3. The memset here is absolutly wrong. There is again no garantee that the array has the expected size behind that, this was constantly overwriting the segment after the place where argv was stored, which was lukely enough on fedora always the environs, which deleted the couple first segments. (This was not causing any fuzz, since they have been sudo related env vars on the docker image). However, on arch this just crashed right away. On Ubuntu this overwrote DISPLAY, which resulted in the unability to launch the app. Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11600
2020-03-25emotion - webcam - fix segv on webcam plug/unplug and cleanCarsten Haitzler (Rasterman)
well hunting was fun... custom webcams i just cant see being used. no api to add them - have to hand craft a config file .. and udev/eeze provide info on webcam devices anyway at runtime with plug/unplug etc. ... so this should be the only ay (for now) and it keesp the code simpler and less bug-prone now issue was some nasty skipping unref as opposed to destroy. in chasing i simplified the code to help me narrow it down and not chase the same logic in multiple places. shorter cleaere, simpler and minux one bug. @fix
2020-03-25evas/render: minor cleanups for norender functionsMike Blumenkrantz
Summary: evas_norender cannot produce update regions, so there's nothing to free remove commented lines no functional changes Reviewers: bu5hm4n Reviewed By: bu5hm4n Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11584
2020-03-25ecore_cocoa: remove left over from evas3d removalStefan Schmidt
These directories do not exist any longer. Failing build on CI.
2020-03-25canvas 3d: remove all canvas3d features across efl.Hermet Park
Reviewers: jsuya, kimcinoo, bu5hm4n, raster Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11552
2020-03-25efl_ui_image: keep efl_ui_image size for internal imageShinwoo Kim
Summary: The size of internal image could be bigger than the size of efl_ui_image with following code. image = elm_image_add elm_image_fill_outside_set(image, EINA_TRUE); If the internal image object is 300x300, and efl_ui_image is 360x77, then the internal image object will resize to 360x360 which is bigger than the size of efl_ui_image. This is a compatibility issue. This patch will make efl_ui_image work as before commit 8cb6c3e Elm_image: implement 'scale_type' and 'scalable'... Test Plan: This is old example to reproduce the problem. {F3859361} This is newly added example to check if this patch breaks compatibility or not. {F3859390} You can use the example with following image. {F3859391} This is result before applying this patch. {F3859388} This is result after applying this patch. {F3859389} The translucent rectangle is the size of the efl_ui_image. As you might be noticed, only FIT_WIDTH (the 4th one of each row), and EXPAND (the 6th one of each row) are different. One more difference the 1st one of 2nd row; NONE. F.Y.I. and for quick understanding of example. The 1st row efl_ui_image is bigger than internal image. The 2nd row efl_ui_image is smaller than internal image. From the left the scale type is NONE, FILL, FIT, FIT_WIDTH, FIT_HEIGHT, EXPAND, and TILE. Reviewers: Hermet, jsuya, herb Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11587
2020-03-24efl/mailmap: Move unused addresses to the bottom of listChristopher Michael
2020-03-24Revert "efl/mailmap: Remove old unused addresses"Christopher Michael
Revert these in favor of reorder so we can keep history This reverts commit 94a80803558a682e78b53e190b23c32b54200c65.
2020-03-24efl/mailmap: Remove old unused addressesChristopher Michael
2020-03-24eo: free vtable when erroring outMarcel Hollerbach
if there is a error when settings API to the vtable, free the vtable instead of leaking it. CID 1422015 Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11580
2020-03-24eo: do not check this hereMarcel Hollerbach
as coverity points out, _obj_is_override is already dereferencing obj->opt so this was the wrong spot to check this. CID 1422014 CID 1422013 Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11579
2020-03-24eo: fix wrong formattingMarcel Hollerbach
no functional changes. Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es> Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11578
2020-03-24eo: only really copy when there is contentMarcel Hollerbach
otherwise we are allocating a 0 sized memory element, which is pointless. ASAN would report a 0 sized allocated but not freed element as a leak. Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11577
2020-03-24eo: correctly flag allocated memoryMarcel Hollerbach
sometimes there is the chance that we need to allocate memory depending on the functions that are defined, not on the types that are available. However, even if this should only happen in error cases and on mixins, we should ensure that this is all correctly freed flagged. Due to the correct flagging here, we are not copying the memory later on in a wrong way. Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11576
2020-03-24eo: do no allocate a 0 sized segmentMarcel Hollerbach
allocating 0 sized elements here is pointless. This here was doing that, so ensure that we are only allocating vtable nodes that have more than 0 function pointers. Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11575
2020-03-24eo: do not NULL out the object itselfMarcel Hollerbach
otherwise we would not free it in the next run over the vtable. Which would result in a leak. Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11574
2020-03-24eo: do not null out the vtable chain of your own classesMarcel Hollerbach
the free methods here accidently took the top of the mro into account, which is the class itself, which NULLed out the wrong classes. After this, we are finally freeing the mixin vtables. Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11573
2020-03-24edje_cc: free ecore_evasMarcel Hollerbach
we have initialized it, we should shutdown it. This was we are not getting random vtable allocation leak reports in the asan job anymore. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Reviewed-by: Chris Michael <cp.michael@samsung.com> Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11572
2020-03-24eo: do not allocate too much memoryMarcel Hollerbach
when handoverwriting function on a object, only existing API can be overwritten, but not newer ones. Thats why its enough to pass the size of the klass, and not the size of the globally defined classes. Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11571
2020-03-24tests/elm: add strict test to verify elm image gif supportMike Blumenkrantz
Summary: Depends on D11583 Reviewers: kimcinoo, Hermet, raster, cedric, bu5hm4n Reviewed By: bu5hm4n Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11484
2020-03-24tests/elm: use norender_with_updatesMike Blumenkrantz
Summary: Depends on D11582 Reviewers: bu5hm4n Reviewed By: bu5hm4n Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11583
2020-03-24evas: add function for norendering with updatesMike Blumenkrantz
Summary: the same as norender, but useful Depends on D11581 Reviewers: bu5hm4n Reviewed By: bu5hm4n Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11582
2020-03-24evas/render: produce update regions when do_draw isn't set but make_updates isMike Blumenkrantz
Summary: this is a valid combination of parameters that should be handled Reviewers: bu5hm4n Reviewed By: bu5hm4n Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11581
2020-03-24eo - fix err path for eo_isa to unlock shared objectsCarsten Haitzler (Rasterman)
fix CID 1363294
2020-03-24doxygen docs: Fix warnings in Ecore_Wl2.h and associatesXavi Artigas
2020-03-24doxygen docs: Fix warnings in Ecore_Evas.hXavi Artigas
And a couple associated places.
2020-03-24doxygen docs: Fix warnings in Edje_Edit.hXavi Artigas
And since we're at it, fix some typos too.
2020-03-24elm_transit: Prevent adding duplicatesJunsuChoi
Summary: When repeating call elm_transit_object_add, prevent the object from being added duplicates. Test Plan: N/A Reviewers: Hermet, herb, kimcinoo Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11563
2020-03-24elm_transit: replace evas_object_event_callback_xxx with efl_event_callback_xxxJunsuChoi
Summary: In transit, event_callback is mainly used for delete callback. transit uses evas_object_freeze_events_set to control the user's mouse events. However, EVAS_CALLBACK_DEL was not called because of this. The behavior of evas_object_freeze_event was changed. This patch was created to fix some issues. Test Plan: N/A Reviewers: Hermet, kimcinoo, herb Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11562
2020-03-24exactness: switch from homegrown debug printf to eina_logStefan Schmidt
Use a full eina_log domain here for each executable. No need to have a own half baked ex_printf version here for such things. Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11558
2020-03-24exactness: remove exactness library and move code into binary folderStefan Schmidt
We do not want to have EAPI from exactness exposed at this point without any real user. I know of no application using the exactness library. If we come to that point we can move things back into a lib, but for now having the code shared between the various executables is all we need. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11545