summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-07-31evas cache2 - remove excess file and key checks - only check fileCarsten Haitzler (Rasterman)
no need for key as no key is handled and no file is handled too. cleaner code. found by PVS studio
2017-07-31elm gesture layer - use fabs not abs when actually comparing floatsCarsten Haitzler (Rasterman)
2 abs uses should have been fabs as they compe a src float with anot her float. found by PVS studio @fix
2017-07-31eina debug - set length after freeing/iterating over the keysCarsten Haitzler (Rasterman)
found by PVS studio
2017-07-31elm calendar - fix gmtime call to use an actual valueCarsten Haitzler (Rasterman)
e85c92662bfec6a88bb7d2d091682daa429acba0 added this bug. before it was always set to 259200 (first sunday after epoch). found by PVS studio
2017-07-30ecore_drm2 - fix startup if edid blob is null.. assume all 0'sCarsten Haitzler (Rasterman)
this causes a crash when no edid is available. survive and dont crash. this causes e wayland to not work at all on my baytrail laptop. @fix
2017-07-30eldbus lower error print levesl from ER to WRN in get all propsCarsten Haitzler (Rasterman)
this is generally unnecessary noise as the majority of the time i see this it's because the message was canceled by the caller... thats not an error though then... it's intended. less debug noise to sift through.
2017-07-29ecore_evas_drm: Only check for gpu time offset if env var setDerek Foreman
Since most systems shouldn't need this, and it's possible that it's causing trouble for some systems, make it off by default. Fix T5806
2017-07-29tests - make ecore con test suite reliable and workCarsten Haitzler (Rasterman)
basically ecore_con's test suite was broken. ipv6 checks were broken. you now need to set an env var to get ipv6 tested. using eocre_con to detetc it didnt init eina or ecore_con and if you do init these then the other tests that check return values from these fail... so make it an env var if you want to test ipv6. now it's reliable and works!
2017-07-29ector software - fix min/max int range for fixedpoint mathCarsten Haitzler (Rasterman)
min value bitshifts are negative and thus not portable. just tax max (as its 1 more than min it if we do -max) as the limit as its within range. this should fix it @fix found by PVS studio
2017-07-29evas render - remove obj null check in proxy clip as obj not nullCarsten Haitzler (Rasterman)
obj is never null. so this check is pointless. not a bug though. found by PVS studio
2017-07-29evas object textblock - fix append if cur node is nullCarsten Haitzler (Rasterman)
then it will appeand totally as it should be. small buglet found. fixed found by PVS studio @fix
2017-07-29evas gl gnenric engine - dont check w and h ptrs - will never be nullCarsten Haitzler (Rasterman)
analyser unhappiness. found by PVS studio
2017-07-29embryo_cc - remove pointless test for null byte and spaceCarsten Haitzler (Rasterman)
space wins. the nul byte test is pointless. not a bug but pointless code found by PVS studio
2017-07-29ecore-x - remove useless extra assignments of value to itselfCarsten Haitzler (Rasterman)
usless code that does nothing - not a bug though found by PVS studio
2017-07-29edje_cc - remove pointless free of null ptrCarsten Haitzler (Rasterman)
not a bug but not useful code either freeing what is already null found by PVS studio
2017-07-29efl ui text - remove useless else + freeCarsten Haitzler (Rasterman)
string is null so no need to free. not a bug but cleaner and analysers dont like it. found by PVS studio
2017-07-29edje entry - remove extra else and free as sdtring is null thereCarsten Haitzler (Rasterman)
string is null so no need to free. not a bug but cleaner and analysers dont like it. found by PVS studio
2017-07-29eina simple xml parser - remove pointless memcmp of 0 bytesCarsten Haitzler (Rasterman)
no point - all we are doing is having a final fallback of any tag that starts with ! that isnt a special one like !DOCTYPE, !-- comment and ![CDATA stuff... analysers dont like these pointless calls. found by PVS studio
2017-07-29els box - remove rudundant double checkCarsten Haitzler (Rasterman)
not a bug but checking something twice in a row isn't too useful found by PVS studio
2017-07-29elm code - remove unneded extra check from copy and pasta it seemsCarsten Haitzler (Rasterman)
extra check already done in if above - no need. looks like copy & paste of the checks from above thus why it's there, but not needed. not a bug, byt analysers dont like it so remove found by PVS studio
2017-07-29emotion gst1 module - remove extra unneded if'sCarsten Haitzler (Rasterman)
not a bug, but don't need these found by PVS studio
2017-07-29eeze_disk - remove redundant if check already doneCarsten Haitzler (Rasterman)
removes redundant fi check. not a bug but analysers dont like it and it is redundant found by PVS studio
2017-07-29efl net - fix ipv6 getsockname to use the proper struct to do itCarsten Haitzler (Rasterman)
struct sockaddr_storage *addr; AS the actual storage ( a ptr to store the whole data). kind of... wrong. it should be: struct sockaddr_storage addr; see examples of this kind of usage of getsockname: http://www.masterraghu.com/subjects/np/introduction/unix_network_programming_v1.3/ch04lev1sec10.html found by PVS studio @fix
2017-07-29eeze disk - remove uneeded extra check for test varCarsten Haitzler (Rasterman)
test for non null already done above, so test must obviously be null here so no need to check. analysers dont like this but it's not a bug. make them happy thought found by PVS studio
2017-07-29evas psd loader - remove unneeded extra check in ifCarsten Haitzler (Rasterman)
one if condition is always true by virtual of previous if statements and drop-through so can remove. not actually any bug but analysers don't like it found by PVS studio
2017-07-29eina debug - if calloc for session struct failed - return NULLCarsten Haitzler (Rasterman)
makes analysers happy but really doesnt change anything - moves the abort/crash/exit somewhere else. found by PVS studio
2017-07-29edje_cc - make list free simpler to make analysers happyCarsten Haitzler (Rasterman)
analysers like PVS studio dont know the eina_list_free returning NULL design pattern for consistency and so dislike the var being set twice in a row. this will make them happy without any skin off our backs. not a bug at all. found by PVS studio
2017-07-29evas git loader - move findo reset inside else as only that changes itCarsten Haitzler (Rasterman)
only the else changes finfo so reset inside there. not really any bug at all byt style-wise a bit better and analysers don't like it found by PVS studio
2017-07-29elm list - remove harmless extra null set to keep analysers happyCarsten Haitzler (Rasterman)
this was totally harmless and not an actual bug but it keeps analysers happy. found by PVS studio
2017-07-29elm dayselector - remove double set of content varCarsten Haitzler (Rasterman)
this looks like a leftover from legacy to eo porting. it was harmless but analysis hates it found by PVS studio
2017-07-29elm code - remove double set of textlenCarsten Haitzler (Rasterman)
analysis doesnt like it, but not a bug found by PVS studio
2017-07-29edje edit - remove pointless setting attr_mount to 0Carsten Haitzler (Rasterman)
static analysers dont like it bug not a bug at all found by PVS studio
2017-07-29evas pmap loader - remove pointless extra assign of end of string to 0Carsten Haitzler (Rasterman)
not an actual bug - just analysis impacting found by PVS studio
2017-07-29eldbus parser - remove duplicate tag handler thats already handledCarsten Haitzler (Rasterman)
confusing and dead code as it's already handled. not an actual bug but analysis impacting found by PVS studio
2017-07-29evas events - remove set of list to null then back to value - confusingCarsten Haitzler (Rasterman)
eina_list_free always returns NULL. it's meant as a design pattern to follow like the append/prepend that ensures a freed list is NULL, but it can be confusing to analysers so remove the assing. not a bug actually. found by PVS studio
2017-07-29eina evlog debugging - when freeing debug buf with mmap 0 size afterCarsten Haitzler (Rasterman)
munmap would not munmap the memory with a size of 0... so zero the size after the munmap. found by PVS studio @fix
2017-07-29evas obj smart - remove pointless ifCarsten Haitzler (Rasterman)
s is already checked for null... so no need to check again found by PVS studio @fix
2017-07-29edje edit - when adding size class set max width and height to -1Carsten Haitzler (Rasterman)
since we're not using size class yet.. we hvent had to debug this... but it is a bug. fond by PVS studio @fix
2017-07-29efl net ssl constructor - remove double set of same varCarsten Haitzler (Rasterman)
all struct vars are set... one 2x. not a bug but pointless code in the src found by PVS studio
2017-07-29evas bmp loader - fix warnings about same type handled twiceCarsten Haitzler (Rasterman)
so a type we handle earlir inan if we re-handle as invalid later. this wouldnt lead to a crash or bugs as the if's would ned to be evaluated in order normally, but it's good to get it right. found by PVS studio
2017-07-29etc to rgba conversion - dont read stack garbage into the est imgsCarsten Haitzler (Rasterman)
surprising this wasn't caught when testing fallbacks. etc2 is used hyper-rarely but still... basically it'd skip pixels and read stack junk (which really would not crash but we'd have junk in image data). or should. found by PVS studio @fix
2017-07-29ephysics - fix stacking comparsion correctly if 1 smaller than 1Carsten Haitzler (Rasterman)
this fixes a pretty trivial comparison issue.. found by PVS studio @fix
2017-07-29evas legacy event mask - cast to unit64_t before bitshiftCarsten Haitzler (Rasterman)
this fixes a bit wraparound in the shift as the 1 is an int (32bit) type that then gets shifted .. then after that cast to 64bit. found by PVS studio @fix
2017-07-29eina inarray accessor - use right type in parameterCarsten Haitzler (Rasterman)
this actually wasn't a bug that would cause a crash. cloning an array access would fail as the magic check would find its an accessor not an array. indeed a bug... but we never used this anywhere i can find. this was cast to the correct func ptr callabck in the accessor struct as the clone method though.. thus everyhting was happy with it seemingly. found by PVS studio @fix
2017-07-28elput: Fix synthetic relative motion events based on abs eventsDerek Foreman
libinput won't actually give us this info, and logs an error instead. We can't synthesize based on pointer position due to pointer warping. So we must track abs reports and use previous abs reports to synthesize rel events.
2017-07-28ecore_evas_drm: Calculate gpu blank time offset once at startupDerek Foreman
So vmware's graphics driver reports the MONOTONIC drm cap, yet uses CLOCK_REALTIME instead. This leaves us with a gigantic offset between the gpu timestamp and the times ecore_time_get() gets from CLOCK_MONOTONIC. Since ticking screws directly with loop time this results in some long distance clock jumping. This commit fixes drm/gl_drm operation under vmware.
2017-07-28ecore_drm2: Add a fallback method for vblank waitingDerek Foreman
We can't depend on vblank waits being implemented by the driver, but we can count on page flips functioning, so add a fallback that does a page flip and waits for it.
2017-07-28ecore-wl2: implement support for aux hintsMike Blumenkrantz
this is a direct copy of a feature from tizen git with no modifications other than what was required for compilation and functionality https://review.tizen.org/git/?p=platform/upstream/efl.git;a=commitdiff_plain;h=01e72b7e3484ece4b589f95315990ba2c366c231 https://review.tizen.org/git/?p=platform/upstream/efl.git;a=commitdiff;h=670d84b579f248ae0e3df48e9953fe8128da9468 fix T5780 @feature
2017-07-28Revert "evas: Fix use of invalid EO object"Mike Blumenkrantz
This reverts commit 9b1e785f8ebba618016dd217aa18835b4fb675b7. this breaks devices with vt switching under drm
2017-07-28elput: fix seat cleanupMike Blumenkrantz
ensure seat deletion does not conflict with elput shutdown @fix