AgeCommit message (Collapse)Author
2017-08-04elm_test: Remove calls to visible_set for EO objectsJean-Philippe Andre
2017-08-04evas: Make all EO canvas objects visible by defaultJean-Philippe Andre
All legacy objects remain invisible by default. Any call to visible_set() will prevent the automatic show() to happen. show() will be done just before render time, which may be a bit too late in order to propagate the necessary changes. This may break some things where some objects are created internally using efl_add() instead of the legacy API, and the intent was not to show the object. @feature
2017-08-04efl src - mark fallthrough switch statements in 3rd party codeCarsten Haitzler (Rasterman)
in code we importend that doesnt use eina we have warnings of fallthroughs. all o them are commented to be fallthrough so add the attribute there too to have fewer warnings.
2017-08-04configure: switch to dev mode againStefan Schmidt
Merge window for 1.21 is now open.
2017-08-03release: Update NEWS and bump version for 1.20.0 releasev1.20.0Stefan Schmidt
2017-08-03ecore-wl2: Rename local function and make it staticChris Michael
As this function is not called from anywhere outside of ecore_wl2_window.c file, this can be declared static. NB: This patch also changes the function name to match the library (ecore_wl2). Signed-off-by: Chris Michael <>
2017-08-03efl: terrible kludge so avoid termination crash on osxJean Guyomarc'h
Currently, elementary programs crash on termination on macOS (seems Sierra-specific). This is very nasty, looks like deep memory corruption... Without valgrind (or like) support on Sierra, it is difficult to pinpoint the origin of the problem. Due to the imminient release, and after discussion with @stefan, this kludge will allow the release to happen. This commit MUST be reverted just after the release, so we don't blindfold ourselves! Ref T5245
2017-08-03eina debug - remove other swap and comment on the weirdness of thisCarsten Haitzler (Rasterman)
2017-08-02eina: failing to load a module is actually an ERR that user should see.Cedric BAIL
2017-08-02Eina_File: Avoid using munmap() on file->global_map.Guilherme Iscaro
When a virtualized file is created the file->global_map will not point to a mmapped region, thus it's not safe to use munmap() during the file cleanup. Only use munmap() if the file is backed by a FD. Fixes: T5234. Signed-off-by: Cedric BAIL <>
2017-08-02Efl_Copier: Add efl_wref_del() for pd->job.Guilherme Iscaro
In order to perform IO operations the copier will create futures using efl_future_use(&pd->job, ...), which will set pd->job to NULL once the future is destroyed. However this may lead to problems, because in some cases the copier may be deleted at the _efl_io_copier_job() function, which is the future's callback. Since the copier may be deleted before the future, the area pointed by pd->job will have disappeared by the time the future tries to set pd->job to NULL. To avoid this problem the copier must explicily call efl_wref_del(). Signed-off-by: Cedric BAIL <>
2017-08-02eina debug - new debug infra - comment out and make a note on bad endianCarsten Haitzler (Rasterman)
bad endian... code... see the comment in the src about why i think this is bad as obviously the buffer pointed to is a 64bit type always that is a pointer to something...
2017-08-02evas: Add safety code for smart objectjiin.moon
Summary: If user use the evas_object_smart_callback_add with no smart object, it should be returned @fix Test Plan: self Reviewers: jpeg, cedric, jypark Differential Revision:
2017-08-02evas filters: Disable extra debugJean-Philippe Andre
Forgot to remove that! It's better to disable for the release, DBG() and XDBG() are disabled anyway. CID 1308611
2017-08-02evas filters: Shut up coverityJean-Philippe Andre
Add some safety checks. CID 1374271
2017-08-02evas: Rename calculate property to calculatingJean-Philippe Andre
Recently introduced by @cedric I think the name is not very clear, and is clashing with the actual method of the same name.
2017-08-02epp - fix buffer size for possibly bigger int snpritnfsCarsten Haitzler (Rasterman)
8 bytes wasn't enough for the full int range. use 12 and we're good. removes warning for sure @fix
2017-08-02efl_wl - fix warning for possible uninitted list accessCarsten Haitzler (Rasterman)
could potentially be an issue in one theoretical case. less warnings is better anyway
2017-08-02evas model loader - restructure code to silence warningCarsten Haitzler (Rasterman)
keep our build quiet warnings-wise and change the code to be so... so we see real warnings. not a bug... just a warning.
2017-08-02elm_code: small optimisation for large filesAndy Williams
2017-08-02eina hamster count - use a fixed version, revision etc. so builds reproCarsten Haitzler (Rasterman)
this should help with repdocucable builds by having our hamsters constant for a build of a specific code revision. @fix
2017-08-02efl build - fix lua old support on debianCarsten Haitzler (Rasterman)
didnt detect cflags properly. now it does. @fix
2017-08-02ector - fix coveirty fix - vmin is -vmax not -vminCarsten Haitzler (Rasterman)
2017-08-02efl_ui_win: add error hanling code for malloc failJiyoun Park
2017-08-02ecore_x: Avoid crash on NULLJean-Philippe Andre
This happens in E with software compositing, since E's commit 5702f0975e890f07cfb. E should be fixed shortly but segv is not acceptable. Without segv E is still massively broken so it's not like the bug would be hidden (large black areas in windows, after switch vdesks with enough windows).
2017-08-01evas: add a way to know if we are already computing smart object calc.Cedric BAIL
2017-08-01Revert "evas: Always call show/hide intercept"Mike Blumenkrantz
This reverts commit 936ea58cb9ac3e93aaabb6ec731fc3845cf95826. this is an ideal change, but it breaks previously-expected behaviors for interceptors and thus enlightenment is completely broken
2017-08-01ecore_x: init XEvents before passing to xMarcel Hollerbach
it turns out that xlib is going to copy the complete struct into something internal. This might lead to the condition that a uninitalized value might be part of the struct, and when later the struct is read again the code might do wrong stuff since that value could be set now to a randomly other meaningfull value. This turned out on me in e as i could not write any letters like ßöäü, since that lead to a not returning call to _XReply internal of xlib. Dugging that showed that xlib was waiting on a reply of a call that never got executed, and the XEvent it is waiting on just contians a randomly correct value. @fix
2017-08-01edje_svg: Fix handling of reallocJean-Philippe Andre
This amends 8e311db414950e399099acc1c0a as the logic was badly broken. A "shadow" variable warning clearly showed that "tmp" was not used properly. This fixes the "IBM" logo in svg-test (the only one using polygon/polyline, it seems).
2017-08-01Revert "elm gesture layer - use fabs not abs when actually comparing floats"Jean-Philippe Andre
This reverts commit 2d4d836018387470b5df2c59119ab6cc81188e94. Don't pretend to fix an issue found by a static analyzer by introducing another issue that even clang warns about. Fixes: elm_gesture_layer.c:2533: warning: using floating point absolute value function 'fabs' when argument is of integer type [-Wabsolute-value] if ((fabs(st-> > ELM_GESTURE_MINIMUM_MOMENTUM) || ^
2017-08-01elementary: access overrides Accessible.state_set.getShinwoo Kim
The elm_access a widget makes primitive object accessible. If a primitive object is not visible, then the elm_access should NOT have state VISIBLE, and SHOWING. From now the elm_access is checking visibility of primitive object.
2017-08-01eldbus - make file local func added in fix staticCarsten Haitzler (Rasterman)
better to keep the func local unless needed elsewhere too
2017-08-01ecore_imf: check return value of memory allocationJihoon Kim
Signed-off-by: Jihoon Kim <>
2017-07-31ecore_drm2: Stop making dumb fbs and mmapping for gbm fdsDerek Foreman
We were doing this so E could do screenshots in a hackish way, E has been fixed so this hack here no longer needs to live.
2017-07-31ecore_drm2: Remove dead code in blank time getDerek Foreman
When I added the fallback block I left an if statement that could never evaluate to true. Remove it.
2017-07-31wayland-shm: Set CLOEXEC for dmabufDerek Foreman
Stop leaking the render node fd to child processes.
2017-07-31eldbus: check message serial before usingShinwoo Kim
Summary: Whatever the dbus_connection_send_with_reply returns, the serial value should be checked, because if the seral value is invalid a process could be aborted. There is backtrace as below. The dbus_connection_send_with_reply could return TRUE even though it has a problem. Please refer to following comment: /* Refuse to send fds on a connection that cannot handle them. Unfortunately we cannot return a proper error here, so the best we can do is return TRUE but leave *pending_return as NULL. */ Test Plan: There is not a exact reproduce step. If the Tizen login manager is relaunched repeatedly, then the dbus and other service processes are relaunched. If a service process tries to use dbus when the dbus has problem as above, then it could be possilbe to get above backtrace. Reviewers: raster, zehortigoza Subscribers: cedric, jpeg Differential Revision: @fix
2017-07-31 efl_ui_win: add EFL_UI_WIN_SOCKET_IMAGE type checkJiyoun Park
elm_win_socket_listen api only work for EFL_UI_WIN_SOCKET_IMAGE type window. So it is better to add type check code.
2017-07-31evas - handle devices that on deletion delete other devices on shutdownCarsten Haitzler (Rasterman)
this fixes a whole bunch of warnings that just recently turned up...
2017-07-31elocation - fix return of status, address, position to actually ret dataCarsten Haitzler (Rasterman)
the data was never returned! fix fix fix. found by PVS studio @fix
2017-07-31ecore x - convert to using unsed instead of dummy state,ents after retCarsten Haitzler (Rasterman)
found by PVS studio
2017-07-31elm code - handle alloc failure for line splitCarsten Haitzler (Rasterman)
this culd optentially use large offsets before accessing the ptr thus it may not segv inthe first page but actually work if positionoffsets are large enouh, so handle this case explicitly. @fix found by PVS studio
2017-07-31elm code - handle alloc failure for line splitCarsten Haitzler (Rasterman)
this culd optentially use large offsets before accessing the ptr thus it may not segv inthe first page but actually work if positionoffsets are large enouh, so handle this case explicitly. @fix found by PVS studio
2017-07-31evas mem - remove redundenty unused evas mem absractionCarsten Haitzler (Rasterman)
was never used as was not practical to do so so it effectively does nothing so remove it to reduce analyser warnings found by PVS studio
2017-07-31efreet icon cache creation binary - remove redundent checkCarsten Haitzler (Rasterman)
found by PVS studio
2017-07-31elm theme - remove redundent checkCarsten Haitzler (Rasterman)
found by PVS studio
2017-07-31elm config tool - fix redundent checkCarsten Haitzler (Rasterman)
found by PVS studio
2017-07-31evas textblock - remove redundant checkCarsten Haitzler (Rasterman)
found by PVS studio
2017-07-31epp - cpp - fix buffer end/null checks given static buffer pathsCarsten Haitzler (Rasterman)
this is an ncient bug that's never been triggered... but it's there. fix and compare to null buffer. found by PVS studio @fix
2017-07-31epp - remove redundent check for charCarsten Haitzler (Rasterman)
makes static analyisers happy... not a bug found by PVS studio