AgeCommit message (Collapse)Author
2017-03-02evas: Fix double clipping issue with mapjiin.moon
If object's parent has map and object also has map, the evas clip would be applied twice. The context already applied clip area when drawing on map_surface. So don't need more clipping when drawing map_image. Also, make sure to apply the framespace clip when drawing the map surface onto the final canvas. Thanks @jiin.moon for the initial patch (see D4694). @fix Signed-off-by: Jean-Philippe Andre <>
2017-03-02genlist: Remove weird behavior about item_show, bring_inJiwon Kim
Summary: When if item_show / bring_in is proceeded as 'deferred_show' sequence, Scrollto_Type does not be checked perfectly. As a result, ELM_GENLIST_ITEM_SCROLLTO_NONE and any other integer values are worked such as ELM_GENLIST_ITEM_SCROLLTO_BRING_IN. As doxygen of Elm_Genlist_Item_Scrollto_Type, ELM_GENLIST_ITEM_SCROLLTO_NONE and other incorrect number should not work. Fixes T4854 @fix Reviewers: SanghyeonLee, woohyun, jpeg Reviewed By: jpeg Subscribers: id213sin, conr2d, cedric Maniphest Tasks: T4854 Differential Revision:
2017-03-02emotion - fix empty video data frame update when using vdpau accelCarsten Haitzler (Rasterman)
fixes a segfault when using vdpau+gst and where the first frame seems to be empty/zero. @fix
2017-03-02doc: Fix invalid group classification for Edje_AudioJeeyong Um
Summary: Edje_Audio group should belong to Edje group. Reviewers: cedric, jpeg Reviewed By: jpeg Differential Revision:
2017-03-02ecore: Fix typo in error messageBryce Harrington
Reviewers: cedric, jpeg Reviewed By: jpeg Subscribers: jpeg, cedric Differential Revision:
2017-03-02ecore_imf/ibus: Fix memory leak allocated by ibus_bus_newJihoon Kim
2017-03-01ecore-evas-wayland: Fix yet another wayland session recovery breakDerek Foreman
commit 81783ec75caf4e4314abd8baf362718379b86570 combined two "identical" pieces of code that weren't identical. The removed code never checked if the evas was visible before performing operations to make it so, the code left behind would bail if the evas was visible. Reset the visible status during disconnect to make sure we properly show windows after a session recovery. ref @fix Session works on the software engines at this point. Use this as a bisect point next time someone fubars it. GL still broken. Window geometry seems like it doesn't get updated right either, but at least clients reconnect again. #SessionRecoveryWorksHere
2017-03-01ecore_wl2: Fix a wayland session recovery breaker... againDerek Foreman
We need to bind a shell on reconnect, but dfb2af697 made sure we only bind a single shell per wayland display for the life of the display object - which lives longer than the connection. That means when session recovery tries to reconnect it never bothers to bind a shell, so the client can never post buffers. ref ref @fix
2017-03-01Revert "ecore-wl2: Send surface_commit after ack_configure"Chris Michael
Reverting this as apparently one source says to send a commit after ack_configure, and another source says its wrong... This reverts commit 1187035fe669d2bfc77f600d2e5a8700eb1ff194.
2017-03-01Revert "ecore-evas-wayland: Don't register animators until window gets shown"Chris Michael
Reverting this as apparently it broke session recovery for some odd ass reason... This reverts commit 38f3854f45bcfca566feee882919d7a66f92ce13.
2017-03-01ecore-wl2: Fix efl apps crashing on close in waylandChris Michael
Commit c6b59be1da ensured display cleanup after roundtrips, however we cannot call the display_cleanup function After the display has been disconnected ... oopsie. Essentially the call to the cleanup function was in the wrong place here so fix. Signed-off-by: Chris Michael <>
2017-03-01ecore-evas-wayland: Remove duplicated codeChris Michael
As we already call the same functions inside _ecore_evas_wl_common_show, there is no need to duplicate the same code when we have defer_show set...just call the show function. @fix Signed-off-by: Chris Michael <>
2017-03-01ecore-evas-wayland: Fix issue of apps not starting up in fullscreen modeChris Michael
Calls to make a window fullscreen do require the window to already have a shell surface with which to fullscreen. If an app sets the window fullscreen property when the window is not shown yet, then the app would never startup fullscreen. This patch fixes that issue by adding a 'defer_fullscreen' flag to Ecore_Evas (wayland) so that when the window does finally get shown, we can show it in fullscreen. Addresses part of the T5044 ticket... ref T5044 @fix Signed-off-by: Chris Michael <>
2017-03-01ecore: Don't use logging domains with spacesChris Michael
Small patch to change the name of the ecore_animator logging domain. Names with spaces in them make it impossible to export EINA_LOG_LEVELS_GLOB inside a bashrc Signed-off-by: Chris Michael <>
2017-03-01ecore-wl2: Send surface_commit after ack_configureChris Michael
Small patch to ensure we send a surface commit after sending the ack_configure. This fixes an issue where E-WL internal windows would not maximize. Fixes T5192 @fix Signed-off-by: Chris Michael <>
2017-03-01ecore-wl2: Ensure display cleanup after roundtripsChris Michael
Commit ee52a28d041dfb02da0f2deca0714beb5eaa51fd added a roundtrip to ensure and pending wl events were handled before we disconnected the display. While this ensures some things like session recovery destroy work again, it lead to an issue where the _ecore_wl2_display_cleanup function was called BEFORE we processed pending events. This (in turn) causes crashes due to processing of pending events that relied on things like Ecore_Wl2_Input existing. As the display cleanup function clears inputs & outputs, we need to defer calling that until the display_roundtrip has dispatched and handled pending events. @fix Signed-off-by: Chris Michael <>
2017-02-28elm_cnp: allocate space for null terminator in _wl_targets_converterDerek Foreman
strcat needs room for a string terminator.
2017-02-28ecore: improve debugging of animator.Cedric BAIL
2017-02-28ecore_evas: rely as much as possible on display source for animator to ↵Cedric BAIL
reduce spurious tick.
2017-02-28ecore-wl2: Cleanup function for finding globalChris Michael
As per Mike, the iterator macro already does the casting for us, so we can cleanup the code here and not do casting, plus we can remove an extra variable...bonus ;) Signed-off-by: Chris Michael <>
2017-02-28ecore-wl2: Use EINA_ITERATOR_FOREACH macroChris Michael
Small patch to change from while (iterator) to using the EINA_ITERATOR_FOREACH macro...that I had forgotten about...thanks Mike ;) Signed-off-by: Chris Michael <>
2017-02-28ecore-wl2: Ensure we only bind one wayland shellChris Michael
This patch adds prioritizing to our wayland shell binding code so that we only bind One shell that the compositor advertises. During the global_add callback, the shells get added to the 'globals' hash, and when sync is done, we will search for shells to bind based on priority so that we can ensure we always bind to the latest supported shell. ref T5226 Signed-off-by: Chris Michael <>
2017-02-28Revert "ecore-wl2: Only bind one shell"Chris Michael
Reverting this in favor of a better approach (using a priority list) as discussed on IRC. This reverts commit 0e93f03636ec10710547513fb865ef2703e937a4.
2017-02-28elementary: Don't update opaque/input regions if not visibleChris Michael
Small patch to reduce calls to setting opaque/input regions in wayland. Basically, if the window is not shown then there is no point in updating these regions until such time that the window is actually visible and the regions will get committed. ref T5226 @fix Signed-off-by: Chris Michael <>
2017-02-28ecore-imf-wayland: Reduce calls to set_cursor_rectangleChris Michael
Avoid calls to zwp_text_input_v1_set_cursor_rectangle if we do not need to. Previous code here would always call this function even if the cursor rectangle was in the same position. Now we set a flag on the cursor_location field to let us know that it needs updating. ref T5226 @fix Signed-off-by: Chris Michael <>
2017-02-28ecore-wl2: Actually update input/opaque regionsChris Michael
Previous commit f8f71d05cdc7a8578329f75b0101662220390f20 to avoid resetting opaque & input regions was not totally complete as it did not update the actual values...small patch to fix that. Signed-off-by: Chris Michael <>
2017-02-28ecore-imf-wayland: Remove duplicate header includeChris Michael
wayland_imcontext.h already includes this header, so no need to re-include. Also add missing (void) to function declaration @fix Signed-off-by: Chris Michael <>
2017-02-28ecore-imf-wayland: Formatting fixesChris Michael
NB: No functional changes Signed-off-by: Chris Michael <>
2017-02-28ecore-wl2: Avoid resetting opaque & input regions if they matchChris Michael
Small patch to avoid setting the same opaque/input regions if they already match what is being requested. ref T5226 @fix Signed-off-by: Chris Michael <>
2017-02-28ecore-wl2: Only bind one shellChris Michael
Since we only ever use One shell at a time, let's not bind all of them as that is useless. ref T5226 @fix Signed-off-by: Chris Michael <>
2017-02-28eina: move the _eina_main_loop set before we init anythingMarcel Hollerbach
otherwise we could get into problems. fix T4891 @fix
2017-02-28eina_value: Fix min/max values of long for WindowsJean-Philippe Andre
long is 32 bit on Windows (both 32, 64 bit). I wonder why eina_value doesn't simply use LONG_MIN/MAX O_o Fixes T5204
2017-02-28eina:list: Fix resource leakFlavio Ceolin
Summary: The usage of the macro EINA_MAGIC_CHECK_LIST can lead (in some cases) to leaks. Signed-off-by: Flavio Ceolin <> Reviewers: jpeg Reviewed By: jpeg Subscribers: cedric, jpeg Differential Revision:
2017-02-28evas: Reset state to GL_TEXTURE_2DJean-Philippe Andre
This should fix an ERR message under gl_drm and probably an actual bug. This reverts 8f2cfdf4900e8e8b13f48c213512041e5f. I don't think the texture target should be part of the context information. It should instead be a property of the texture. Fixes T5171
2017-02-28evas: Drop duplicate macro definitions SETUP_LINE_*Bryce Harrington
Summary: SETUP_LINE_SHALLOW and SETUP_LINE_STEEP are each identically defined (except whitespace) in evas_line_main.c Reviewers: cedric, jpeg Subscribers: jpeg, cedric Differential Revision:
2017-02-28ecore_imf/ibus: fix memory leakJihoon Kim
2017-02-27ecore_evas: animator eo event are not a legacy event.Cedric BAIL
2017-02-27edje: reorder shutdown to match internal event emit use.Cedric BAIL
We do have event emited that rely on evas still being initialized. If we shutdown evas and then process ecore event, we would be in trouble.
2017-02-27ecore: forcefully flush pending event when ecore_shutdown is called.Cedric BAIL
If a component emit Ecore_Event and they aren't processed before the call it call ecore_shutdown, there is no way to prevent this event from being triggered after the component at shutdown itself. Which may well lead to a use after free case. As we don't know which event are pending and we also are not shuting down ecore completely as they are still other component using it, we can only flush all pending event right away.
2017-02-27evas: properly disable Evas_Object event catching once we can't access Evas ↵Cedric BAIL
2017-02-27emile: rename emile_image_register to emile_image_callback_set.Cedric BAIL
This fix ABI report according to discussion on the mailing list.
2017-02-27elm_code: Hide the cursor when it is off screenAndy Williams
This resolves cursor artifacts that could be seen @fix
2017-02-27Revert "Revert "ecore-imf: Don't always load all modules""Chris Michael
Reverting the revert here...this Does actually work in a wayland environment, however you may need to export ELM_DISPLAY=wl in order to get the desired result... NB: If you desire a specific ecore_imf module then you may want to export ECORE_IMF_MODULE=xyz, else this patch will try to load them in the order specified in the code (xim, ibus, scim, wayland). This reverts commit 5c858b86e5c84d4ced77d47bb61cc6817f0e3645.
2017-02-27Revert "ecore-imf: Don't always load all modules"Chris Michael
Reverting this as it broke autoloading of the ecore_imf WL module. This commit basically only loaded an X11 Ecore_Imf module even under a wayland environment. This reverts commit 75b4bde8d226ffb59dfad5bcdcd76ce5dde5e1ac.
2017-02-27ecore-imf: Don't always load all modulesChris Michael
If there is no ecore_imf_module specified in the environment, then previous code here would load ALL the modules when we really only need one. This patch fixes that issue...if a module is specified in the env (export ECORE_IMF_MODULE=xyz) than that module will be loaded. If NO module is specified in the env, then we will loop the list of built modules and load only one. This patch fixes an issue where running 'WAYLAND_DEBUG=1 WAYLAND_DISPLAY=wayland-0 terminology' inside an X11 environment would cause ecore_imf to load the wayland module (as reported by Derek). NB: If this patch breaks automatic IMF (it should not) then please feel free to revert. @fix Signed-off-by: Chris Michael <>
2017-02-27elementary: Fix issue of trying to init ecore_wl2 if DISPLAY is setChris Michael
Small patch to fix an issue that Derek brought up ... that is basically, if you try: WAYLAND_DEBUG=1 WAYLAND_DISPLAY=wayland-0 terminology while inside an X11 environment, then elm_config would try to initialize ecore_wl2 even when running under X11. @fix Signed-off-by: Chris Michael <>
2017-02-27ecore-evas-wayland: Don't register animators until window gets shownChris Michael
Small patch to not call _ecore_evas_register unless we are showing the window. This stops creation of rogue animators on cursors until the window is actually going to be shown. Fixes T5209 @fix Signed-off-by: Chris Michael <>
2017-02-27elementary: Minor formatting fixChris Michael
NB: No functional changes Signed-off-by: Chris Michael <>
2017-02-27elementary: Don't set pointer object theme on startChris Michael
As we are already resetting the pointer object theme when we make a call to set the cursor, don't set it on window creation. This should address the issue of animators getting created on window creation. ref T5209 @fix Signed-off-by: Chris Michael <>
2017-02-27ecore_imf/ibus: Fix memory leakJihoon Kim