summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2 hoursefl.canvas.textblock: annotate obstacle methods as betaHEADmasterAli Alzyod
Summary: We decided to annotate these methods as beta **obstacle_add** **obstacle_del** **obstacles_update** Reviewers: woohyun, segfaultxavi Reviewed By: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8460 Differential Revision: https://phab.enlightenment.org/D11136
4 hoursecore_wl2: fix compilationMarcel Hollerbach
4 hoursdocs: Slight improvements to eina_types.eot Matrix docsXavi Artigas
Reference D11158
4 hoursEolian eina_types: Add Eina.Matrix4 typeJunsuChoi
Summary: for using in eolian Test Plan: N/A Reviewers: Hermet, bu5hm4n, segfaultxavi Reviewed By: bu5hm4n, segfaultxavi Subscribers: bu5hm4n, segfaultxavi, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11158
5 hoursefl.ui.textbox: move file implementation in to internal classAli Alzyod
We want to keep implementation for file interface in a safe place and remove it from our side world (eo). This is a simple copy-paste, from efl.ui.textbox into efl_ui_internal_text_interactive Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11153
5 hoursRevert "efl_ui_image: Call unload file when calling file_set"JunsuChoi
Summary: This reverts commit 93bd97025983e48ae8048d0c63b5d8b314f1de42. efl.ui.image using prev and current inner image object. Unloading the efl.ui.image class can be unloaded up to the prev image. And because efl.ui.image is using the image caching feature together, it may get unexpected errors. Therefore, revert this patch. Test Plan: N/A Reviewers: Hermet Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11157
6 hoursefl_text_interactive: selection enhancmentAli Alzyod
1- Implement setting selection range programmatically by modifying selection cursors from **efl_text_interactive_selection_cursors_get** 2- Add setter with **efl_text_interactive_selection_cursors_set** to set the range at once (modify start and end) Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Reviewed-by: WooHyun Jung <wh0705.jung@samsung.com> Differential Revision: https://phab.enlightenment.org/D10968
7 hoursevas_object_textblock: treat variation sequence as single runAli Alzyod
Summary: Variation sequence treated as a single run, if we found one, we keep looking adding to the same run, but if it is not, then we need to start a new one. Before: {F3826735} After: {F3826736} Test Plan: ``` #include <stdio.h> #include <Elementary.h> /* gcc -o example test.c `pkg-config --cflags --libs elementary` */ EAPI_MAIN int elm_main(int argc EINA_UNUSED, char **argv EINA_UNUSED) { Evas_Object *win, *en; elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED); win = elm_win_util_standard_add("emoji-example", "emoji-example"); elm_win_autodel_set(win, EINA_TRUE); en = elm_entry_add(win); elm_entry_scrollable_set(en, EINA_TRUE); evas_object_size_hint_weight_set(en, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND); evas_object_size_hint_align_set(en, EVAS_HINT_FILL, EVAS_HINT_FILL); elm_object_text_set(en, "<font_size=25>&#x262a;&#x262a;&#xfe0f;&#x262a;가</font_size>"); evas_object_show(en); elm_object_content_set(win, en); evas_object_resize(win, 400, 200); evas_object_show(win); elm_run(); return 0; } ELM_MAIN() ``` Reviewers: woohyun, bowonryu Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8542 Differential Revision: https://phab.enlightenment.org/D11096
7 hoursefl.text.interactive: use Eina_Int_Range for selection range eventAli Alzyod
Summary: 1- add new Eina type (Eina_Int_Range). which represents int range (start, Len). 2- Use this type instead of Efl.Text_Range with selection events. Reviewers: cedric, woohyun, bu5hm4n, segfaultxavi, zmike Reviewed By: woohyun Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8570 Differential Revision: https://phab.enlightenment.org/D11128
10 hoursefl_ui_spotlight: rename Stack_Manager to Fade_ManagerJaehyun Cho
Summary: Since Stack_Manager displays fade in/out transition effects, the class name is renamed from Stack_Manager to Fade_Manager. Depends on D11142 Reviewers: segfaultxavi, bu5hm4n, zmike Reviewed By: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11143
10 hoursefl_ui_spotlight: rename Manager_XXX and Indicator_XXXJaehyun Cho
Summary: In spotlight classes, "Manager" and "Indicator" are used as prefix in the class names. e.g. Efl.Ui.Spotlight.Manager_Plain, Efl.Ui.Spotlight.Indicator_Icon However, those classes are basically manager and indicator classes with different features. Therefore, "Manager" and "Indicator" should be used as postfix in the class names. e.g. Efl.Ui.Spotlight.Plain_Manager, Efl.Ui.Spotlight.Icon_Indicator However, for the easier usage of C APIs, c_prefix of those classes are remained to be "efl_ui_spotlight_manager_xxx" and "efl_ui_spotlight_indicator_xxx". Reviewers: segfaultxavi, bu5hm4n, zmike Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11142
14 hoursedje - store original size in edje struct and dont exceed max sizeCarsten Haitzler (Rasterman)
evas can tell us max texture size. in edje when we have image sets (multiple images that make up mipmaps effectively for a logical image), we now can avoid choosing an image that exceeds max texture size. this actually fixes bugs i have seen on the rpi3 which has a max texture size of 2048 which makes it easy to exceed it with wallpapers or even terminology's default theme. so combo of new feature and fix... but requires a rebuild of the edj files... @feat + @fix
16 hourscsharp: cleanup concrete classYeongjong Lee
Summary: Concrete class is only used to call static member of NativeMethod. they don't need any inheritance and implementation of c functions. Depends on D9893 Test Plan: ninja test Reviewers: lauromoura, felipealmeida Subscribers: Jaehyun_Cho, woohyun, segfaultxavi, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9894
16 hourseina: add new range Data typeali
Summary: Introduce new data type (Eina.Range) which represent range (part of series) **eina_range_max_get** **eina_range_intersect** **eina_range_union** **eina_range_contains** **eina_range_equal** Reviewers: cedric, woohyun, bu5hm4n, segfaultxavi, zmike Reviewed By: woohyun Subscribers: vtorri, cedric, #committers, #reviewers Tags: #efl Maniphest Tasks: T8570 Differential Revision: https://phab.enlightenment.org/D11133
21 hoursefl_ui_image: Call unload file when calling file_setJunsuChoi
Summary: We have checked that unload is not called even if different files call again elm_image_file_set on the same object. If file_set is called repeatedly, I think a potential error can occur. So, modify to call unload when doing file_set by referring to efl_ui_zoomable. Test Plan: N/A Reviewers: Hermet, zmike Reviewed By: zmike Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11148
24 hoursevas_object_box: fix invalidatorMarcel Hollerbach
the iteration over the content of the box did never cleanup the children pointer, which resulted in buggy behavior. This fixes test suite crashes with freeq debugging on. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11123
24 hourstests/ecore_wl2: Add test for ecore_wl2_input_keyboard_repeat functionsChristopher Michael
ref T8016
25 hoursRevert "ecore-wl2: Move ecore_wl2_window_output_find function to be internal"Woochanlee
Summary: This reverts commit 64dacb3d07f6ed74a53e4e38c25e27ebd9bfb6f7. User can't use ecore_wl2_output_dpi_get() , ecore_wl2_output_transform_get() APIs without this API. Reviewers: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11154
25 hourstests/ecore_wl2: Add tests for move, resize, resizing_get functions.Woochanlee
Summary: Add ecore_wl2_window_move ecore_wl2_window_resize ecore_wl2_window_resizing_get ref T8016 Reviewers: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8016 Differential Revision: https://phab.enlightenment.org/D11150
25 hoursRevert "ecore-wl2: Move ecore_wl2_input_cursor_from_name_set to be internal"Woochanlee
Summary: This reverts commit 6a1d6b6705911dca8e9facc0fefc55e02c6e3694. This API is used publicly in Tizen, so we cannot make it internal. ref T8016 Reviewers: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8016 Differential Revision: https://phab.enlightenment.org/D11147
25 hoursecore_wl2: Add ecore_wl2_input_default_input_get() API.Woochanlee
Summary: Gets default input which created by display. Reviewers: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11132
25 hoursecore_wl2: Add ecore_wl2_input_keyboard_repeat_set() API.Woochanlee
Summary: Add API to set input's keyboard repeat. get API was already there. Reviewers: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11131
32 hoursRevert "efl_mono: remove class ExtensionTag"Jaehyun Cho
Extension Methods' classes have methods with same names and parameters. e.g. Text<T>(this Efl.Ui.ItemFactory<T> fac) Although the where clause contains different classes, they cannot be identified as different methods by C# compiler. e.g. Text<T>(this Efl.Ui.ItemFactory<T> fac) where T : Efl.Ui.Button e.g. Text<T>(this Efl.Ui.ItemFactory<T> fac) where T : Efl.Ui.Check As a result, to avoid ambiguous methods, ExtensionTag should be used as a second parameter of each method. e.g. Text<T>(this Efl.Ui.ItemFactory<T> fac, ExtensionTag<Efl.Ui.Button, T>magic = null) where T : Efl.Ui.Button e.g. Text<T>(this Efl.Ui.ItemFactory<T> fac, ExtensionTag<Efl.Ui.Check, T>magic = null) where T : Efl.Ui.Check This reverts commit 76631f502a8234c04ed8124bfdebe62ed5bdf954.
37 hourseolian_mono: avoid generating set-only propertyYeongjong Lee
Summary: According to Property Design Guidelines of MS, set-only properties are not recommeneded. (see more, https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/property) Furthermore, there is stylecop warnings(CA1044) ref T8396 List of removed set-only properies. ``` Efl.Access.Editable.IText.TextContent { set; } Efl.App.CommandArray { set; } Efl.App.CommandString { set; } Efl.Canvas.Filter.IInternal.FilterChanged { set; } Efl.Canvas.Filter.IInternal.FilterInvalid { set; } Efl.Canvas.ImageInternal.FilterChanged { set; } Efl.Canvas.ImageInternal.FilterInvalid { set; } Efl.Canvas.Textblock.FilterChanged { set; } Efl.Canvas.Textblock.FilterInvalid { set; } Efl.Canvas.Vg.Image.Data { set; } Efl.Canvas.Vg.Node.CompMethod { set; } Efl.Core.ICommandLine.CommandArray { set; } Efl.Core.ICommandLine.CommandString { set; } Efl.Exe.CommandArray { set; } Efl.Exe.CommandString { set; } Efl.Ui.AlertPopup.Button { set; } Efl.Ui.Collection.MatchContent { set; } Efl.Ui.CollectionView.MatchContent { set; } Efl.Ui.IScrollable.MatchContent { set; } Efl.Ui.ImageZoomable.MatchContent { set; } Efl.Ui.Panel.MatchContent { set; } Efl.Ui.PositionManager.Grid.DataAccess { set; } Efl.Ui.PositionManager.Grid.ScrollPosition { set; } Efl.Ui.PositionManager.Grid.Viewport { set; } Efl.Ui.PositionManager.IDataAccessV1.DataAccess { set; } Efl.Ui.PositionManager.IEntity.ScrollPosition { set; } Efl.Ui.PositionManager.IEntity.Viewport { set; } Efl.Ui.PositionManager.List.DataAccess { set; } Efl.Ui.PositionManager.List.ScrollPosition { set; } Efl.Ui.PositionManager.List.Viewport { set; } Efl.Ui.Scroll.Manager.MatchContent { set; } Efl.Ui.Scroll.Manager.Pan { set; } Efl.Ui.Scroller.MatchContent { set; } Efl.Ui.Spotlight.Manager.Size { set; } Efl.Ui.Textbox.TextContent { set; } Efl.Ui.Widget.ResizeObject { set; } Efl.Ui.Win.PropFocusSkip { set; } ``` Test Plan: meson build -Dbindings=mono,cxx -Dmono-beta=true Reviewers: woohyun, felipealmeida, segfaultxavi Reviewed By: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8396 Differential Revision: https://phab.enlightenment.org/D11138
44 hourstests/ecore_wl2: Fix issue of tests running without a Wayland displayChris Michael
This fixes an issue with CI where these tests would try to run without a Wayland compositor. This was missed during review, Thanks Marcel for pointing this out. ref T8016
46 hoursRevert "efl_text_interactive: selection enhancment"Marcel Hollerbach
This reverts commit 09f0d66d90e4db5f879f4c998e8a07b26fa749fc. This breaks CI, and tests do not pass anymore, hence no other revision can be verified. The revision is reopened. lets take a second look at this.
47 hoursecore-wl2: Move ecore_wl2_input_cursor_from_name_set to be internalChris Michael
This function is unused outside of EFL, so it can be made internal ref T8013
47 hoursecore-wl2: Move ecore_wl2_display_terminate to be internalChris Michael
This function is unused outside of EFL, so it can be made internal ref T8013
2 daystests/ecore_wl2: Code clean up and Add, Modify TCs.Woochanlee
Summary: Code clean up. Add flush, sync_is_done APIs. Modify input_find. ref T8016 Reviewers: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8016 Differential Revision: https://phab.enlightenment.org/D11111
2 daysefl_ui_spotlight/pager/stack: remove @betaMarcel Hollerbach
there has been more than 1 month without any comment, i think this looks fine now ? The transition event is kept beta for now, as we have right now a discussion about range that we might be able to use here. Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es> Reviewed-by: Jaehyun Cho <jae_hyun.cho@samsung.com> Differential Revision: https://phab.enlightenment.org/D11135
2 daysefl_ui_spotlight_manager: fix not to change sub objects' colorJaehyun Cho
Summary: Widget's group_member_add() sets its sub objects' color with the parent's color. Since spotlight managers call group_member_add() with spotlight container and its sub objects, the sub objects' color can be changed. e.g. packed rectangle's color is changed to white (default color value) To resolve the above issue, spotlight managers set data "_elm_leaveme" before calling group_member_add() not to change sub objects' color. Reviewers: bu5hm4n Reviewed By: bu5hm4n Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11134
2 daysEfl.Canvas.Group: implement Efl.Gfx.FilterShinwoo Kim
Summary: This patch makes Efl.Canvas.Group work for Efl.Gfx.Filter Reviewers: Hermet, jsuya, zmike Reviewed By: Hermet Subscribers: zmike, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10435
2 daysdocs: Typos in Doxygen docsXavi Artigas
3 daysefl_text_interactive: selection enhancmentAli Alzyod
Summary: 1- Implement setting selection range programmatically by modifying selection cursors from **efl_text_interactive_selection_cursors_get** 2- Add setter with **efl_text_interactive_selection_cursors_set** to set the range at once (modify start and end) Reviewers: woohyun, segfaultxavi, zmike, bu5hm4n Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8521, T8522 Differential Revision: https://phab.enlightenment.org/D10968
3 daysRevert "csharp: Property Indexer implementation"Yeongjong Lee
Summary: This reverts commit 0954e501fd4008c40b3848de1f2c91bcd53b2f71. According to Framework Design Guidelines of MS, most of indexed properties are not recommended in EFL#. (see, https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/property) It is better to leave properties which have a key as methods. Reviewers: woohyun, felipealmeida Reviewed By: woohyun Subscribers: segfaultxavi, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11114
3 daysRevert "ecore_wl2: Fix a memory leaking case"Marcel Hollerbach
This reverts commit 97e71b9dc4fa73da99a890d9c39d6617e529dc94. This commit is absolutly wrong. This makes running wayland apps intree impossible, and also crashes tests when run in wayland mode. I asked multiple times in the revision for clarification, noone answered. This tricked me today for the second time, so better revert that.
3 daysefl.input.text.hints_type: rename into content_typeAli Alzyod
Reviewers: woohyun, segfaultxavi Reviewed By: woohyun, segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8541 Differential Revision: https://phab.enlightenment.org/D11130
3 daysefl.ui.textbox: using efl_provider_findAli Alzyod
Summary: > Code structures like top = elm_widget_top_get(data); and if (efl_isa(top, EFL_UI_WIN_CLASS)) can be replaced with top = efl_provider_find(widget, EFL_UI_WIN_CLASS) No type check needed. (That should enhance the performance) Reviewers: woohyun, bu5hm4n, cedric Reviewed By: bu5hm4n, cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8522 Differential Revision: https://phab.enlightenment.org/D11127
3 daysefl_canvas_animation: rename Animation_XXX to XXX_AnimationJaehyun Cho
Summary: In animation classes, "Animation" is not used as a namespace but it is used as a prefix in the class names. e.g. Efl.Canvas.Animation_Alpha However, those classes are basically animation classes with different features. Therefore, "Animation" should be used as a postfix in the class names. e.g. Efl.Canvas.Animation_Alpha -> Efl.Canvas.Alpha_Animation However, for the easier usage of C APIs, c_prefix of animation classes are remained to be "efl_animation_xxx". Reviewers: segfaultxavi, bu5hm4n, zmike, Hermet, jsuya Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11108
4 daysefl.text.cursor: movement types renameali
Summary: replace prev with previous, replace char with character Reviewers: woohyun, segfaultxavi Reviewed By: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8567 Differential Revision: https://phab.enlightenment.org/D11095
4 dayselm win - fix client side move/resize req handling csd in xCarsten Haitzler (Rasterman)
we dont keep our window id up to date... it changes somewhere along the way during init.... (ecore evas does this e.g. go from normal to alpha window it has tocreate a new window id anyway)... so stay up to date so we send a req for the right window id... @fix
4 dayselm test - make window 480x490 to differentiate width vs heightCarsten Haitzler (Rasterman)
5 daysevas - fix access-after-free number 2Carsten Haitzler (Rasterman)
follow on from 3aa250e17ff34a1b0466b65fe55ffe1fced291ff and T8534 looking into more possible problems and fixes @fix
6 dayselm win + ecore evas - fix csd stuff like base size and min sizingCarsten Haitzler (Rasterman)
this fixes a lot that was broken with csd... but not everything. @fix
6 daysecore_con - freebsd bind blocking workaroundCarsten Haitzler (Rasterman)
this is to try do a workaround a hard to reproduce blocking bind on some freebsd systems (i can't repro it on my fbsd vm), so try use file locks as an extra barrier and hope they do the right thing without other mysterious problems. @fix
6 dayselm - fix filesel deferred unref to not crashCarsten Haitzler (Rasterman)
@fix
6 daysevas - fix access-after-free where during destroy hash item not clearedCarsten Haitzler (Rasterman)
leave it in the hash unfreed as it will be freed when the hash is soon after durint destruction. @fix
6 daysefl_ui_scrollbar: change scrollbar state when theme is reloaded.Hosang Kim
Scrollbar visible state is not synchronized when theme is reloaded. Differential Revision: https://phab.enlightenment.org/D10649
6 daysIntroduce SeparatorMarcel Hollerbach
Summary: this is just like elm_separator, just written for unified widgets. This inherits from item, which has the advantage that this separator can also be added into item container. Reviewers: zmike, segfaultxavi Reviewed By: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11125
6 daysC++: Fix use of @c_type tag in struct definitionFelipe Magno de Almeida
Summary: Depends on D11090 Reviewers: zmike Reviewed By: zmike Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11099