path: root/src/bin/efreet (follow)
AgeCommit message (Collapse)Author
2020-01-15eina - fix eina_strndup test passingCarsten Haitzler (Rasterman)
2019-11-16efreet - consider ctime changes as changes tooCarsten Haitzler (Rasterman)
some distros do odd things with source desktop files and set their mtime timestamps to 0... thus we can't tell that there is a change. thier ctimes do change, so consider the newer of either of these as the modification time to not miss updates @fix
2019-06-06efreetd - timeout in 2 not 10sec to have fewer hangs on shutdown/exitCarsten Haitzler (Rasterman)
2019-05-22include evil_private.h in last files, and disable symbolic links on Windows ↵Vincent Torri
in a couple of files Test Plan: compilation Reviewers: zmike, raster, cedric Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Differential Revision:
2019-05-20remove Evil.h when not necessary, include evil_private.h when necessaryVincent Torri
Test Plan: compilation Reviewers: zmike, raster, cedric Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Differential Revision:
2019-05-06meson: add intl to efreet all binary depsMike Blumenkrantz
this must be explicitly added for windows builds Reviewed-by: Marcel Hollerbach <> Differential Revision:
2019-04-04efreetd: remove a tentative global variable definitionWonki Kim
Summary: there is a global variable that is defined tentatively. this patch modify it not to be tentitive explictly. Reviewers: raster, cedric, zmike Reviewed By: raster, zmike Subscribers: #reviewers, #committers Tags: #efl Differential Revision:
2019-01-15efreet - fix warnings on windows to do with size castingCarsten Haitzler (Rasterman)
no actual bug - just warnings
2018-11-09efreet mime cache - expand buffer to avoid truncation by snprintfCarsten Haitzler (Rasterman)
2018-11-09efreetd - warn - expand buffer to avoid truncation by snprintfCarsten Haitzler (Rasterman)
2018-10-02here comes mesonMarcel Hollerbach
a new shiny buildtool that currently completes in the total of ~ 4 min.. 1 min. conf time 2:30 min. build time Where autotools takes: 1:50 min. conf time 3:40 min. build time. meson was taken because it went quite good for enlightenment, and is a traction gaining system that is also used by other mayor projects. Additionally, the DSL that is defined my meson makes the configuration of the builds a lot easier to read. Further informations can be gathered from the README.meson Right now, bindings & windows support are missing. It is highly recommented to use meson 0.48 due to optimizations in meson that reduced the time the meson call would need. Co-authored-by: Mike Blumenkrantz <> Differential Revision: Depends on D7011
2017-07-31efreet icon cache creation binary - remove redundent checkCarsten Haitzler (Rasterman)
found by PVS studio
2017-07-24efreetd cache create - fix reallocs to bail on out of memory cleanlyCarsten Haitzler (Rasterman)
2017-07-23efreetd cache - fix leak of strbuf when error conditions abort saveCarsten Haitzler (Rasterman)
fix CID 1374951
2017-07-23efreetd cache - handle queue case leaking strbufCarsten Haitzler (Rasterman)
fix CID 1374954
2017-07-16efreet icon cache create bin - check realloc results and handleCarsten Haitzler (Rasterman)
2017-07-16efreet cache create binary - check realloc results and handle failureCarsten Haitzler (Rasterman)
2017-05-12efreet: Fix failure to save list data to outputBryce Harrington
Summary: This fixes a typo in the fix 55676b33, which introduced an invalid early return from the save_list function, preventing it from outputing the list data to the file. @fix CID1375005, CID1375004 Reviewers: jpeg Reviewed By: jpeg Subscribers: stefan_schmidt, cedric, jpeg Differential Revision:
2017-05-11efreet: free the allocated buffer before returningStefan Schmidt
This fixes the commit 169a08c03a6a7270e185bda85d4ab9afd9063c8e (efreetd: BSD optimizations). Coverity rightly pointed out six different leaks of various buffers on error paths. CID: 1374949 1374950 1374951 1374952 1374953 1374954
2017-05-10efreetd: BSD optimizations.Al Poole
Summary: Related to ticket T5475. Reviewers: raster, cedric Subscribers: jpeg, cedric, raster Differential Revision: Signed-off-by: Cedric BAIL <>
2017-04-23efreetd - make efreetd use eio and not ecore_file_monitor for monitoringCarsten Haitzler (Rasterman)
this should fix T5130 - freebsd's efreetd polling regularly @fix
2017-04-18efreet cache create - check return values of i/o funcsCarsten Haitzler (Rasterman)
this is pretty harmless but it checks these and at least reports an error... this fixes CID 1361941 + 1361940 @fix
2017-03-07removing duplicates winsock2.hIvan Furs
Summary: winsock2.h included in Ecore.h But Ecore.h ' is included in /bin/efreet/efreet_desktop_cache_create.c src/bin/efreet/efreet_mime_cache_create.c src/tests/ecore_con/ecore_con_test_efl_net_ip_address.c Reviewers: NikaWhite, cedric, raster, an.kroitor Reviewed By: raster Subscribers: artem.popov, cedric, jpeg Differential Revision:
2017-02-09efreetd - remove unused varCarsten Haitzler (Rasterman)
2017-02-09efreetd cache - use eina home env get to centralize homedir fetchingCarsten Haitzler (Rasterman)
this cleans up and improves a getenv that should really use eina
2017-02-09efreetd - dont use XDG_RUNTIME_DIR or EFREET_LOG env vars for setuidCarsten Haitzler (Rasterman)
if a setuid app needs efreet - it will not be able to contact the users' efreetd and thus may spawn it's own... and thus we cant have this now spawned efreetd using env vars inherited from the unpriveleged etc. user, so ignore them.
2016-12-08efreet_desktop: fix potential error in efreet_desktop_cache_createSungtaek Hong
Summary: - old_file_ids is freed but not set as NULL. If it goes to error code, old_file_ids will be freed again. Reviewers: jpeg, cedric, Hermet Reviewed By: Hermet Subscribers: conr2d Differential Revision:
2016-12-05efreetd: handle invalid fd in all casesStefan Schmidt
Very unlikely that we will get a -1 when opening /dev/null but you never know what kind of system you are running on. CID: 1361759
2016-08-23efreet - save about 240-300k or so of memory used by efreet mimeCarsten Haitzler (Rasterman)
so efreet mime was loading a bunch of mime type info files, parsing them on startup and allocating memory to store all this mime info - globs, mimetype strings and more. all a big waste of memory as its allocated on the heap per process where its the SAME data files loaded every time. so make an efreet mime cache file and a tool to create it from mime files. mmap this file with all the hashes/strings in it so all that data is mmaped once in memory and shared between all processes and it is only paged in on demand - as actually read/needed so if your process doesnt need to know about mime stuff.. it wont touch it anyway. this saves about 240-300k or so of memory in my tests. this has not covered the mime MAGIC files which still consume memory and are on the heap. this is more complex so it will take more time to come up with a nice file format for the data that is nicely mmaped etc. @optimize
2016-08-19efreetd - only open log file is env var is set to do soCarsten Haitzler (Rasterman)
set EFREETD_LOG to something to get efreetd to log. otherwise efretd log files can end up rather larth and since they go in xdg_runtimedir - thats mostly a ramdisk... they eat actual ram. so save a lot of memory and only log if asked to. @fix
2016-05-02Revert "efreetd - reduce memory usage by using stringshare much more"Mike Blumenkrantz
partially reverts e4d815dc48c660a336670ec3cc67e6becbdcacfc this caused efreetd to crash almost immediately due to non-stringshared strings being used in a stringshare-only hash data descriptor
2016-04-23efreetd - reduce memory usage by using stringshare much moreCarsten Haitzler (Rasterman)
lots of long paths for monitoring file paths for icons etc. are in memory for efreetd. this reduces that memory by sharing them much more. @optimization
2016-04-08efreetd - dont use as per man page on windowsCarsten Haitzler (Rasterman)
2016-04-08efreet - use eina tmp dir instead of /tmp dirCarsten Haitzler (Rasterman)
use eina_environment_tmp_get() for windows
2016-04-08efreetd - fix more cache path handling to live in the cache dirCarsten Haitzler (Rasterman)
follow on fixes from 5028a8807780892c361ae976b567cd924fa529b1 @fix
2016-04-08efreet: fix tmp file/dir/log handling to not leave a mess and workCarsten Haitzler (Rasterman)
so efreets tmp file/cache/log file handling was broken, using filenames in tmp and renaming them to a caceh dir that can be on different filesystems. also log file should have been in a tmp dir ... and subsidrs cache didnt get renamed properly at all and thus not updated. @fix
2016-01-07efreet: fix undeclared functionJean Guyomarc'h
libgen is needed on OSX because it contains the prototype of basename() which is required in the compiling unit. The result of basename() was therefore implicitely converted into an integer, which could leed to subtile issues. @fix
2015-12-23efreetd: send ipc for EFREET_EVENT_DESKTOP_CACHE_BUILD...alwaysMike Blumenkrantz
since the conversion from dbus -> ecore-ipc, efreetd has failed to notify when a cache build has completed, instead only sending the current state of the desktop cache: not built fix T2733 @fix
2015-12-16efreet_icon_cache_create: null theme eet file to avoid double freeMike Blumenkrantz
2015-12-05efl: add binary mode to open() callsVincent Torri
This allows better compatibility with Windows Signed-off-by: Cedric BAIL <>
2015-12-02fix efreetd to scan more subdirs for desktop and icon filesCarsten Haitzler (Rasterman)
we miss desktop files for apps and stuff because we dont monitor too deep a tree. this ups our tree depth to 10 levels. @fix
2015-12-02efreet desktop tracking - fix monitoring of dirs of custom desktopsCarsten Haitzler (Rasterman)
@fix this is wrong - start monitoring every/any dir in which a desktop file exists that we load a desktop file from. imagine you browse directories in efm with lots of desktop files in them - we end up monitoring lots of directories that we then rememebr and don't un-monitor. this disables monitoring of dirs from which we load a .desktop file from to fix this.
2015-11-09efreet: fix warningVincent Torri
Commit 0cd59bb1 introduced the use of basename() which needs libgen.h (hence winsock2.h before) on Windows. Signed-off-by: Cedric BAIL <>
2015-11-06eina/efreet: open file with binary file on WindowsVincent Torri
@fix Signed-off-by: Cedric BAIL <>
2015-11-02efreet - fix efreetd to not exit on $home being in extra app dirsCarsten Haitzler (Rasterman)
if a client added $home in the efreet extra desktops dirs, then efreetd would detect and nuke cache, exit, causing a restart cycle forever. this makes efreet simply ignore the errant dir so it can keep working. @fix
2015-10-23efreet: make sure that we use the right directory and ef for the cache.Cedric BAIL
2015-10-19efreet: use eina_file_mkstemp() for portability and fix a bug on WindowsVincent Torri
Signed-off-by: Cedric BAIL <>
2015-10-12efreet: use ecore_file function instead of stat() in the icon cache codeVincent Torri
Signed-off-by: Cedric BAIL <>
2015-10-12efreet: eina_file_mkstemp() needs a template with an extensionVincent Torri
Signed-off-by: Cedric BAIL <>
2015-10-12efreet: use eina_file_mkstemp() instead of mkstemp() for portabilityVincent Torri
Signed-off-by: Cedric BAIL <>