path: root/src/lib/ecore_file (follow)
AgeCommit message (Collapse)Author
2017-09-22EFL For WIN32: Replace HAVE_EVIL define with _WIN32Vincent 'vtorri' Torri
2017-04-18ecore_file: use new API eina_file_close_on_exec.Cedric BAIL
2017-04-18ecore file - use eina_file_mkstmp to solve umask complaintCarsten Haitzler (Rasterman)
this fixes coverity CID 1039614
2017-02-27docs: Fix typos and some wrong expressionsMyoungwoon Roy, Kim
Covers: Ecore_Drm, Ecore_Evas, Ecore_File, Ecore_IMF, and Ecore_IMF_Evas API reference doxygen. Summary: I had fixed some typos and wrong expressions, such as capital letters, singular Etc. in Ecore_Drm, Ecore_Evas, Ecore_File, Ecore_IMF, and Ecore_IMF_Evas API reference doxygen. Test Plan: Doxygen Revision Reviewers: stefan, cedric, raster, jpeg, Jaehyun_Cho Subscribers: conr2d Differential Revision:
2017-02-02cmake: add ecore_file.Gustavo Sverzut Barbieri
2017-01-12ecore_file: add case to properly rename a file in WindowsIvan Furs
Summary: If the file with a new path was created and 'rename' wants to replace the old path to the new path. 'rename' will return: Windows 7: -1 (errno=EEXIST) (EEXIST == 17) Ubuntu: 0 **EEXIST** **Ubuntu**: The link named by new is a directory that is not an empty directory. ( **Windows 7**: Files exist. An attempt has been made to create a file that already exists. For example, the _O_CREAT and _O_EXCL flags are specified in an _open call, but the named file already exists.( Test Plan: **Sample code to rename in Linux and Windows if the file with the new name already exists:** int main() { const char *_old = "old"; const char *_new = "new"; int fd1 = open(_old, O_CREAT); close(fd1); int fd2 = open(_new, O_CREAT); close(fd2); printf("rename:\t%s -> %s\n", _old, _new); int r = rename(_old, _new); if (r == 0) { printf("GOOD\n"); } else { printf("CODE ERROR:\n" ); printf(" -rename...: %d\n", r ); printf(" -errno....: %d\n", errno); } return 0; } Reviewers: raster, vtorri, jpeg, NikaWhite, reutskiy.v.v, an.kroitor, cedric Reviewed By: cedric Subscribers: artem.popov, cedric, jpeg Tags: #efl, #windows Differential Revision: Signed-off-by: Cedric BAIL <>
2016-11-30Revert "ecore_file: use win api for delete folder"Vyacheslav Reutskiy
It was mistake, rmdir work correct, problem was fixed in commit 56c202614b73f0e4c34d7a5cd070fe2b24d9217f This reverts commit 5e25b8037ca8858412627d76b6fe72e9c7279021.
2016-11-23ecore_file_download: callback completion_cb with status=1.Gustavo Sverzut Barbieri
When download is aborted we must call completion_cb using status == 1, this was checked in the test suite.
2016-11-23ecore_file: get stat from correct fileVyacheslav Reutskiy
2016-11-23ecore_file: use win api for delete folderVyacheslav Reutskiy
The RemoveDirectory on Windows guarantee that given folder will be delete.
2016-11-23ecore_file: update docs for ecore_file_rmdirVyacheslav Reutskiy
2016-11-22ecore_file: restore past behavior and fix ecore_file_download tests.Cedric BAIL
2016-11-21ecore_file_download: use new efl_net_dialer_http.Gustavo Sverzut Barbieri
Greatly reduce code complexity while providing better support, at least according to @netstar efl_net_dialer_http works better than traditional ecore_con_url on BSD.
2016-10-04ecore_file/ipc: clean up documentationJee-Yong Um
Summary: move comment from c source to header and adjust ingroup relationship Reviewers: cedric, jpeg, Hermet Reviewed By: Hermet Differential Revision:
2016-09-20ecore_file: Fix improper way of comparing in ecore_file_path_dir_exists @fixArtem Popov
Summary: There is wrong comparing while using strcmp function. Should be inverted. Reviewers: cedric, raster, NikaWhite Reviewed By: NikaWhite Subscribers: cedric, NikaWhite, jpeg Differential Revision:
2016-05-06ecore_file: fix memory leakJean Guyomarc'h
2016-04-23fix efreet/file monitor stringshare optimizationCarsten Haitzler (Rasterman)
fixes e4d815dc48c660a336670ec3cc67e6becbdcacfc that i just put in a few days back - it's a good idea to copy the string into your buffer to use it.. not just 0 terminate it. :)
2016-04-23efreetd - reduce memory usage by using stringshare much moreCarsten Haitzler (Rasterman)
lots of long paths for monitoring file paths for icons etc. are in memory for efreetd. this reduces that memory by sharing them much more. @optimization
2015-12-07Ecore_File: fix merge and simplify logic in ecore_file_file_get() on WindoWSVincent Torri
Summary: Ecore_File: fix merge and simplify logic in ecore_file_file_get() on WindowS Reviewers: cedric, jpeg Reviewed By: jpeg Subscribers: jpeg Differential Revision:
2015-12-01ecore_file: fix ecore_file_file_get() on WindowsVincent Torri
@fix Signed-off-by: Cedric BAIL <>
2015-11-02ecore_file: Fix ecore_file_file_get function on Windows.Jaehyun Cho
On Windows, both backslash and slash can be used as file path separators. Therefore, it is fixed to consider backslash as a file path separator as well on Windows. @fix
2015-10-12ecore_file: remove whitespacesVincent Torri
Signed-off-by: Cedric BAIL <>
2015-10-12ecore_file: fix ecore_file management function on WindowsVincent Torri
On windows, stat() returns -1 if a path is finished with a \ or /, so replace all stat() calls with a function which removes the trailing slash or backslash on Windows At this stage the code duplicate many code path for avoiding potential borkage on Unix system. During 1.17 release cycle, it would be nice to refactor this piece. @fix Signed-off-by: Cedric BAIL <>
2015-07-03Ecore_File: use ecore_file_mkdir()Vincent Torri
2015-07-03Ecore_File: better implementation of ecore_file_mkdir()Vincent Torri
2015-07-03Ecore_File: improve comment of ecore_file_mkdir()Vincent Torri
2015-05-14ecore_file: use portable environment lookup.Cedric BAIL
2015-05-07ecore: remove the need to order the header correctly for Windows.Cedric BAIL
2015-04-23ecore-file: use hash list for inotify monitor trackingMike Blumenkrantz
inotify reuses watches for multiple instances on the same file, so keeping a multimap here is necessary to avoid hash collision fix T2360
2015-04-17ecore_file: less confusing documentation of ecore_file_download APIkabeer khan
Summary: Signed-off-by: kabeer khan <> Reviewers: cedric Subscribers: cedric Differential Revision: Signed-off-by: Cedric BAIL <>
2015-04-09ecore-file: use hash for finding monitorsMike Blumenkrantz
this should hugely improve the speed of file monitor event processing; in my test case, 800,000+ monitors were present and the application was entirely unable to process them
2015-04-01ecore_file - fix nasty memory issues in ecore_file_app_exe_get()Carsten Haitzler (Rasterman)
valgrind was most unhappy with ecore_file_app_exe_get(). like: ==8331== Invalid write of size 1 ==8331== at 0x68DE90A: ecore_file_app_exe_get (ecore_file.c:994) ==8331== Address 0x1348e58f is 0 bytes after a block of size 31 alloc'd ==8331== at 0x4C28C20: malloc (vg_replace_malloc.c:296) ==8331== Invalid write of size 1 ==8331== at 0x68DE948: ecore_file_app_exe_get (ecore_file.c:1000) ==8331== Address 0x1348e599 is 10 bytes after a block of size 31 alloc'd ==8331== at 0x4C28C20: malloc (vg_replace_malloc.c:296) etc. etc. - so i rewrote it cleanly using strbuf to save code and effort. cleaner now and ACTUALLY works correctly... and no valgrind complaints. @fix
2014-11-21ecore_file : Changed documentation of ecore_file_mksubdirskabeer khan
Summary: Corrected documentation of ecore_file_mksubdirs by replacing dirs with subdirs Signed-off-by: kabeer khan <> Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric Differential Revision:
2014-11-04Ecore File: Corrected documentation of ecore_file_monitor_add APIkabeer khan
Summary: Added condition that if given path does not exist it returns NULL @fix Signed-off-by: kabeer khan <> Reviewers: englebass, devilhorns Reviewed By: devilhorns Subscribers: cedric Differential Revision:
2014-11-03Ecore File: Corrected documentation of ecore_file_monitor_add APIkabeer khan
Summary: Existing doc specifies that ecore_file_monitor_add returns NULL if path is not file. Removed this line as it works if path is either file or directory. Signed-off-by: kabeer khan <> Reviewers: devilhorns, englebass Subscribers: cedric Differential Revision:
2014-11-03ecore-file: Fix formattingChris Michael
Summary: No functional changes, just formatting Signed-off-by: Chris Michael <>
2014-11-03ecore-file: Fix formatting.Chris Michael
Summary: No functional changes, just formatting Signed-off-by: Chris Michael <>
2014-10-28inotify: Fix safety after read in 3 placesJean-Philippe Andre
Fixes Coverity issues: - CID 1039565 - CID 1039566
2014-10-20ecore_file: remove ecore_file_ls_iterator function from header.Pierre Le Magourou
It has no implementation in the ecore_file.c file. This has been forgotten in commit d4059c7 when moving this function to Eina library.
2014-08-08ecore_file: Check return value of chmod()Stefan Schmidt
Handle the error case here if chmod() fails. CID: 1039696
2014-06-27ecore_file: this parameter is indeed not used.Cedric BAIL
2014-01-09Revert "fix allocator sizeof operand mismatch reported by clang"Carsten Haitzler (Rasterman)
This reverts commit 955cc579d4d0b52cc71e309c35d1850424dc3cca. why? wrong. no. and it breaks actual execution/functioning. segv land
2014-01-09fix allocator sizeof operand mismatch reported by clangJihoon Kim
2013-12-26efl: Unified eina critical manro to CRI.Daniel Juyung Seo
Being annoyed by different types of eina critical macros - CRI, CRIT, CRITICAL -, I concluded to unify them to one. Discussed on IRC and finally, CRI was chosen to meet the consistency with other macros - ERR, WRN, INF, DBG - in terms of the number of characters. If there is any missing bits, please let me know.
2013-12-23ecore: remove dead freeSebastian Dransfeld
Since we now free exe on goto restart, exe will always be NULL. CID 1139955
2013-12-15ecore-file - fix mem leak in ecore_file_app_exe_get() on restartCarsten Haitzler (Rasterman)
this actually fixes the issue. coverity did point it out but i fixed it incorrectly. since it was still there in the scan i now fixed it properly. fixes CID 1039279
2013-12-13ecore_file - finding exe path - if HOME is not set a leak could happenCarsten Haitzler (Rasterman)
this fixes CID 1039279
2013-12-07ecore_x: Fix buffer overrunSebastian Dransfeld
Use strncpy to prevent buffer overrun on buf, and '\0' terminate. Fixes CID 1039584
2013-12-02fix unchecked return value of stat in ecore_file_mvJihoon Kim
stat() function may fail and return an error code This fixes CID 1039697
2013-11-30ecore/ecore_file: NULL-check for input parameterOleksandr Shcherbina
Add check by NULL for input parameter 'path' in method ecore_file_mkpath Reviewers: seoz, Hermet CC: cedric Differential Revision: