path: root/src/lib/ecore_input_evas (follow)
AgeCommit message (Collapse)Author
2017-03-13Revert "ecore-evas reduce modifier modification on every event to cut cpu"Cedric BAIL
This reverts commit 3a9d54085b8751cbd0bca4698a8ff702d9bdc7b4. I got crash and a lot of valgrind warning with this patch. All in all, I think we can just wait for next release and do a proper cleanup of our API to not rely on strings at all. For references this is the first valgrind warning I get (Not going to past the 100 following one) : ==11860== Invalid write of size 4 ==11860== at 0xB10DDD1: _ecore_event_evas_modifier_lock_update (ecore_input_evas.c:432) ==11860== by 0xB10E3DD: ecore_event_evas_mouse_move (ecore_input_evas.c:725) ==11860== by 0x5D5115D: _ecore_call_handler_cb (ecore_private.h:317) ==11860== by 0x5D5115D: _ecore_event_call (ecore_events.c:518) ==11860== by 0x5D5CC47: _ecore_main_loop_iterate_internal (ecore_main.c:2381) ==11860== by 0x5D5D42E: ecore_main_loop_begin (ecore_main.c:1289) ==11860== by 0x5D5D490: _efl_loop_begin (ecore_main.c:2831) ==11860== by 0x5D59555: efl_loop_begin (efl_loop.eo.c:32) ==11860== by 0x14F275: main (test.c:1188) ==11860== Address 0x19a36828 is 7 bytes after a block of size 1 alloc'd ==11860== at 0x4C2AACE: malloc (in /usr/lib/valgrind/ ==11860== by 0x4C2CC81: realloc (in /usr/lib/valgrind/ ==11860== by 0xB10DDA8: _ecore_event_evas_modifier_lock_update (ecore_input_evas.c:425) ==11860== by 0xB10E3DD: ecore_event_evas_mouse_move (ecore_input_evas.c:725) ==11860== by 0x5D5115D: _ecore_call_handler_cb (ecore_private.h:317) ==11860== by 0x5D5115D: _ecore_event_call (ecore_events.c:518) ==11860== by 0x5D5CC47: _ecore_main_loop_iterate_internal (ecore_main.c:2381) ==11860== by 0x5D5D42E: ecore_main_loop_begin (ecore_main.c:1289) ==11860== by 0x5D5D490: _efl_loop_begin (ecore_main.c:2831) ==11860== by 0x5D59555: efl_loop_begin (efl_loop.eo.c:32) ==11860== by 0x14F275: main (test.c:1188)
2017-03-13ecore-evas reduce modifier modification on every event to cut cpuCarsten Haitzler (Rasterman)
this only modifiers modifiers if the modifier mask changed. it stores it per seat and matches up before deciding to actually modifier the modifiers. this SHOULD fix T5252 @fix
2017-03-09Revert "ecore_input - dont try update modifiers and locks on mouse events"Derek Foreman
This reverts commit f654714d75afdd07ad851bf278a39ddf8de6caba. Modifiers do influence mouse events, though a mouse input can't change them... This commit broke modifer+drag on windows in E, so I'm reverting it.
2017-03-09ecore_input - dont try update modifiers and locks on mouse eventsCarsten Haitzler (Rasterman)
mouse events have nothing to do with modifiers or locks, so dont try modify them on mouse events. a total waste of cpu and time. this should also fix T5251
2017-01-06eina: rename EINA_{FLT,DBL}_CMP to EINA_{FLT,DBL}_EQ.Cedric BAIL
2016-12-20ecore_input_evas: fix float comparison warning.Cedric BAIL
2016-12-02Ecore Input Evas: Add ecore_event_evas_seat_modifier_lock_update().Guilherme Iscaro
This function will set the modifiers/lock per seat in Evas. Some places will still use ecore_event_evas_modifier_lock_update(), since multi-seat is not supported.
2016-12-02Ecore Input Evas: Ecore_Input_Last should contain the Evas device.Guilherme Iscaro
This struct should contain the Evas device that originated the event, otherwise events from different devices may mix up and lead to undifined behaviour.
2016-08-09ecore_input_evas: Enable cancel events by defaultJean-Philippe Andre
After my input event changes, the propagation path has been altered from: ecore_x -> evas_event to: ecore_x -> ecore_input_evas -> evas_event But ecore_input_evas was ignoring cancel events by default. There should be no good reason to disable cancel events anymore, according to @jypark. Also, this fixes an actual bug :) Fixes T4301
2016-06-02ecore_evas: Fix mouse inputsJean-Philippe Andre
Yup, I broke everything again. This time, mouse move inputs would not move the cursor, since I was bypassing the regular _ecore_evas_mouse_xxx callbacks. Fixes T3766
2016-06-02Evas: Send key events through eo callbacksJean-Philippe Andre
2016-05-31evas: send eo pointer events on mouse moveJean-Philippe Andre
This is still VERY experimental and not fully done yet. All other pointer events need to be sent as well. The legacy event system is used as a transportation mechanism, as it is too hard to change the logic. This only adds an extra eo event in case of move. Obviously for performance we might want to listen to callback_add,del but that's an optimization for later. The whole point of sending those pointer events is to carry more information than can be sent over legacy evas events, and unify the events in a common format.
2016-05-31ecore_input: Pass all events through direct cb firstJean-Philippe Andre
Since the direct input event callback returns true if the event has been processed, we can easily support legacy and progressively implement full support for eo input events.
2016-05-31ecore_evas: Add private direct callback for ecoreJean-Philippe Andre
All ecore_input_evas events should be passed through ecore_evas in order to avoid any information loss between ecore and evas. This is a private API.
2015-07-29ecore_evas_input: add value to enable mouse button cancel featureJi-Youn Park
mike reported this feature break the behavior in E19, but I have trouble to reproduce it. so I first add value to enable this feature and after that,
2015-07-07ecore-input-evas: fix canvas mouse event dispatchMike Blumenkrantz
this was broken in 5cb6cdbc5e1a13ea0262e155983b494e6519abde such that when multiple sources produce mouse events using the same device, these events are marshalled as though they were from the same canvas. the result is that eventing is wrong on at least one of the canvases, and spurious mouse-up events are triggered before every mouse down fix T2509
2015-06-30ecore: Fix typo in since tag.Amitesh Singh
2015-06-29Revert "evas: add keysym member to key event structs"Mike Blumenkrantz
This reverts commit b7c89d23252d34c1d9efecc27dc835aa8df3c50d. this was audited and found to be impractical due to portability concerns
2015-06-18ecore-input-evas: Fix Coverity CID1306803 (logically dead code)Chris Michael
Summary: This cleans up the _ecore_event_evas_mouse_button function. Coverity was reporting that the state tests in the 'if' function could not be be reached due to eel variable being null. This moves the if (!eel) check to run before the state tests. @fix Signed-off-by: Chris Michael <>
2015-06-17ecore_input_evas: remove tab and unusable codeJi-Youn Park
remove tab and code which is not used
2015-06-16 Ecore_input: Add "ECORE_EVENT_MOUSE_BUTTON_CANCEL" eventJi-Youn Park
If ecore get the mouse cancel event(ex: display off, or window stack change) from below, we need to deal with. Currently, evas also generates up event using evas_event_feed_mouse_cancel function when window hide is called. if cancel event occurs, ecore also call evas_event_mouse_feed_cancel like window hide situation. cancel event means all button or touch event should be canceled, but in the future, if we need to deal each cancel event according to touch point, we need to add api like evas_event_feed_multi_cancel @feature
2015-05-20evas: add keysym member to key event structsMike Blumenkrantz
2015-05-07ecore: remove the need to order the header correctly for Windows.Cedric BAIL
2015-01-27ecore_input_evas: Add since tage for new ecore_event_evas_axis_update() APIStefan Schmidt
2014-11-25axis code ... warning --Carsten Haitzler (Rasterman)
2014-11-25Expose device (e.g. pen) axis information to applicationsJason Gerecke
Summary: This patch set adds the necessary code to expose device axis state to applications. This was primarily written with graphics tablets in mind, which -- in addition to acting like a mouse -- also provide information about pen pressure, tilt, etc. Other devices could potentially benefit from this API as well: touchscreens, joysticks, knob controllers, "spaceballs", etc. Whenever an update to the device state is recieved, an "Axis update" event is synthesized. This event contains the updated information, typically scaled and normalized to a particular logical range (e.g. zero to one for pressure, -pi to pi radians for angles, etc.). Information about the tool which generated the event is also stored so that applications can disambiguate events from multiple devices (or in the case of multitouch screens, individual fingers). This API is only wired up for use with X11 at the moment. Support for other backends (e.g. Wayland) should be easy to add for those familiar them. **Note**: The following is a list of changes from the "v2" patches originally sent to the mailinglist //Define and implement new Ecore_Event_Axis_Update events// * Harcode axis labels instead of including xserver-properties.h * Use C89-style comments * Use doxygen comments * Update comment text to note axes with unbounded/undefined ranges/units * Create "Ecore_Axis" and "Ecore_Axis_Label" typedefs * Reference typedef'd instead of raw types * Adjust how we count through valuators to support tilt/az * Add support for tilt and azimuth * Tweak memory management in case number of valuators differ * Expand TWIST axis normalization to declared range * Only normalize TWIST axis if resolution == 1 (wacom bug) * Cache label atoms on first use to minimize round-trips //Implement EVAS_CALLBACK_AXIS_UPDATE event and friends// * Update to doxygen comments * Update comment text to note axes with unbounded/undefined ranges/units * Typedef 'Evas_Axis_Label', 'Evas_Axis' * Move typedef for 'Evas_Event_Axis_Update' * Reference typedef'd instead of raw types //Wire the Ecore and Evas implementations of axis update events together// * Expose ecore_event_evas_axis_update in Ecore_Input_Evas.h * Move ecore_event_evas_axis_update to more logical position //DEBUG: Add axis update logging to evas-multi-touch.c// * Removed from patch set //Make evas-multi-touch demo use new axis functionality// * Have pressure adjust rectangle brightness instead of size * Use more available axis data when rendering rectangle (azimuth, tilt, twist) Test Plan: The evas-multi-touch demo was updated to support axis update events. A graphics tablet was then used to verify that the pressure, azimuth, tilt, and twist data was coming through correctly. Reviewers: cedric, raster Subscribers: cedric Differential Revision: Conflicts: src/lib/ecore_input/Ecore_Input.h Carsten Haitzler - ** fixed forward enum typedefs (make things unhappy) ** fixed conflict above ** fixed wrong param type for _evas_canvas_event_feed_axis_update() ** fixed @sinces to be 1.13 ** fixed formatting/indeting ** fixed order of operation reliance in if's with ()'s to be clear ** fixed functions to be static that should have been
2014-04-14Fixed a problem with e wl server that sent invalid key value to wl client.Gwanglim Lee
Summary: This problem occurred due to xkb_keysym_t value of libxkbcommon by e wl server. e wl server should pass keycode from evdev input device on to wl client. In order that e wl server receives valid keycode Ecore_Event_Key should have an extended data member. This patch should be applied with server side patch. @fix Test Plan: run e wl server -> create wl client -> type keys Reviewers: raster, devilhorns, zmike CC: cedric Differential Revision:
2013-12-26efl: Unified eina critical manro to CRI.Daniel Juyung Seo
Being annoyed by different types of eina critical macros - CRI, CRIT, CRITICAL -, I concluded to unify them to one. Discussed on IRC and finally, CRI was chosen to meet the consistency with other macros - ERR, WRN, INF, DBG - in terms of the number of characters. If there is any missing bits, please let me know.
2013-09-02[ecore_input_evas] check the state of last mouse event more properly.Shinwoo Kim
2013-06-20efl: formattingSebastian Dransfeld
2013-05-08Ecore/Evas: Add evas_event_input_multi_down/up().Rafael Antognolli
These events (from multi-touch) also have information about the mouse pointer position, so they must be translated by the framespace too.
2013-05-05Ecore_Input_Evas: Fix ecore_input_evas didn't check the device id ofJiyoun Park
mouse event
2013-05-03ecore/evas events: Use evas_event_input_multi_move to report events.Rafael Antognolli
Same as using evas_event_input_mouse_move.
2013-05-03ecore/evas events: Use evas_event_input_mouse_move to report events.Rafael Antognolli
Ecore_Evas_Input should use this function to report mouse move events. The previous used function should be used to refeed events, or to artificially feed mouse move events to the canvas. Basically every other feed_mouse_move use case that is not an event from the input system.
2013-01-18efl: add infrastructure to handle broken X/driver/touchscreen.Cedric BAIL
SVN revision: 82964
2013-01-16efl/ecore_input: Move file instead. As requested by k-sStefan Schmidt
SVN revision: 82876
2013-01-15move ecore_input_evas out of ecore_input.Gustavo Sverzut Barbieri
we don't need this mess anymore :-P SVN revision: 82836