path: root/src/lib/ecore_wayland/ecore_wl_dnd.c (follow)
AgeCommit message (Collapse)Author
2020-05-04remove arguments of LOGFN in ecre_x and ecore_wayland as the are always the sameVincent Torri
Reviewers: raster Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision:
2020-03-02ecore_wl: removes unreachable statementsWonki Kim
Summary: this patch removes unreachable statements Reviewers: Hermet Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision:
2018-04-20ecore_wl_dnd: correct wrong variable assignmentJongMin Lee
2018-04-05Fix static analysis resultShinwoo Kim
[Dereference after null check] (1) src/lib/ecore/ecore_main.c - _efl_loop_handler_efl_object_finalize checks if pd->loop_data is NULL. After that, _handler_reset > _handler_clear > _ecore_main_fd_handler_del > _ecore_main_fdh_pool_del is directly dereferencing pd->pool_data. - _efl_loop_handler_efl_object_parent_set checks if pd->loop_data as well. Then it calls _handler_reset as well. (2) src/lib/ecore_wayland/ecore_wl_dnd.c - ecore_wl_dnd_selection_set checks if t - result of wl_array_add - is NULL. And it is dereferecing t directly for wl_data_source_offer. (3) src/lib/elementary/efl_ui_dnd.c - Third parameter const char *data could be NULL. In this case strlen dereferences NULL. The data should be non NULL value. I have checked this with Mr. Thiep Ha. (4) src/lib/evas/canvas/evas_object_inform.c - _efl_canvas_object_efl_gfx_stack_stack_below checks if obj->layer is NULL. So it could call evas_object_inform_call_call_restack which is dereferencing obj->layer directly.
2017-10-16ecore_wayland: fix assigned value is never used.Subodh Kumar
Summary: Fix assigned value is never used. @fix Reviewers: cedric Subscribers: shilpasingh, jpeg Differential Revision: Signed-off-by: Cedric BAIL <>
2016-11-18ecore_wayland: fix over writing file descriptor bug for readingTaehyub Kim
Summary: fix over writing file descriptor bug for reading. when we paste data to entry very fast, source->fd is over wrote by latest fd. It cause blocking of read function since the read function use invalid fd. so I make memorizing valid fd and using it in read function. @fix Reviewers: Hermet, jpeg, cedric, devilhorns, ManMower, raster Differential Revision:
2016-04-20ecore-wl(2): add copyright headers (MIT) from westonMike Blumenkrantz
these files were created containing code which was very obviously copied from weston. when copying code, copyright headers must also be copied in order to comply with licenses.
2015-08-13ecore-wl: do not nul terminate dropsMike Blumenkrantz
the application can do this based on mime types. we should not be nul terminating incremental drop data @fix
2015-03-17ecore-wayland: Doublecheck input validityBryce Harrington
Summary: Most of the other ecore-wayland API will return NULL in the (hopefully theoretical) case of bad inputs; this API routine should so similarly for consistency. Reviewers: zmike, cedric Subscribers: cedric Differential Revision:
2015-03-13ecore-wayland: Whitespace cleanupBryce Harrington
Summary: Remove trailing whitespace, convert tabs to spaces as per style guide. Reviewers: zmike Subscribers: cedric Differential Revision:
2015-03-13ecore-wl dnd target interface should accept a NULL mime_typeMike Blumenkrantz
according to protocol, this indicates that the target does not support the drop type
2015-01-13ecore-wayland: Don't set move cursor unless we actually start a dragChris Michael
Summary: We should not be setting a 'move' cursor unless we actually make the call to start a drag @fix Signed-off-by: Chris Michael <>
2014-12-01ecore-wayland: Fixed a request of start_drag with null valueMinJeong Kim
Summary: Fixed a request of start_drag with null value. The request with null value has caused SIGABRT and printed "error marshalling arguments for start_drag (signature ?oo?ou): null value passed for arg 1". @fix Test Plan: 1. Run enlightenment(wayland) 2. Run elementary_test -to FeatureDnd on enlightenment 3. Click any image and try to drag it. (Without this revision, SIGABRT will occur and with this revision, will not.) Reviewers: gwanglim, devilhorns Subscribers: cedric Differential Revision:
2014-09-19Ecore_Wayland: Raise a event when data source target accepts eventsvivek
Summary: 1) Added data source target struct for target event 2) Raise a event when data source target accepts pointer focus or motion events Signed-off-by: vivek <> Reviewers: devilhorns Subscribers: cedric Differential Revision:
2014-09-19Ecore_Wayland: Raise a event when data source cancelledvivek
Summary: 1) Created a event struct for data source cancel event 2) Raise a event when data source is cancelled Signed-off-by: vivek <> Reviewers: devilhorns Subscribers: cedric Differential Revision:
2014-09-08Ecore/Wayland: fix memory issue on exit.Daniel Zaoui
When the application exits, an event cancels the DnD, that invokes the Wayland release of data source but this was not setting an internal pointer to NULL. ecore_wl_shutdown was then trying to use the same Wayland API on the non-set internal pointer (via _ecore_wl_input_del), that was leading to a segmentation fault. This bug never occurred because some bug in Copy&Paste was preventing it to reach this part of code.
2014-07-09ecore-wayland: Do not destroy data_source for selection on client sideMinJeong Kim
Summary: Wayland client doesn't need to destroy previous data_source when client requests for selection_set, because there is "cancelled" event by wayland server to notify clients that the data_source is not used more and has to be destroyed. Before receiving the "cancelled" event, client cannot recognize that it is useless or not. Even if the client wants to create new data_source, wayland server can choose previous data_source rather than new one. Test Plan: 1. Launch weston 2. Launch "elementary_test -to entry5" on weston 3. Try to copy & paste Reviewers: devilhorns CC: cedric, gwanglim Differential Revision:
2013-11-19Remove unused variableChris Michael
Signed-off-by: Chris Michael <>
2013-11-18Partial revert of eb84475503da9f40d6a79eChris Michael
Actually, we don't need to free this data here. Signed-off-by: Chris Michael <>
2013-11-18Check for valid drag type before trying to strdup.Chris Michael
When deleting the drag, free any dupped strings. Hopefully this fixes Phab Ticket T471. Don't know for sure as I cannot reproduce the crash here :/ Signed-off-by: Chris Michael <>
2013-11-07Fix getting the clipboard selection and add missing LOGFN macrosChris Michael
Signed-off-by: Chris Michael <>
2013-05-29Fix potential memleak reported by klockwork.Chris Michael
Signed-off-by: Chris Michael <>
2013-05-28Deprecate old dnd functions (useless, improperly named, etc)Chris Michael
Add shiny new Drag-N-Drop code ;) Signed-off-by: Chris Michael <>
2012-12-02merge: add escape ecore, fix several bugsVincent Torri
SVN revision: 79995