path: root/src/lib/efreet (follow)
AgeCommit message (Collapse)Author
2019-07-28Evil: remove pwd code in Evil and fix compilation failures after the removalVincent Torri
Summary: remove pwd code in Evil Test Plan: compilation Reviewers: zmike, cedric, raster Subscribers: #reviewers, #committers Tags: #efl Differential Revision:
2019-05-20remove Evil.h when not necessary, include evil_private.h when necessaryVincent Torri
Test Plan: compilation Reviewers: zmike, raster, cedric Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Differential Revision:
2019-05-08Evil: remove wrapper around getcwd()Vincent Torri
Summary: getcwd() is declared in direct.h Test Plan: compilation Reviewers: raster, cedric, zmike Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Differential Revision:
2019-03-15efreet: Fix resource leakChristopher Michael
Summary: Coverity reports that we leak 'exec' here when we return. Add IF_FREE(exec) to remove the leak. Fixes Coverity CID1399090 @fix Depends on D8353 Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt Reviewed By: cedric Subscribers: #reviewers, #committers Tags: #efl Differential Revision:
2019-02-01replace hton and ntoh family functions with ones defined in einaVincent Torri
Summary: This fixes especially the execution of edje_cc on Windows Test Plan: execution of edje_cc Reviewers: cedric, raster Subscribers: #reviewers, #committers Tags: #efl Differential Revision:
2019-01-03efreet: Add installation prefix search for XDG_DATA_DIRS.Alastair Poole
Summary: Currently path parsed for XDG_DATA_DIRS is hard-coded to /etc. By using eina_prefix_get and adding to the list of directories efreet should use efreet will use path relative to the EFL installation. Reviewers: #committers, bu5hm4n, cedric, raster, zmike Reviewed By: #committers, zmike Subscribers: zmike, #reviewers Tags: #efl Differential Revision:
2018-12-27meson - fix pc file versions that were missing mirco versionCarsten Haitzler (Rasterman)
2018-11-09efreet menu - fix truncation in snprintf to have bigger buffersCarsten Haitzler (Rasterman)
2018-11-09efreet icon - move func into ifdef as only used if ifdef is trueCarsten Haitzler (Rasterman)
2018-11-09efreet trash - warn - expand buffer to avoid truncation by snprintfCarsten Haitzler (Rasterman)
2018-11-09efreet menu - only build internal cmp func if used in ifdefsCarsten Haitzler (Rasterman)
2018-11-09efreet icon - fix constness of char ptrCarsten Haitzler (Rasterman)
2018-10-02here comes mesonMarcel Hollerbach
a new shiny buildtool that currently completes in the total of ~ 4 min.. 1 min. conf time 2:30 min. build time Where autotools takes: 1:50 min. conf time 3:40 min. build time. meson was taken because it went quite good for enlightenment, and is a traction gaining system that is also used by other mayor projects. Additionally, the DSL that is defined my meson makes the configuration of the builds a lot easier to read. Further informations can be gathered from the README.meson Right now, bindings & windows support are missing. It is highly recommented to use meson 0.48 due to optimizations in meson that reduced the time the meson call would need. Co-authored-by: Mike Blumenkrantz <> Differential Revision: Depends on D7011
2018-09-27efreet_menu: remove unused and unreachable code.Alastair Poole
Coverity doesn't like this unreachable code. This purges efreet_menu of all unused code for the deprecated and non-working menu_async methods. The warnings remain at compile time and run time. Differential Revision:
2018-08-20move efreet xdg envvars to einaMarcel Hollerbach
Summary: The contents of the XDG_ env vars are also usefull for eina subsystems, thus we should init those env vars here. Depends on D6751 Reviewers: zmike, stefan_schmidt, #committers Reviewed By: zmike, #committers Subscribers: #reviewers, cedric, #committers, zmike Tags: #efl Differential Revision:
2018-07-10efreet: include buildsystem.h in efreet_cache.cMike Blumenkrantz
Summary: lib/efreet/efreet_cache.c:121:6: warning: implicit declaration of function 'bs_binary_get' is invalid in C99 [-Wimplicit-function-declaration] Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #committers Tags: #efl Differential Revision:
2018-07-06efreet: simplify and fix efreetd launchMike Blumenkrantz
this previously used an entire eina prefix to determine where to find efreetd, when a simpler approach would have been to just pass the directory where it's being installed this also inhibited running the correct efreetd during in-tree builds and tests, as it was using the install prefix instead of the in-tree wrapper script @fix fix T6713 Differential Revision:
2018-07-03efreet: use correct path when generating error message about stale efreetd ↵Mike Blumenkrantz
socket Summary: using runtime directory in all cases for this is wrong, as ecore-con has a number of fallback codepaths for the case where runtime directory is not set or not valid. by using the same ecore-con function which ecore-ipc uses to generate the socket string, the error message path should always be the same as the path which is used by efreetd extra linkage was required by efreet in order to use ecore-con functions, so the internal lib variable in the build system was modified to provide this @fix fix T7045 Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #committers Tags: #efl Maniphest Tasks: T7045 Differential Revision:
2018-06-22efreet: silent deprecated API build warnings.Alastair Poole
Silent warnings on EFL build. Warn on API "mis-use".
2018-06-15efreet: make efreet_menu_async_get() deprecated.Alastair Poole
Marking deprecated. Func will warn and instantly return on call.
2018-06-14efreet: mark efreet_menu_async_parse() deprecated.Alastair Poole
Marking deprecated, with warnning and instant return. Disabling test code also (for now). Awaiting a fresh implementation. @fix T585
2018-04-27efreet: add method for disabling efreetd connectionMike Blumenkrantz
Summary: some minimal applications, such as test suites, may want to disable this if they are not in need of any of the functionality that is provided @feature Depends on D5965 Reviewers: cedric, stefan_schmidt Reviewed By: cedric Subscribers: stefan_schmidt, cedric Differential Revision:
2018-03-03efreet_xml: make sure we unmap the right pointer.Al Poole
Seems Linux would munmap a lump of coal without failing. Make sure the pointers match. Again bogus unmap not detected by valgrind and not failing. @fix T5949
2018-02-26efreet: fix for windowsMarcel Hollerbach
there is probebly not geteuid / getuid
2018-02-23eina vpath - improve docs and add app.tmp and usr.tmp vpaths tooCarsten Haitzler (Rasterman)
definitely kaes the docs better with lots of sample paths and some indication of what these may map to in real life.
2018-02-22eina: make eina_vpath_interface_user_set an internal API.Cedric Bail
2018-02-22move from efl.vpath to eina_vpathMarcel Hollerbach
The usages from efl.vpath are moved to to eina_vpath
2018-02-02efreet: reset ipc connection after forkMike Blumenkrantz
ensure that existing connection is not reused
2018-01-30Efreet_Mime: update comment about symlinks on WindowsVincent Torri
2018-01-18all: Simplify definition of EAPIVincent Torri
This will help in the transition from Autotools to Meson. This has been tested on Windows for which EFL_XXX_BUILD were first introduced.
2017-12-19efl: Reset ecore event types on initJean-Philippe Andre
This fixes cycles of init/shutdown/init where ecore event types would become invalid, since they are now stored in a dynamic array rather than a statically stored array. The risk here is that if a module of EFL tends to init/shutdown in a "normal" scenario then the event type array will grow in a leaking manner. This could be fixed by resetting those event ID's only when the loop actually exits (EFL_EVENT_DEL on the main loop). I'm not using EFL_EVENT_DEL in this patch as this would add too many event callbacks to the main loop object, which may result in slightly slower event calls to it, affecting the overall performance.
2017-10-16efreet: putting local variable "data" under preprocessor flag "SLOPPY_SPEC" ↵Prince Kumar Dubey
to avoid below warning, if "SLOPPY_SPEC" is disabled. Reviewers: raster, cedric Subscribers: jpeg, rajeshps Differential Revision: Signed-off-by: Cedric BAIL <>
2017-10-06efreet: unsigned int cannot be compared to less than zero.Subodh Kumar
Summary: Wrong camparision with less than zero for unsigned integer. @fix Test Plan: NA Reviewers: raster, cedric Reviewed By: cedric Subscribers: cedric, jpeg Differential Revision: Signed-off-by: Cedric BAIL <>
2017-09-22EFL For WIN32: Replace HAVE_EVIL define with _WIN32Vincent 'vtorri' Torri
2017-07-21efreet - dont complain if INTERNAL x extension hash of desktop is NULLCarsten Haitzler (Rasterman)
asking for an x- field from a desktop shouldnt result in null safety checks IF the x hash is null - it's fine if it's null - that field just doesn't eixst. if other fields were in the x hash but the desired one wasn't it'd not complain, so why complain if there is just no x hash?
2017-07-21efreet - remove noisy debug printfsCarsten Haitzler (Rasterman)
2017-06-16efreet: don't raise ERR on empty file in efreet_xml_new()Mike Blumenkrantz
this is not an error, there is nothing to parse @fix
2017-04-23efreetd - make ability to not connect to efreetd non-criticalCarsten Haitzler (Rasterman)
it's an error we can survive, so make it that level
2017-03-24efreet: Don't prefer the second perfect over the first in desktop_exec_find()Derek Foreman
We test a second match for a perfect match, then stop all further processing, but we never test the first match. This leads to a situation where a system wide .desktop file is given precedence over a local override. Instead, check the first match too. #test-e
2017-03-17efreet: CRI and fail after 10 attempts to connect to efreetdMike Blumenkrantz
if efreetd cannot be connected to, stop infinitely trying to spawn it since this generates crazy cpu load probably this path should also send some cache events so that watchers do not simply idle forever ref T5200
2017-03-09efreet: avoid crash during shutdown due to Ecore_Event queue.Cedric BAIL
2017-02-10vpath usage - simplify to bare minimum to make gustavo happyCarsten Haitzler (Rasterman)
since these are only local path resolves, the do and wait are technically not needed. also remove any other tmp strings and use the vpath string resolving feature to avoid printfs/strjoins/cats etc. etc. as well. also remember to remove old name string from evas shm code - it worked for me. i guess i was lucky and it happened to be NULL thus free was fine.
2017-02-09Revert "vpath usage - simplify to bare minimum to make gustavo happy"Derek Foreman
This reverts commit 2037474dc0fd2b360452f2a15abcbe533b57ca37. This causes the wayland_shm engine to seg fault immediately at startup when attempting to create shm buffers. Please make sure when committing changes to the wayland_shm engine to test on intel, exynos, and at least one platform without dmabuf capabilities - or using the EVAS_WAYLAND_SHM_DISABLE_DMABUF env var to disable dmabuf on intel or exynos. Anyone without the time or hardware to fully test changes to wayland_shm can submit a patch to phabricator and assign it to me so I can fully test it before landing.
2017-02-09vpath usage - simplify to bare minimum to make gustavo happyCarsten Haitzler (Rasterman)
since these are only local path resolves, the do and wait are technically not needed. also remove any other tmp strings and use the vpath string resolving feature to avoid printfs/strjoins/cats etc. etc. as well.
2017-02-09efreet - use vpath to get XDG_RUNTIME_DIR so we have a single implCarsten Haitzler (Rasterman)
having too many places that get XDG_RUNTIME_DIR makes it harder to keep secure etc, so make it a single location for efreet too.
2017-01-06eina: rename EINA_{FLT,DBL}_CMP to EINA_{FLT,DBL}_EQ.Cedric BAIL
2016-12-26efreet cache - handle corner case where efreetd keeps disconnectingCarsten Haitzler (Rasterman)
so an odd one. there is a socket, but nothing is actually listening on it, but clients keep spinning launching efreetd's because the launch, connect, then get a disconnect and try again immediately keeping things spinning heavily, so add a delay of 0.5 sec before launchnig another efreetd if the launch + connect fails and gets a disconnect within 0.5 sec ... so give up for 0.5 sec before trying again to avoid a runaway system. @fix
2016-12-20efreet: remove float comparison warningsChris Michael
Signed-off-by: Chris Michael <>
2016-11-14efreet: make mime type evaluation way faster by using mmap.Cedric BAIL
2016-09-25efreet - fix command generation by fixing string buffer expansionCarsten Haitzler (Rasterman)
so by chance i discovered efreet is doing bad things(tm) when expanding/appending to string buffers to generate commands based off desktop files. the string append basically was buggy, so fixed it by making it a lot simpler and more obvious and now reliable. @fix