summaryrefslogtreecommitdiff
path: root/src/lib/eina (follow)
AgeCommit message (Collapse)Author
2018-09-21eina: Improve doxygen formatting for eina_debug.hBryce Harrington
Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D7098
2018-09-21eina: Grammar improvementsBryce Harrington
Reviewers: segfaultxavi Reviewed By: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D7058
2018-09-21eina_vpath_vdg: free locally allocated memory before returnShinwoo Kim
The eina_vpath_resolve could allocate memory and return it. But the eina_xdg_env_init does not release it. *Detected by static analysis with the Coverity Differential Revision: https://phab.enlightenment.org/D7066
2018-09-21eina_vpath: fix the memory leakTaehyub Kim
Summary: fix the memory leak @fix Reviewers: Jaehyun_Cho, bu5hm4n Reviewed By: Jaehyun_Cho Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D7081
2018-09-19eina: Improve explanation of read-only binbuf'sBryce Harrington
Reviewers: Hermet Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D7057
2018-09-19eina: Refer to sin/cos as sine/cosine instead of sinus/cosinusBryce Harrington
Summary: Sinus and cosinus are just the Latin words for sine and cosine, but we should use the English versions to avoid any possible confusion. Reviewers: Hermet Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D7059
2018-09-19eina promise: Fix example error message in docsBryce Harrington
Reviewers: Hermet Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D7060
2018-09-19eina cow: Cleanup doxygen syntaxBryce Harrington
Summary: The "be careful" advice seems a bit odd in api docs, better to just flag them with doxygen @note's. Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D7061
2018-09-08eina: Add doxygen in/out tags for remaining APIsBryce Harrington
Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D7007
2018-08-31docs: Fix typos in API reference doc and comments.Yeongjong Lee
Reviewers: Hermet, segfaultxavi Reviewed By: Hermet, segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D6948
2018-08-24eina: find a real path of dynamic libraryWonki Kim
In general case, user library path is specifed as /usr/lib/, however, if the user library path is specified as /lib/ which is a symbolic link to /usr/lib/, current eina_prefix_new logic will print warning messages. (actually the logic finds a /usr/lib/ path once a fallback logic runs) This patch modifies the logic to find a proper path of lib path even if it is specified as symlink. Differential Revision: https://phab.enlightenment.org/D6869
2018-08-20eina_debug: switch to vpathMarcel Hollerbach
Summary: eina debug was using the xdg runtime dir in a wrong manner. Since the directory should be only used by the user, and the directory should be be subject of any other usage. Additionally, apps tend to create files like: $XDG_RUNTIME_DIR/foo.bar which is probebly not what you want in $HOME. ref T7107 Depends on D6747 Reviewers: zmike, stefan_schmidt, #committers Reviewed By: zmike, #committers Subscribers: #reviewers, cedric, #committers, zmike Tags: #efl Maniphest Tasks: T7107 Differential Revision: https://phab.enlightenment.org/D6748
2018-08-20move efreet xdg envvars to einaMarcel Hollerbach
Summary: The contents of the XDG_ env vars are also usefull for eina subsystems, thus we should init those env vars here. Depends on D6751 Reviewers: zmike, stefan_schmidt, #committers Reviewed By: zmike, #committers Subscribers: #reviewers, cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6744
2018-08-20eina_vpath: introduce eina_vpath in style of snprintfMarcel Hollerbach
Summary: this can be usefull for later regactor usages. Depends on D6742 Reviewers: zmike, stefan_schmidt, #committers Reviewed By: zmike, #committers Subscribers: #reviewers, segfaultxavi, cedric, #committers, zmike Tags: PHID-PROJ-55rnlag4d454jfmlmuhu Differential Revision: https://phab.enlightenment.org/D6743
2018-08-20eina_vpath: fix homedirectory fetchingMarcel Hollerbach
Summary: the fetching of the homedirectorty did not work. pw_dir was never prepended. Additionally you would get a silent NULL string back if the system does not support HAVE_GETPWENT. ref T7107 Depends on D6737 Reviewers: zmike Reviewed By: zmike Subscribers: #reviewers, raster, vtorri, cedric, #committers, zmike Tags: #efl Maniphest Tasks: T7107 Differential Revision: https://phab.enlightenment.org/D6742
2018-08-17eina_file: check copied using copiedShinwoo Kim
Summary: From (1) "the following commit" message, the changed condition in this patch should check if the virtualized file is copied or not. In eina_file_virtualize head_padded = 16 * ((sizeof(Eina_File) + slen + 15) / 16); file->global_map = ((char *)file) + head_padded; In eina_file_dup file->global_map != (void*)(file->filename + strlen(file->filename) + 1) Because of this discord condition makes eina_file_dup copies always. (1) This is "the following commit": commit 4766316935589b6191e047ad697ab10ae2027a43 Author: Cedric Bail <cedric@osg.samsung.com> Date: Wed Mar 8 10:13:36 2017 -0800 eina: force copy of not copied virtualized file while doing an eina_file_dup. The other way around is pretty much impossible as you don't know who does an eina_file_dup and for how long they keep there reference. T5234 Reviewers: zmike, Hermet Reviewed By: zmike Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D6857
2018-08-15eina: Add doxygen in/out tags for safepointer, safety_checks, slice, etc.Bryce Harrington
Reviewers: netstar Reviewed By: netstar Subscribers: netstar, cedric, #reviewers, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6833
2018-08-14eina_vpath: specilice the eina_vpath headersMarcel Hollerbach
Summary: For now its beta, and the since tag is added. Reviewers: zmike Reviewed By: zmike Subscribers: #reviewers, kimcinoo, Hermet, cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6751
2018-08-08eina: Add doxygen in/out tags for rectangleBryce Harrington
Reviewers: Hermet Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6776
2018-07-31eina: Add doxygen in/out tags for value and value_utilBryce Harrington
Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6713
2018-07-31eina: Add doxygen in/out tags for rbtreeBryce Harrington
Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6709
2018-07-31eina: Add doxygen in/out tags for quaternionBryce Harrington
Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6708
2018-07-31eina: Add doxygen in/out tags for promiseBryce Harrington
Summary: Also, add some missing param docs, and fix some incorrect ones. Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6698
2018-07-28eina: Add doxygen in/out tags for mmap and moduleBryce Harrington
Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6691
2018-07-27eina: Add doxygen in/out tags for logBryce Harrington
Subscribers: cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6690
2018-07-27eina: Add doxygen in/out tags for lalloc and listBryce Harrington
Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6688
2018-07-26eina: Add doxygen in/out tags for inlist and iteratorBryce Harrington
Reviewers: segfaultxavi Subscribers: segfaultxavi, cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6686
2018-07-24eina: Add doxygen in/out tags for evlog, file, fp, freeqBryce Harrington
Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6673
2018-07-20eina: Add doxygen in/out tags for cow, cpu, and debugBryce Harrington
Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6642
2018-07-19eina: Fix doxygen in/out tags for eina_bezierBryce Harrington
Reviewers: Hermet Reviewed By: Hermet Subscribers: cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6630
2018-07-18eina: Add doxygen in/out tagsBryce Harrington
Reviewers: Hermet Reviewed By: Hermet Subscribers: cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6624
2018-07-16Eina binbuf: add explicit null-check before magic-checkDaniel Hirt
Summary: Using `--disable-magic-debug` defines EINA_MAGIC_CHECK to always evaluate to `1`. Eina_Binbuf's null-check relied solely on the EINA_MAGIC_CHECK, and failed to pick up on the cases where `buf` was passed as NULL. This has led to a segfault when a NULL `buf` was passed in the test suite (see referenced ticket). This fix adds an explicit NULL check. Fixes https://phab.enlightenment.org/T7147 Reviewers: zmike Reviewed By: zmike Subscribers: cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6592
2018-07-13eina: Add doxygen in/out tags for strbuf's and ustrbuf's parametersBryce Harrington
Reviewers: devilhorns, Hermet Reviewed By: Hermet Subscribers: cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6586
2018-07-12eina: Spelling fixesBryce Harrington
Reviewers: devilhorns, Hermet Reviewed By: Hermet Subscribers: cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6570
2018-07-12eina: Add doxygen in/out tags for binbuf's parametersBryce Harrington
Reviewers: devilhorns, Hermet Reviewed By: Hermet Subscribers: cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6571
2018-07-10eina: Improve documentation for binbuf/strbuf/ustrbufBryce Harrington
Summary: These three classes have essentially the same API, just different underlying data types. This patch seeks to improve the docs for all three while retaining or improving the consistency between them. Several functions had completely incorrect documentation (looks like cut-and-paste mistakes), others had missing or incorrectly named parameter documentation, typographical errors, or other similar issues. This also cleans up a lot of spelling and grammar errors, defines return values as part of @return, and reformats/revises doxygen code for consistency. There are no changes to code, except some whitespace cleanup. Reviewers: devilhorns Subscribers: cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6544
2018-07-09eina: remove no longer used function _eina_thread_queue_msg_block_real_freeStefan Schmidt
Summary: It seems this function is no longer used since some rework. Clean it up. lib/eina/eina_thread_queue.c:127:1: warning: ‘_eina_thread_queue_msg_block_real_free’ defined but not used [-Wunused-function] Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6537
2018-07-04eina: Improve eina_binbuf function documentationBryce Harrington
Summary: Define return values as part of @return. Cleanup grammar. Reviewers: devilhorns Subscribers: cedric, #committers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6503
2018-07-03eina: Improve eina_benchmark function documentationBryce Harrington
Summary: Define return values as part of @return. Clarify that the returned list of files are gnuplot filenames specifically. Cleanup grammar throughout. Reviewers: zmike, devilhorns Reviewed By: devilhorns Subscribers: cedric, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D6502
2018-07-03eina/debug: remove global lock for session list accessMike Blumenkrantz
this list is now only accessed from the main thread so there's no reason to have a lock for it
2018-07-03eina/debug: rework session thread destruction to avoid deadlock on shutdownMike Blumenkrantz
when debugging was active, this would frequently result in the monitor thread blocking in a read() call for a fd which had already been closed by the main thread. the main thread would be waiting for the monitor thread to fail its read() and destroy itself, but the read() would never end without an interrupt this reworks the monitor thread destruction to stop relying on the thread to remove its session from the session list and instead only access the list from the main thread, allowing sessions to always be immediately destroyed fix T7103
2018-06-27eina debug - fix setuid process shutdown by initting fully except connCarsten Haitzler (Rasterman)
init eina debug fully except for the debug daemon connection that the setuid check was meant to skip. this fixes T7055
2018-06-26Revert "eina: provide full string length to vsnprintf to allow for null ↵Xavi Artigas
character" Summary: This reverts commit e0f8e65d2044d49df4fd6355e7835a5f01d854e7 which changed the behavior of eina_stringshare_nprintf() and was not really needed to fix T6903. Reviewers: zmike, Jaehyun_Cho, devilhorns Reviewed By: zmike Subscribers: cedric, #committers Tags: #efl Maniphest Tasks: T6903 Differential Revision: https://phab.enlightenment.org/D6431
2018-06-25eina/threadqueue: use mempool_del for hash free functionMike Blumenkrantz
Summary: I typod this in 14ae3e3dec7866e74f2990dca417eac44da41058 and when using mempools other than chained, this probably caused all apps to crash on shutdown Reviewers: ManMower, devilhorns Reviewed By: ManMower Subscribers: cedric, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D6428
2018-06-25eina/lock: add errno wrapping for backtrace() calls in thread debug blocksMike Blumenkrantz
Summary: somehow backtrace() is able to generate EINVAL in certain cases even though this is not documented anywhere. these irrelevant errors should not be noticed by users of the api during debugging, as this can cause some tests/apps to randomly fail without explanation @fix Reviewers: ManMower, devilhorns Reviewed By: ManMower Subscribers: cedric, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D6377
2018-06-25eina/debug_cpu: rework thread usageMike Blumenkrantz
Summary: this changes the explicit pthread usage (and reimplementation of eina_thread_create) to just use eina function calls. it also causes the thread to start and stop when profiling is enabled and resolves some possible errors which could occur after a fork or when trying to compile under windows pthread usage: this code appears to have been 100% copied from eina_thread.c, and it isn't clear to me why existing eina_thread api was not used. this has no functional benefit, but it makes the code more readable thread lifetime: there is no need to have a thread running at all times for a feature which will be rarely used and which must be explicitly enabled by the user windows: this file previously generated a lot of compiler warnings from unused functions and variables since nothing here is available under windows. the entire file is now a giant #ifndef _WIN32 to avoid any compile warnings or unexpected runtime behavior fix T7055 Depends on D6371 Reviewers: ManMower, vtorri, devilhorns Reviewed By: ManMower Subscribers: cedric, #committers Tags: #efl Maniphest Tasks: T7055 Differential Revision: https://phab.enlightenment.org/D6372
2018-06-25eina/debug: replace some explicit pthread_t usage with Eina_ThreadMike Blumenkrantz
no functional changes Differential Revision: https://phab.enlightenment.org/D6371
2018-06-25eina/lock: rework meaning of EINA_DEBUG_THREADS variableMike Blumenkrantz
Summary: previously this used to mean 'the number of ms that a lock can wait for until abort() is called once the lock is acquired' and it was useful when trying to find contention issues with locks unfortunately this required a bit of reading into the code to determine, and it made the common case of setting values to 1 fail in some cases, as this is a very short amount of time. also the documentation explicitly gives '1' as an example setting for this variable, which will cause immediate abort() in most cases when debugging was enabled since things are much slower this variable now is the number of usec that a lock can wait for before abort() is called, and the lowest value that will be checked for abort()ing is 100, meaning that '1' is valid again Depends on D6375 Reviewers: ManMower, devilhorns Reviewed By: ManMower Subscribers: cedric, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D6376
2018-06-25eina/lock: when debug threads are enabled, always call trylock in lock functionMike Blumenkrantz
Summary: when debugging thread issues, it's not actually helpful to immediately deadlock--this defeats any attempt at debugging. instead, call trylock first in order to detect a possible deadlock and then throw an error which can be caught by the user Depends on D6374 Reviewers: ManMower, devilhorns Reviewed By: devilhorns Subscribers: cedric, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D6375
2018-06-25eina/lock: reorder inline posix lock functionsMike Blumenkrantz
Summary: no functional changes Reviewers: ManMower, devilhorns Reviewed By: devilhorns Subscribers: cedric, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D6374