aboutsummaryrefslogtreecommitdiffstats
path: root/src/lib/elementary (follow)
Commit message (Collapse)AuthorAgeFilesLines
* elementary widget: fix a wrong disabled behavior.Hermet Park2016-08-021-6/+14
| | | | | | | | | | | | | | | | | | | | | | | | | This is a corner case bug I spontaneously found. * Scenario. A. Disable A widget. B. Add a child B widget to A. C. Now B Widget theme will be followed to A that is performed by elm_widget_theme_apply() D. This elm_widget_theme_apply() calls elm_widget_disabled_set() (originally.) E. Now B widget will be logically disabled. D. Let's enable A widget again. E. After going through widget disabled sequence, elm_widget_disabled_eval() will be called in the last F. In this function, A widget tries to enable its children. But B widget won't be enabled because its logically disabled! Acutally, nowhere widget change children's disabled states logically, but it propagates its state to children within volatile way so that A widget perfectly keeps the disabled/enabled state with its children and recover the children's enable/disable state once their relationship is cut off. @fix
* elm scroller accel was broken by default confgis setting it to 0. fixCarsten Haitzler (Rasterman)2016-08-022-1/+6
| | | | | | | | | | | now set default wheel scroll accel to 7 as epr the confgi upgrade code and also improve the acceleration to "rely on itself" and feedback loop. this is so much better now i can scroll through things in a whisk with the wheel. fixes T4263 @fix
* autotools: since it has been broken for some times and nobody noticed, let's ↵Cedric BAIL2016-08-011-657/+0
| | | | remove per directory support.
* elementary: remove *.eo.h files from includesub_HEADERSRomain Naour2016-08-011-2/+1
| | | | | | | | | | | | | | | | | | | | | | Otherwise *.eo.h files will be installed twice, so it can break a parallel install on fast machines, whereby two make jobs may run concurently, trying to install the same files. With elementary 1.17.1: /usr/bin/install -c -m 644 elm_sys_notify.eo.h /usr/bin/install -c -m 644 elm_sys_notify.eo.h usr/bin/install: cannot create regular file 'elm_sys_notify.eo.h': File exists Fixed in Buildroot: https://git.busybox.net/buildroot/commit/?id=bba82cbfe4caaa01366fc74fb3b6f4c41587a28b While applying the fix on latest master (1.18.0-beta1), the only remaining *.eo.h file is efl_ui_text.eo.h. Fixes: http://autobuild.buildroot.net/results/7e9/7e9caffe442dcf40ee41da56fd3f55ffedf3a291 Signed-off-by: Romain Naour <romain.naour@gmail.com>
* scrollable: Avoid useless connect to animatorJean-Philippe Andre2016-08-011-0/+2
| | | | | If scrolling Y no need to register X animators. And vice versa. It's a minor optimization.
* elm: object_item: add guards to include eo and legacy header only when allowedStefan Schmidt2016-07-291-0/+4
| | | | | Make sure the eo and legacy headers are only included when the matching defines are enabled.
* elm: sys_notify: add guards to inlcude eo and legacy header only when allowedStefan Schmidt2016-07-291-1/+5
| | | | | Make sure the eo and legacy headers arte onl yincluded when the matching defines are enabled.
* multibuttonentry: Fix wrong definitions.Woochan Lee2016-07-292-2/+1
| | | | | | | | | | | | | | | | | | Summary: There is no "ELM_MULTIBUTTONENTRY_EVENT_CHANGED" Because of this, MBE's Internal entry did not get a changed callback. And MBE does not have changed smart callback. Those things made by someone during EO interface working i think. Test Plan: elementary_test Reviewers: Hermet, cedric, jpeg Subscribers: cedric, jpeg Differential Revision: https://phab.enlightenment.org/D4195
* efl - elm genlist - clean up sanghyeon's patch to be less codeCarsten Haitzler (Rasterman)2016-07-291-8/+3
| | | | | use if not while, no first, and timing checkis already done at end so remove from if/while. cleaner now.
* fix warnings in sanhyeons's patch/fixCarsten Haitzler (Rasterman)2016-07-291-1/+1
|
* [CONFIG] call elm_rescale() only when scale value is changedJonghee Choi2016-07-291-1/+5
| | | | | | | | | | Summary: it doesn't need to call elm_rescale() in _config_flush_get() when the scale value is not changed. Reviewers: jaehwan, cedric, raster Subscribers: minkyu Differential Revision: https://phab.enlightenment.org/D4186
* genlist: fix memory-leak in filter queue and refactoring queue iterationSangHyeon Lee2016-07-291-8/+12
| | | | | | | | | | | | | | | | | Summary: There are critical memory-leak in filter queue process. It looks typo so I fix it and refactoring queue iteration logic to spend less time in for and while loop. Test Plan: Tested by filter elementary test Reviewers: shashank0990 Reviewed By: shashank0990 Subscribers: raster, cedric, jpeg Differential Revision: https://phab.enlightenment.org/D4170
* entry: allow force recalc on "size,eval" "elm" signalAmitesh Singh2016-07-281-0/+17
| | | | | | | | | | | | | | | | | Summary: In some use cases, font (style) of elm.text in elm entry is changed on focus and unfocus. user must send "size,eval",elm signal to entry to force recalc, but this was not happening. This patch fixes that issue. fixes T4233 Reviewers: tasn, herdsman, raster Subscribers: cedric, seoz, jpeg Maniphest Tasks: T4233 Differential Revision: https://phab.enlightenment.org/D4196
* win: Fix evas framespace under XJean-Philippe Andre2016-07-281-0/+1
| | | | | | | Mouse inputs would not work if the window is rotated, because the framespace was invalid. Fixes T4132
* elementary: fix legacy path set/get for Fileselector specializationsVitor Sousa2016-07-274-2/+57
| | | | | | | | | | | | | | Fix legacy functions elm_fileselector_path_get and elm_fileselector_path_set. Make these functions call the correct function when called with a specialization of Elm.Fileselector (instead of the base class function). Create internal versions of path set/get functions to avoid warnings about deprecated function calls. Fix T4198 @fix
* elementary: Reduce variable usageChris Michael2016-07-271-2/+2
| | | | | | | As we don't use the framespace x, y here then there is really no need to have them. Signed-off-by: Chris Michael <cp.michael@samsung.com>
* elementary: Fix issue of wrong minimum size for some E dialogsChris Michael2016-07-271-2/+3
| | | | | | | | | | | When we are calculating minimum size hints for the window object, we should be adding framespace to maximum size, not subtracting it... Honestly this just looks like a brain-dead typo. Fixes T44225 Signed-off-by: Chris Michael <cp.michael@samsung.com>
* elementary: Avoid possibly setting opaque region twiceChris Michael2016-07-271-2/+3
| | | | | | | | Previously, if the window had no frame object, then this could would have been setting opaque region twice (for the alpha case). We can avoid this if we move the alpha check to below the frame check. Signed-off-by: Chris Michael <cp.michael@samsung.com>
* elm: Fix extra mouse,in events in layout_content_unsetJean-Philippe Andre2016-07-274-47/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: crash in assert() in terminology. Scenario: Open Terminology, Split V by keyboard, Move mouse to split 2, Create tab by keyboard --> abort() in terminology Cause: An extra mouse,in event happens during edje_object_unswallow inside elm_layout_content_unset. Root cause: efl_part() in elm_layout had a side effect: edje_recalc on the edje object. Causing its geometry to be "properly" defined and the mouse event to trigger callbacks. Solution: Avoid calling recalc... somehow. Conclusion: Without adding any new API, edje edit provides internally the information that we want: type of an edje part (for box & table). Fixes T4221 See T4028 See T3509
* elm cnp windows - remove unused varsCarsten Haitzler (Rasterman)2016-07-261-1/+0
|
* elm cnp win32 - do one side at least of unix newlines to windows newlnCarsten Haitzler (Rasterman)2016-07-261-1/+51
| | | | | | | | | | | | | | | | | | | | | | this PARTLY addresses T3556 ... this handles our own conversion of makrup to string then to a windows newlined string. this half. i wrote the conversion code for the other way but it's unused as i am unsure where exactly to plug in it. following the cnp code makes me not sure where it goes so for now - not there, but ready to go. to be clear. out API is unix text. utf8 strings at our api with UNIX newlines. that is our api. that is the text we accept and produce. if you deal with another file or interface that does not provide this then the job of conversion is AT THAT POINT. eg elm_cnp.c has to do this. as would file loads of text files (and saves) etc. - anything else like forgivingly handling anything at the api level makes it totally unclear what our api is and what should go in and come out. to be portable we have to define what it is and the most portable thing to do is at the api level within a process we define one and only one format. UNIX \n format. @fix - partial
* efl ui image - fix view size get to NOT apply scalingCarsten Haitzler (Rasterman)2016-07-261-9/+0
| | | | this fixes T3254
* elm_bg: fix typo in docMinkyu Kang2016-07-261-1/+1
| | | | | | | | | | | | Summary: Signed-off-by: Minkyu Kang <mk7.kang@samsung.com> Reviewers: cedric, jpeg Reviewed By: jpeg Subscribers: seoz, jpeg Differential Revision: https://phab.enlightenment.org/D4184
* elm_conform: set data pointer to obj from NULL.Sungtaek Hong2016-07-261-2/+2
| | | | | | | | | | | | | | | Summary: - In the callback for ELM_PLUG_EVENT_IMAGE_DELETED, it tries to get elm_conform's data from NULL. @fix Reviewers: Hermet, woohyun, cedric, jpeg Reviewed By: jpeg Subscribers: cedric, jpeg Differential Revision: https://phab.enlightenment.org/D4177
* Revert "access: add API to get access object of given part"Stefan Schmidt2016-07-256-42/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 57d77c9041086ebbf84c2a30d93e95d47fc12705. We are in freeze right now and this is a new feature. Considering the access API is still in beta I might have let this slip by but its does not even build ../../../src/tests/elementary/elm_test_popup.c:27:1: error: conflicting types for ‘elm_object_part_access_object_get’ START_TEST (elm_object_part_access_object_get) ^ In file included from ../../../src/lib/elementary/Elementary.h:240:0, from ../../../src/tests/elementary/elm_test_popup.c:6: ../../../src/lib/elementary/elm_object.h:521:54: note: previous declaration of ‘elm_object_part_access_object_get’ was here EAPI Evas_Object *elm_object_part_access_object_get(const Evas_Object *obj, const char *part); ^ ../../../src/tests/elementary/elm_test_popup.c: In function ‘elm_object_part_access_object_get’: ../../../src/tests/elementary/elm_test_popup.c:39:47: warning: passing argument 1 of ‘elm_object_part_access_object_get’ makes integer from pointer without a cast [-Wint-conversion] access = elm_object_part_access_object_get(popup, "access.title"); ^ ../../../src/tests/elementary/elm_test_popup.c:27:1: note: expected ‘int’ but argument is of type ‘Evas_Object * {aka struct _Eo_Opaque *}’ START_TEST (elm_object_part_access_object_get) ^ ../../../src/tests/elementary/elm_test_popup.c:39:13: error: too many arguments to function ‘elm_object_part_access_object_get’ access = elm_object_part_access_object_get(popup, "access.title"); ^ ../../../src/tests/elementary/elm_test_popup.c:27:1: note: declared here START_TEST (elm_object_part_access_object_get) ^ ../../../src/tests/elementary/elm_test_popup.c:39:11: error: void value not ignored as it ought to be access = elm_object_part_access_object_get(popup, "access.title"); ^ Makefile:43996: recipe for target 'tests/elementary/tests_elementary_elm_suite-elm_test_popup.o' failed make[5]: *** [tests/elementary/tests_elementary_elm_suite-elm_test_popup.o] Error 1 If you still want this in make sure it actually can compile the tests you added.
* elementary: Fix formattingChris Michael2016-07-251-1/+2
| | | | | | NB: No functional changes Signed-off-by: Chris Michael <cp.michael@samsung.com>
* access: add API to get access object of given partShinwoo Kim2016-07-256-0/+40
|
* elm table and box resize themselves on sizing eval - fix this - dont resizeCarsten Haitzler (Rasterman)2016-07-252-27/+5
| | | | | | thsi fixes T3031 @fix
* elm_access: fix typo of atspi actionShinwoo Kim2016-07-251-1/+1
|
* efl ui image async locking -fix CID 1356199 - locked data cant be messed withCarsten Haitzler (Rasterman)2016-07-241-5/+9
| | | | | | | | this addresses a coverity issue that in theory looks right fix CID 1356199 @fix
* efl ui video - fix coverity CID 1356997Carsten Haitzler (Rasterman)2016-07-241-1/+2
| | | | | | | really minor lack of check if emotion init succeeds. check and complain if it fails. @fix
* elementary: change cursor types for cocoaThiep Ha2016-07-221-3/+3
| | | | | Map more cursor types for cocoa. Fix T3352
* elm_win: move window contents back to 0,0 when deleting frame objectMike Blumenkrantz2016-07-211-0/+1
| | | | fix T4092
* elm_win: simplify borderless_set when reapplying the same stateMike Blumenkrantz2016-07-211-4/+3
|
* elementary: Remove logically dead codeChris Michael2016-07-211-1/+1
| | | | | | | | | | | | In all code paths leading to this goto statement being called, 'iter_array' variable will already be NULL, so checking it's validity is just logically dead code. Fixes Coverity CID1357392 @fix Signed-off-by: Chris Michael <cp.michael@samsung.com>
* elementary: Remove logically dead codeChris Michael2016-07-211-1/+1
| | | | | | | | | | | | Coverity reports that this is logically dead code. As we check the validity of 'model' above this function, then testing 'model' for validity again in this expression is just logically dead. Fixes Coverity CID1356617 @fix Signed-off-by: Chris Michael <cp.michael@samsung.com>
* elementary: Remove logically dead codeChris Michael2016-07-211-2/+1
| | | | | | | | | | | | Coverity reports that this is logically dead code. As eo_item has been dereferenced on all paths leading here, and it is also set above, then it cannot be NULL at this point, thus this check is logically dead. Fixes Covierty CID1355585 @fix Signed-off-by: Chris Michael <cp.michael@samsung.com>
* Revert "elementary: Make wl frame borders above content"Mike Blumenkrantz2016-07-201-3/+3
| | | | | | | This reverts commit 46904e19a71dbeecbcdb6950c0f372c34f6d0db6. this breaks stacking entirely and prevents a large number of widgets from ever becoming visible
* elm flip - make it not crash and interactive mode work againCarsten Haitzler (Rasterman)2016-07-201-5/+15
| | | | | | | elm flip has been broken for a while - interactive mode was broken and it was causing crashes. this fixes that. @fix
* elm_win: handle elm,action,menu signal for wl clientsMike Blumenkrantz2016-07-191-0/+24
| | | | | | trigger the xdg-shell method for this when the signal is received fix T3460
* elm_win: simplify opaque region updating during fullscreeningMike Blumenkrantz2016-07-191-4/+1
| | | | already handled during _elm_win_frame_del
* elm_win: update opaque region when frame is deletedMike Blumenkrantz2016-07-191-0/+3
| | | | fix T4092
* Revert "elementary: Fix issue of toggling border state causing visual jumps"Chris Michael2016-07-191-59/+7
| | | | | | | | | | | | | | | | | | This reverts commit fb24955782b9242beb9447ebb6631b2b63921988. While this patch did fix the issue of toggling window Borderless state in EFl-Wl client applications, it is "Enlightenment's" stance that it will not change to match this fix, so this has to be reverted else internal E dialogs show up with no border (due to them using SSD). This is going to re-open T4092 sadly :( and now leave that bug with no possible fix. ref T4092 Fixes T4126 Signed-off-by: Chris Michael <cp.michael@samsung.com>
* Ui text: remove unused variablesDaniel Hirt2016-07-191-3/+0
|
* win: Set window alpha when changing themeJean-Philippe Andre2016-07-181-1/+9
| | | | | This sets the window alpha back to 0 when switching from a theme with alpha to one without. Thanks @bu5hm4n for asking about this.
* win: Set proper flag when EDC specifies win "alpha"Jean-Philippe Andre2016-07-181-2/+2
|
* elementary: only call ecore_wl2 if wayland is enabledMarcel Hollerbach2016-07-161-0/+5
| | | | fix T4125
* elementary: Fix issue of toggling border state causing visual jumpsChris Michael2016-07-151-7/+54
| | | | | | | | | | | | | | | | This commit partially fixes a phab ticket where toggling window border state (elm_test -to "Window States") would cause the frame to be destroyed thus making the window contents appear to jump around ref T4092 NB: I call this a 'partial' fix because while it does fix the issue of efl client apps, there is still some breakage in Enlightenment that needs investigating. @fix Signed-off-by: Chris Michael <cp.michael@samsung.com>
* elm_cnp: use defined charset before falling back to defaultMarcel Hollerbach2016-07-141-2/+2
| | | | | | | the chance is very high that some glyphs are not fitting into the default (US-ASCII) so better falling back here on specified utf8. @ref T3972
* elementary tooltip: --printfHermet Park2016-07-141-2/+0
|