aboutsummaryrefslogtreecommitdiffstats
path: root/src/lib/elementary (unfollow)
Commit message (Collapse)AuthorFilesLines
27 hourselm/check: fix emission of legacy "changed" callbackMike Blumenkrantz2-2/+26
legacy "check" and "toggle" widgets operate differently: * check emits only the "toggle" event * toggle emits "toggle", "on", "off" legacy also must not emit events when the widget's state is changed programmatically to handle this effectively, check whether the event has been emitted for each state when the signal is emitted from the theme, and track this for subsequent uses to ensure that exactly one event is triggered when it should be Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D9831
27 hoursefl/radio/box: handle non-radio-objectsMike Blumenkrantz2-10/+9
this improves the usefulness of radio box by presenting it as a box widget which has the additional feature of being able to manage radio widgets also fix all the image cases in elm_test which relied on there being only a single box in the window Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D9998
27 hoursbuild: firmly split legacy and unified API into Efl_Ui.h and Elementary.hMike Blumenkrantz2-102/+55
these headers should be usable independently without having one secretly pull in the other fix T7667 Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D9981
27 hoursbuild: remove efl_ui_calendar.hMike Blumenkrantz5-57/+3
this was somehow actually a legacy header which duplicated elm_calendar.h ...sort of Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D9980
27 hoursbuild: use correct animation_view headers in Efl_Ui.h and Elementary.hMike Blumenkrantz2-1/+2
efl_ui_animation_view.h is the legacy header (but why?) efl_ui_animation_view.eo.h is the unified header Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D9979
27 hoursbuild: fix elm header usageMike Blumenkrantz14-27/+4
.c files in src/lib/elementary should only include elm_priv.h to ensure that all the include ordering is correct and that all necessary headers are pulled in .c files outside of src/lib/elementary should include either/both Efl_Ui.h, Elementary.h as needed Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D9978
27 hourselm/priv: fix this headerMike Blumenkrantz1-10/+2
this should include emotion, since that component is used internally, and it should not explicitly include api headers which should be in public headers Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D9977
27 hourselm/widget: make this header usable without elm_priv.h againMike Blumenkrantz1-0/+5
supposedly this header should be usable if someone wants to create an elm widget, so ensure that it can be included without issues Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D9976
27 hoursefl_ui/image_zoomable: include header for internal panMike Blumenkrantz1-0/+1
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D9975
27 hourselm/scrollable: unbreak this headerMike Blumenkrantz1-5/+4
this is a legacy header, it can't include any unified api types Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D9974
27 hoursbuild: add include guards for a couple elm headersMike Blumenkrantz2-0/+6
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D9973
27 hoursefl_ui/win: fix prototype decls for eo api versions of autodelMike Blumenkrantz3-46/+51
this is still pretty broken, but at least the headers aren't Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D9972
27 hoursbuild: use legacy api in places where legacy should be usedMike Blumenkrantz2-1/+3
these seem to randomly have been changed when they shouldn't have also install elm_clock_eo.h since this is required but we didn't install it Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D9971
31 hourselm_config: fix to check if eet_open failsWonki Kim1-0/+5
Summary: this patch adds a guard block in case of failure of eet_open(). Reviewers: bu5hm4n, zmike Reviewed By: zmike Subscribers: zmike, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9987
2 dayselementary: properly shutdown and cleanup Efl.Ui.Position_Manager.Cedric Bail4-3/+33
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D9946
2 dayselementary: fix double eina_value_free in Efl.Ui.Homogeneous_Model.property.setCedric Bail1-1/+0
Model do not own the Eina_Value when it is set on them. They can make a copy of it, but shouldn't free it. Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D9945
2 daysefl_ui_widget_part_bg: improve docsMarcel Hollerbach1-1/+7
Reviewers: segfaultxavi, zmike Reviewed By: segfaultxavi Subscribers: zmike, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9990
2 daysefl_ui_image: implement missing APIMarcel Hollerbach2-0/+35
the API calls have not been implemented, this revision implements these APIs as redirects to the image if those are a edje object. Normally this should be a calling the legacy edje API. However, this is here really hard as imitating the correct callback behaviour is hard. And the correct behaviour with the eina value type is also just leading to copying the implementation from edje. So in order to keep the amount of code low here, this just uses the efl-api to redirect the requests. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D9989
2 daysefl_ui_caching_factory: Fix resource leaksChris Michael1-2/+10
Small patch to fix resource leaks pointed out by Coverity Fixes Coverity CID1404762
2 daysefl_ui_widget_factory: Fix resource leaksChris Michael1-2/+10
Small patch to fix resource leaks pointed out by Coverity Fixes Coverity CID1404766
2 daysefl_ui_multi_selectable: remove SINGLE_ALWAYSMarcel Hollerbach3-6/+4
this should get a better solution later on. There is also no real usage for that. ref T7922 Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com> Differential Revision: https://phab.enlightenment.org/D9985
3 daysefl_ui_format: fix some more harmless Coverity warningsXavi Artigas1-3/+6
1403023 Unchecked return value 1403024 Unchecked return value 1403026 Unchecked return value If the eina value conversion fails the default value (0) will be used, which is already a good default. ERRs have been added so the developer has a hint of what is happening.
3 daysefl_ui_focus_manager_calc: fix resource leaksMarcel Hollerbach2-3/+5
this fixes CIDs 1396965 & 1396984
3 daysdocs: Update Efl.Ui.Box_Stack docsXavi Artigas1-1/+4
3 daysefl_ui_*: fix dereferencing of possible NULL valuesMarcel Hollerbach3-0/+5
this fixes CID 1404763 & 1404751 & 1403904
3 dayselm/datepicker, timepicker: Fix uninitialized varsXavi Artigas2-2/+2
Summary: Should fix all timepicker and datepicker uninitializer variable usage detected by Coverity: 1396954 Uninitialized scalar variable: efl_ui_timepicker.c 1396978 Uninitialized scalar variable: efl_ui_timepicker.c 1397006 Uninitialized scalar variable: efl_ui_timepicker.c 1396979 Uninitialized scalar variable: efl_ui_datepicker.c 1404748 Uninitialized scalar variable: efl_ui_datepicker.c 1404757 Uninitialized scalar variable: efl_ui_datepicker.c Test Plan: Everything builds and passes tests. Coverity should complain less. Reviewers: stefan_schmidt, zmike Reviewed By: zmike Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9967
3 dayselm_config: fix a missing of free after usingWonki Kim1-0/+1
Summary: safed_bindings will leak by going out the function without freeing. Reviewers: bu5hm4n, zmike Reviewed By: zmike Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9966
3 daysefl_ui_slider: improve docsMarcel Hollerbach1-1/+8
Summary: Depends on D9964 Reviewers: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9965
3 daysefl_ui_check: improve docsMarcel Hollerbach1-4/+6
Summary: Depends on D9963 Reviewers: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9964
3 daysefl_ui_button: improve docsMarcel Hollerbach1-0/+4
Reviewers: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9963
3 daysefl_ui_widget: remove misleading commentsXavi Artigas1-4/+0
Summary: We settled for the focus_allow name. The other APIs are not internal, they are protected, and this is noted, no need to say that again. Additionally it is not helpfull to have commented out c_prefix definitions. Depends on D9936 Reviewers: segfaultxavi Reviewed By: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9937
3 daysefl_ui_widget: remove wrong docsMarcel Hollerbach1-3/+0
Summary: this is not true anymore, this has been reverted due to how legacy works. *yey* Depends on D9935 Reviewers: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9936
3 daysefl_ui_widget: improve docsMarcel Hollerbach1-4/+15
Reviewers: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9935
3 daysefl.ui.scrollable: fix event name for scrollableHosang Kim13-48/+48
Summary: Event name is applied in the past tense. Meaning of 'stop' is 'stop it early', so I changed it to 'finish' Test Plan: elementary_test -> efl.ui.scroller Reviewers: segfaultxavi, woohyun Reviewed By: segfaultxavi Subscribers: zmike, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9859
3 daysefl/image: Efl.Gfx.Image_Scale_Type -> Efl.Gfx.Image_Scale_MethodXavi Artigas8-48/+48
ref T7927, T7875 Depends on D9931
6 daysefl_ui/scrollable_content: be more explicit about scrollable_content_get()Mike Blumenkrantz2-0/+3
Summary: always return NULL when an internal text object exists to avoid exposing internal objects; this is an abstraction mechanism which should not be extended or relied upon Reviewers: segfaultxavi Reviewed By: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9910
6 daysdoc: improve single line descriptionsMyoungwoon Roy, Kim1-3/+3
Summary: this patch improves single line descriptions described on T7717 Reviewers: woohyun, Hermet, myoungwoon, cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9795
6 daysefl_ui_slider: correct to a multiple of step when drag is finishedMarcel Hollerbach1-0/+12
Summary: this is needed in order to support the value to be a multiple of the step when drag has finished. The normal changed event is still emitted with non-multiple of step, but the steady event only contains the correct values now. ref T8187 Reviewers: zmike, segfaultxavi, woohyun Reviewed By: zmike Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8187 Differential Revision: https://phab.enlightenment.org/D9928
6 daysdocs: Move property docs to property level instead of set/getXavi Artigas18-385/+283
Eolian @properties should be documented at the property level, and documentation at the setter or getter level should be left to setter- or getter-specific comments. There is usually no need at all to have setter- or getter- specific comments. Also, a property is not a method so descriptions should match that. This patch removes lots of duplicated text, and will allow enabling by default the eolian check that ensures that properties have proper property-level docs. No functional changes.
7 daysefl_ui_calendar_item: document this class a little bit moreMarcel Hollerbach1-1/+6
Summary: Depends on D9923 Reviewers: segfaultxavi Reviewed By: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9924
7 daysefl_ui_image: insert @ to link docs proberlyMarcel Hollerbach1-1/+1
Summary: Depends on D9922 Reviewers: segfaultxavi Reviewed By: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9923
7 daysefl_ui_timepicker/datepicker : change event name properlyWooHyun Jung4-4/+4
Summary: This changes the event name from "changed" to "date(or time),changed" @ref T7869 T7901 Reviewers: segfaultxavi, zmike, bu5hm4n Reviewed By: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T7901, T7869 Differential Revision: https://phab.enlightenment.org/D9905
8 daysefl_ui_collection: fix the insertion of the first element with pack_atMarcel Hollerbach1-1/+2
Summary: before pack_at with no element failed because the list element has been NULL. This fixes the insertion, the codepath also works without the error. Depends on D9871 Reviewers: zmike, cedric Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9890
8 daysefl_ui/scrollable_content: handle null cases for scrollable_*_getMike Blumenkrantz1-0/+2
Summary: these are valid calls and should be handled correctly Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9880
8 daysefl_ui_group_item: fix insertion of item at the endMarcel Hollerbach1-1/+1
Summary: in this case here, eina list count already returns the count *including* the subobject, the case in pack_at below (where also +1 is added) is different to that, as count is the value *before* the list add. Depends on D9870 Reviewers: segfaultxavi, zmike, cedric Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9871
9 daysefl_ui_widget: refactor constructorMarcel Hollerbach1-14/+8
Summary: first of all, in efl-ui we should probebly ensure that a widget is always created in a window object. Otherwise we are looking for trouble. Additionally, calling efl_ui_win_shared_data_get on anything else than a window object will result in a returned NULL value. If we are not having a widget parent, there is also not much point in calling a API that is only defined on the widget base class, so we also move that away Reviewers: kimcinoo, raster Reviewed By: kimcinoo Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9762
9 daysefl_ui/alert_popup: More documentation nitpicksXavi Artigas1-6/+7
9 daysefl_ui/alert_popup: improve docsMike Blumenkrantz1-7/+22
Summary: class and property docs ref T7717 Reviewers: segfaultxavi Reviewed By: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl_docs Maniphest Tasks: T7717 Differential Revision: https://phab.enlightenment.org/D9883
9 daysdocs: nicer formatting of the NULL keyword, everywhereXavi Artigas9-11/+11
9 daysefl_ui/popup: improve docsMike Blumenkrantz1-29/+78
Summary: this provides full documentation for the class and all properties ref T7717 Reviewers: segfaultxavi Reviewed By: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl_docs Maniphest Tasks: T7717 Differential Revision: https://phab.enlightenment.org/D9882