summaryrefslogtreecommitdiff
path: root/src/lib/elementary (unfollow)
AgeCommit message (Collapse)Author
12 hoursefl_ui/layout: correctly batch object changed state when using freeze/thawMike Blumenkrantz
previously this would always queue a recalc when calling thaw even if the object hadn't changed also mimic edje internal behavior with unsetting 'frozen' during force calc for possible future handling even though it has no effect presently Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11628
14 hoursReplace strncmp codeMarcel Hollerbach
the structure "!strcmp(X, "foo", strlen("foo"))" is equal to "eina_has_prefix(X, "foo")", and the later is nicer to read, hence this replaces it. Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11620
17 hourscode: Silence compiler warnings.Alastair Poole
5 daysefl_ui_textbox: pass in correct seatMarcel Hollerbach
0 was the wrong seat, and only worked on a small amount of systems fixes T8639 Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11622
5 dayselm_atspi_bridge: initialize variablesShinwoo Kim
The efl_access_text_attribute_get is resolved by elm_entry. Please refer to _elm_entry_efl_access_text_attribute_get first. Uninitialized variables are used for its parameters, and it is able to return before setting these variables. Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11619
8 dayselm_atspi_bridge: fix bugs reported by coverityBartlomiej Grzelewski
Prevent usage of uninitilized values. CID: 1421995, 1421997, 1422001 Signed-off-by: Bartlomiej Grzelewski <b.grzelewski@samsung.com> Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11612
8 dayselm_atspi_bridge: fix bugs reported by coverityBartlomiej Grzelewski
Make sure we free allocated resources in the error path. Prevent usage of uninitilized value. Signed-off-by: Bartlomiej Grzelewski <b.grzelewski@samsung.com> Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org> Differential Revision: https://phab.enlightenment.org/D11607
9 daysdoxygen docs: Fix warnings in elm_config.hXavi Artigas
10 daysefl_ui_image: keep efl_ui_image size for internal imageShinwoo Kim
Summary: The size of internal image could be bigger than the size of efl_ui_image with following code. image = elm_image_add elm_image_fill_outside_set(image, EINA_TRUE); If the internal image object is 300x300, and efl_ui_image is 360x77, then the internal image object will resize to 360x360 which is bigger than the size of efl_ui_image. This is a compatibility issue. This patch will make efl_ui_image work as before commit 8cb6c3e Elm_image: implement 'scale_type' and 'scalable'... Test Plan: This is old example to reproduce the problem. {F3859361} This is newly added example to check if this patch breaks compatibility or not. {F3859390} You can use the example with following image. {F3859391} This is result before applying this patch. {F3859388} This is result after applying this patch. {F3859389} The translucent rectangle is the size of the efl_ui_image. As you might be noticed, only FIT_WIDTH (the 4th one of each row), and EXPAND (the 6th one of each row) are different. One more difference the 1st one of 2nd row; NONE. F.Y.I. and for quick understanding of example. The 1st row efl_ui_image is bigger than internal image. The 2nd row efl_ui_image is smaller than internal image. From the left the scale type is NONE, FILL, FIT, FIT_WIDTH, FIT_HEIGHT, EXPAND, and TILE. Reviewers: Hermet, jsuya, herb Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11587
11 dayselm_transit: Prevent adding duplicatesJunsuChoi
Summary: When repeating call elm_transit_object_add, prevent the object from being added duplicates. Test Plan: N/A Reviewers: Hermet, herb, kimcinoo Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11563
11 dayselm_transit: replace evas_object_event_callback_xxx with efl_event_callback_xxxJunsuChoi
Summary: In transit, event_callback is mainly used for delete callback. transit uses evas_object_freeze_events_set to control the user's mouse events. However, EVAS_CALLBACK_DEL was not called because of this. The behavior of evas_object_freeze_event was changed. This patch was created to fix some issues. Test Plan: N/A Reviewers: Hermet, kimcinoo, herb Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11562
11 daysEfl.Ui.Vg_Animation: Enable transit event.JunsuChoi
Summary: elm_transit freezes events by default for added objects. We have to use elm_transit_event_enabled_set to use events. Test Plan: N/A Reviewers: Hermet, kimcinoo, herb Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11560
11 daysefl_ui_widget: pass the correct flag hereMarcel Hollerbach
this here needs to pass the flag that gets set, not the flag that results. This is important for the cases, where a subtree in a widget tree keeps the flag. As this would leave the wrong counter. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11556
11 daysefl_ui_widget: unify tree number settings codeMarcel Hollerbach
Summary: the internals of those two methods have been the same. Both setted the internal numeric flag as either as 1 more or equal to the flag in the parent object (depending on the internal state). Further details can be found in the comment in code. Depends on D11554 Reviewers: zmike Reviewed By: zmike Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11555
11 daysefl_ui_widget: do not eval all the children twiceMarcel Hollerbach
Summary: eval all children is ending up in the complete discovery of the whole subtree, which is unnessesary here, as we are already discovering the whole subtree with the calls, these changes are in, so simple evalulating this is enough. Depends on D11551 Reviewers: zmike Reviewed By: zmike Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11554
11 daysefl_ui_widget: fix disabled set behaviourMarcel Hollerbach
Summary: this fixes disabled set behaviour. This ensures that when setting disabled twice, that unsetting it once does not break the overall state. This never appeared in any real life example, because elm_object_disabled_set is already checking for equalness. However, this is not wanted here, because the simple setter can also be used to sync the state with the parent, which appears to be helpfull. Depends on D11550 Reviewers: zmike Reviewed By: zmike Subscribers: zmike, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11551
11 daysefl_ui_widget: fix tree_unfocusable settingMarcel Hollerbach
Summary: when setting twice the same value, unsetting the same value would not restore the same state in the tree again. With this commit, we ensure this is working correctly. Reviewers: zmike Reviewed By: zmike Subscribers: zmike, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11550
2020-03-20ATSPI bridge refactoringBartlomiej Grzelewski
Add support for Text Interactive interface. Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11486
2020-03-20efl.ui.textbox: load default font properties onceAli Alzyod
As described in task T8617 when toggle editable mode for textbox, we will reserve user changes (instead of reload them again). this issue is affected by D9502, I do not fully understand why do we need it, so I leave color loading as it is. Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11404
2020-03-20efl_ui/image: implement efl.player::playback_loop propertyMike Blumenkrantz
this enables the existing looping functionality only when playback_loop is set (which is always set for legacy widgets) fix T8589 Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11308
2020-03-20efl_ui/image_zoomable: unset timer pointer when canceling animation timerMike Blumenkrantz
make sure we have no stale pointers later on in this case Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11307
2020-03-20efl_ui/image: implement efl.player::autoplay for image widgetsMike Blumenkrantz
this just calls efl.player::playing_set any time autoplay is true and the internal image object is preloaded ref T8589 Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11306
2020-03-17Spotlight: Remove jump_setup from ctors listXavi Artigas
This feature has not been used yet and it is making mono_gen abort, breaking build (probably because this property has setter but no getter).
2020-03-17docs: Improve Spotlight.Animation_Manager docsXavi Artigas
2020-03-17move stabelized items out of @betaAli Alzyod
ref T8541 ref T8522 Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11328
2020-03-17efl_ui_spotlight: Introduce animation managerMarcel Hollerbach
the manager is basically not new, its just the moved fade manager, with a little bit more utilization. The manager now can be equipt with 3 animaton objects that are played when the correct reason happens. For now the fade manager is the only thing that uses that. Reviewed-by: Jaehyun Cho <jae_hyun.cho@samsung.com> Differential Revision: https://phab.enlightenment.org/D11358
2020-03-17efl_ui_spotlight_manager: introduce a reason for switch_toMarcel Hollerbach
This is preparation work for a later commit. This brings a flag that indicates what the reason for a switch to call is, either a jump a push or a pop. Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es> Differential Revision: https://phab.enlightenment.org/D11357
2020-03-17win/widget: free array when object is deleted.Hosang Kim
It makes a memory leak. Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11522
2020-03-17edje_part: move part_type to common interfaceMarcel Hollerbach
In EFL we have multiple hirachies of parts. One in Efl.Layout namespace (alias edje) and one in Efl.Ui namespace. The seperation of these two makes sense from the perspective of hiding functionality. However, a functionality that we want to have on both is: we want to be able to check which type of part this is. In order to do so, this commit introduces a common interface, which allows that. This is required because eo is currently undergoing some works, where only APIs on a object are allowed, that are also inheriting its type, which is normal in OOP, but sometimes, due to the lack of limitation, we did that. This commit resolves one more case of that. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11516
2020-03-12docs: Efl.Ui.Textbox: Clarify when is Efl.Ui.Scrollable enabledXavi Artigas
2020-03-12efl.ui.textbox: proxy for efl.ui.scrollable interfaceAli Alzyod
Allow users to use scroller functinality with efl.ui.textbox Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11479
2020-03-12doxygen docs: Fix some more Illegal commandsXavi Artigas
Who thought that Italic Links was a good idea? Anyway, Doxygen does not like them.
2020-03-11efl_ui/layout: skip versioning checks for legacy widgetsMike Blumenkrantz
Summary: legacy widgets are always stable fix T8630 Reviewers: eagleeye Reviewed By: eagleeye Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8630 Differential Revision: https://phab.enlightenment.org/D11481
2020-03-10doxygen docs: Fix tons of invalid Doxygen commandsXavi Artigas
Mostly typos
2020-03-09efl_ui_textbox: dont leak a array when no type is availableMarcel Hollerbach
this fixes a possible leak.
2020-03-09ecore_evas_x: correctly handle images in X11Marcel Hollerbach
I thought that i explicitly tested this. However, it seems i was wrong, this way now this is handled correctly, and the image is stored and coverted to a path. With this you can now copy images from chromium and firefox to elm apps. The change in elm_entry reverts parts of the rewrite of the elm handling, as initially every path came *without* "file://" in front, so we have to maintain that. fixes T8625
2020-03-09elm_cnp: move free call after the last usageMarcel Hollerbach
this is however pretty much irrelevant as only the pointer is used.
2020-03-09elm_cnp: free array when going out of scopeMarcel Hollerbach
this was missing and indeed a memory leak.
2020-03-09efl_ui_win: Fix null pointer dereferenceChristopher Michael
Fixes Coverity CID1420321
2020-03-09efl_ui_win: Fix null pointer dereferenceChristopher Michael
Fixes Coverity CID1420329 and CID1420328
2020-03-09efl_ui_win: Fix horrible formattingChristopher Michael
NB: No functional changes
2020-03-09Efl.Ui.Image: Modify current frame to start at 1JunsuChoi
Summary: 3dc3deb patch was changed to start at 1 rather than 0. gif image starts at 1, not 0. Test Plan: N/A Reviewers: Hermet, kimcinoo Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11474
2020-03-08docs: Strengthen docs for Copy&Paste and Drag&DropXavi Artigas
Including Eina.Content And a typo/bugfix in ecore_evas_x. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11204
2020-03-08rewrite efl cnp and dnd handlingMarcel Hollerbach
the previous commits introduced a abstraction for drag in drop which can be now used for this here. With this commit all the direct protocol handling in efl.ui is removed, and only the ecore evas API is used. Additionally, this lead to a giant refactor of how APIs do work. All Efl.Ui. interfaces have been removed except Efl.Ui.Selection and Efl.Ui.Dnd, these two have been restructored. A small list of what is new: - In general no function pointers are used anymore. They feel very uncompftable in bindings and in C. For us its a lot easier to just listen to a event when a drop enters or leaves, there is no need to register custom functions for that. - Asynchronous data transphere is handled via futures, which proved to be more error safe. - Formats and actions are handled as mime types / strings. - 0 is the default seat if you do not know what else to take. - Content is in general passes as a content container from eina, this also allows applications to pass custom types The legacy dnd and cnp API is implemented based on that. All cnp related things are in elm_cnp.c the dnd parts are in elm_dnd.c Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11190
2020-03-08ecore_evas: Introduce cnp / dnd API for ecore evasMarcel Hollerbach
The idea of copy and paste here is: - The user specifies the content he wants to have in the selection buffer with a Eina_Content, these content pointer ownerships are passed to the called. Internally ecore_evas code will memorieze the pointer, and pass on function callbacks to the modules, which then do not have to deal with the ownership. - In case the module does not specify these APIs, the callback implementation will be called, which only works for cnp *not* dnd. - Action and mime types are handled as strings, which allows way better custom organisations. (The docs needs improvement) Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11192
2020-03-06efl_ui_win: Fix dereference before NULL checkChristopher Michael
This patch fixes an issue detected by Coverity in that 'sdp' is already being dereferenced before we check it. ELM_WIN_DATA_GET can return NULL, so we should check it's return Before trying to use the variable. Fixes CID1419871
2020-03-06elm: undef EAPI_WEAK in header before definingMike Blumenkrantz
Summary: avoid double define warnings Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11452
2020-03-06efl_ui/widget: add inheritance for efl.gfx.entity to widget partMike Blumenkrantz
most of these are empty Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D11448
2020-03-06elm_label: add EFL_ACCESS_WIDGET_ACTION_MIXINMarcel Hollerbach
we implement the API from it, so we should have that as a type here. Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Differential Revision: https://phab.enlightenment.org/D11447
2020-03-06elm_code_syntax: Add c-sharp syntax highlighting.Alastair Poole