Age | Commit message (Collapse) | Author |
|
We're supposed to query the path for a session id instead of just
making up the string ourselves.
Fixes all input devices being dead after a vc switch for some users.
|
|
|
|
|
|
this is still semi-broken if a seat has many pointer-ish type devices since
pointer devices in ecore-evas were never correctly implemented to be 1:1 with
seat:cursor relationships
@feature
|
|
fix async device initialization for devices which need this (e.g., touchpads)
@fix
|
|
|
|
|
|
|
|
context and keymap need to be set at the same time in order to effectively
update keyboard state, and active group should be accessible through api
as well
preserve old function ABI to ensure old binaries don't crash
|
|
@feature
fix T5006
|
|
todo: move all this duplicated code somewhere
|
|
|
|
|
|
|
|
|
|
@feature
|
|
@fix
|
|
|
|
this is consistent with x11 behavior as well as the behavior of other toolkits
under wayland
@feature
|
|
Since efl-jenkins does not have libinput >= 1.7.0, this commit broke
the jenkins build due to missing
LIBINPUT_POINTER_AXIS_SOURCE_WHEEL_TILT value. We should be able to
get by with letting 'default' case handle it....
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
|
libinput >= 1.7.0 added support for
LIBINPUT_POINTER_AXIS_SOURCE_WHEEL_TILT, however we do not yet support
that in elput, thus gcc was spilling a warning about an unhandled
enumeration value here. We'll add a case for the above, plus a default
to cover any future additions.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
|
Gcc reports 'flags' as unused here, so remove it
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
|
|
|
|
|
since these are only local path resolves, the do and wait are
technically not needed. also remove any other tmp strings
and use the vpath string resolving feature to avoid
printfs/strjoins/cats etc. etc. as well.
also remember to remove old name string from evas shm code - it worked
for me. i guess i was lucky and it happened to be NULL thus free was
fine.
|
|
This reverts commit 2037474dc0fd2b360452f2a15abcbe533b57ca37.
This causes the wayland_shm engine to seg fault immediately at
startup when attempting to create shm buffers.
Please make sure when committing changes to the wayland_shm engine to
test on intel, exynos, and at least one platform without dmabuf
capabilities - or using the EVAS_WAYLAND_SHM_DISABLE_DMABUF env var
to disable dmabuf on intel or exynos.
Anyone without the time or hardware to fully test changes to wayland_shm
can submit a patch to phabricator and assign it to me so I can fully
test it before landing.
|
|
since these are only local path resolves, the do and wait are
technically not needed. also remove any other tmp strings and use the
vpath string resolving feature to avoid printfs/strjoins/cats etc.
etc. as well.
|
|
this time around... use a / at the end of the (:run:) virtual dir
path to make it work.
|
|
This reverts commit 24e34e19a1db84cdcb6241207cb99d14ca83c41b.
This broke keyboard input for the enlightenment wayland compositor,
please test elput changes on at least one of the drm backends,
preferably with enlightenment.
The wayland compositor is hard enough to keep stable due to breakage
from core changes only tested on X - but elput's main user is our
wayland compositor, was this tested anywhere?
|
|
This reverts commit 95d93cb7208857cc89d79f3ffbbd7ee71ba1936f.
Formatting change on top of a totally untested coverity fix that
breaks input for enlightenment's wayland compositor.
#TeamworkIsDeprecated
|
|
NB: No functional changes, just some minor formatting adjustments
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
|
this fixes CID 1357168 in the case of setuid binaries as vpath handles
setuid cases.
|
|
By only checking if the thread was cancelled *after* sending feedback
to the main thread we ended up claiming all the devices libinput
asked for in a way that never allowed them to be released
(how the hell can a cancelled thread send feedback?)
|
|
This actually should have been part of the previous patch which moved
setting output_name to evdev, but it got missed so add it now. This
ensures we cleanup the output_name stringshare on error.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
|
As device calibration has already been handled via external facing
API, this FIXME note is no longer needed.
NB: No functional changes
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
|
Small patch to set the output name of an Elput_Device when the device
gets created. Note, this was already being done inside elput_input,
but this patch moves it to when the device gets created.
NB: Really no functional changes here, just moving a function call.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
|
@feature
|
|
Small patch which does not print out debug info for devices we do not
handle, and adds the 'type' of device to the debug output (pointer,
keyboard, etc).
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
|
If an input device is not a pointer, keyboard, or touch device then we
are not going to be handling events for it, so do not create a new
Elput device for it.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
|
Reverting this in favor of a better way to improve debug output
This reverts commit cee7ee39932c31a21d3dd90e19703371a946a0c0.
|
|
Minor change on the return value of the device_add and device_remove
functions so that we can avoid debug output for devices which we do
not deal with.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
|
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
|
Coverity reports that we leak 'msg' here if we fail to append
arguments to the message.
Fixes CID1367499
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
|
If a user calls elput_input_pointer_xy_get (as is done via
ecore_evas_drm) and a pointer does not exist, we never return any
coordinates for this function.
Enlightenment is using ecore_evas_pointer_xy_get (which when using the
drm ee, ends up calling elput_input_pointer_xy_get). If we have no
pointer device, then no coordinates are ever returned and touch
clicking does not function properly.
To fix that we will check if a touch device exists and supply the
coordinates from that (in the case where there is no pointer device).
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
|
This patch sends a touch motion event before sending of touch up/down
events. This allows some compositors (enlightenment) to update their
internal representation of where the mouse pointer is before handling
button events (as touch down/up is treated as a mouse button down/up).
Fixes T5094 for the old man ;)
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
|
This patch adds a timestamp field to the touch structure so that we
can store it and do not have to refetch the timestamp when sending
touch events.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
|
Coverty reports that we leak 'reply' here if we fall into the error
condition.
CID1367506
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
|
Coverity reports that 'reply' is leaked here if we fall into the error
condition.
CID1367507
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
|
As libinput_config_status may contain 3 possible return values, we
need to santize the return values there into Eina_Bool for use in our
own functions.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|
|
This patch adds API functions to get or set if tap-to-click is enabled
on a touchpad device
@feature
Signed-off-by: Chris Michael <cp.michael@samsung.com>
|