|Age||Commit message (Collapse)||Author|
Patch from a series of patches to rename EAPI symbols to specific
= The Rationale =
This patch is from a series of patches to rename EAPI symbols to
specific library DSOs.
EAPI was designed to be able to pass
`__attribute__ ((visibility ("default")))` for symbols with
GCC, which would mean that even if -fvisibility=hidden was used
when compiling the library, the needed symbols would get exported.
MSVC __almost__ works like GCC (or mingw) in which you can
declare everything as export and it will just work (slower, but
it will work). But there's a caveat: global variables will not
work the same way for MSVC, but works for mingw and GCC.
For global variables (as opposed to functions), MSVC requires
correct DSO visibility for MSVC: instead of declaring a symbol as
export for everything, you need to declare it as import when
importing from another DSO and export when defining it locally.
With current EAPI definitions, we get the following example
working in mingw and MSVC (observe it doesn't define any global
variables as exported symbols).
EAPI void foo(void);
EAPI void bar()
EAPI void foo()
This works fine with API defined as __declspec(dllexport) in both
cases and for gcc defining as
However, the following:
EAPI extern int foo;
EAPI void foobar(void);
EAPI void bar()
foo = 5;
EAPI int foo = 0;
EAPI void foobar()
printf ("foo %d\n", foo);
This will work on mingw but will not work for MSVC. And that's why
LIBAPI is the only solution that works for MSVC.
Co-authored-by: João Paulo Taylor Ienczak Zanette <email@example.com>
Co-authored-by: Lucas Cavalcante de Sousa <firstname.lastname@example.org>
Co-authored-by: Ricardo Campos <email@example.com>
Reviewers: vtorri, woohyun, jptiz, lucas
Reviewed By: vtorri, lucas
Subscribers: cedric, #reviewers, #committers
Differential Revision: https://phab.enlightenment.org/D12214
Since efl object is introduced, magic check is no more used.
Plus, remove redundant object functions interfaces
Reviewers: #committers, bu5hm4n
Reviewed By: #committers, bu5hm4n
Subscribers: bu5hm4n, raster, cedric, #reviewers, #committers
Differential Revision: https://phab.enlightenment.org/D7153
was never used as was not practical to do so so it effectively does
nothing so remove it to reduce analyser warnings
found by PVS studio
In C we need this to make clear that we really do not accept parameters.
Found by the smatch source code matcher. I had run and fixed this before
but it seems to creep in again over time.
Being annoyed by different types of eina critical macros - CRI, CRIT,
CRITICAL -, I concluded to unify them to one. Discussed on IRC and
finally, CRI was chosen to meet the consistency with other macros -
ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
Fixes Coverity CID1039498
Signed-off-by: Chris Michael <firstname.lastname@example.org>
Evas_Common.h should be used for the public header, and rather rename
evas_common.h internal header to another name.
Evas_Common_Header.h -> Evas_Common.h
evas_common.h -> evas_common_private.h
Shouldn't have both Evas_Common.h and evas_common.h because of case
I've tested make -j 3 install and it works nicely
I've tested expedite with software and opengl xlib,
and it works. Not tested other engines, so please
report any problems (engines or other) on the ML.
TODO: examples and tests, I'll add them later
ISSUE: Eina_Unicode size check. It indirectly depends on
eina_config.h, which is created at the end of the
configure script. So its size is always 0. I don't
know how that size is used, so I can't do a lot,
SVN revision: 78895