summaryrefslogtreecommitdiff
path: root/src/lib/evil/evil_locale.c (follow)
AgeCommit message (Collapse)Author
2020-11-12evil: Rename EAPI macro to EVIL_API in Evil libraryFelipe Magno de Almeida
Summary: Patch from a series of patches to rename EAPI symbols to specific library DSOs. EAPI was designed to be able to pass ```__attribute__ ((visibility ("default")))``` for symbols with GCC, which would mean that even if -fvisibility=hidden was used when compiling the library, the needed symbols would get exported. MSVC __almost__ works like GCC (or mingw) in which you can declare everything as export and it will just work (slower, but it will work). But there's a caveat: global variables will not work the same way for MSVC, but works for mingw and GCC. For global variables (as opposed to functions), MSVC requires correct DSO visibility for MSVC: instead of declaring a symbol as export for everything, you need to declare it as import when importing from another DSO and export when defining it locally. With current EAPI definitions, we get the following example working in mingw and MSVC (observe it doesn't define any global variables as exported symbols). ``` Example 1: dll1: ``` EAPI void foo(void); EAPI void bar() { foo(); } ``` dll2: ``` EAPI void foo() { printf ("foo\n"); } ``` This works fine with API defined as __declspec(dllexport) in both cases and for gcc defining as ```__atttribute__((visibility("default")))``` However, the following: Example 2: dll1: ``` EAPI extern int foo; EAPI void foobar(void); EAPI void bar() { foo = 5; foobar(); } ``` dll2: ``` EAPI int foo = 0; EAPI void foobar() { printf ("foo %d\n", foo); } ``` This will work on mingw but will not work for MSVC. And that's why EAPI is the only solution that worked for MSVC. Co-authored-by: João Paulo Taylor Ienczak Zanette <jpaulotiz@gmail.com> Co-authored-by: Ricardo Campos <ricardo.campos@expertise.dev> Co-authored-by: Lucas Cavalcante de Sousa <lucks.sousa@gmail.com> Reviewers: raster, vtorri, jptiz, lucas, woohyun Reviewed By: vtorri, jptiz Subscribers: ProhtMeyhet, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D12182
2020-10-27evil: undef setlocale to avoid recursionFelipe Magno de Almeida
Summary: evil_setlocale implementation must not call itself, so it must #undef setlocale to avoid replacing with evil_setlocale. Reviewers: vtorri, jptiz, lucas Reviewed By: vtorri, jptiz Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D12184
2019-05-28Evil: fix infinite loop with setlocaleVincent Torri
Summary: evil_setlocale was defined as setlocale in evil_private.h *before* evil_setlocale, hence evil_setlocale was calling itself. The solution was to not call evil_private.h in evil_locale.c Test Plan: compialtion and elementary_test Reviewers: zmike, raster, cedric Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Maniphest Tasks: T7985 Differential Revision: https://phab.enlightenment.org/D9030
2019-05-15Evil: move the inclusion of all headers in evil_private.hVincent Torri
Summary: first step for making Evil private. evil_private.h will be included in the EFL source code instead of Evil.h Test Plan: compilation Reviewers: raster, cedric, zmike Reviewed By: raster Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8893
2015-12-08Evil: fix infinite recursive loop in previous addition of setlocale() in EvilVincent Torri
Summary: setlocale() called itself because it was defined as a #define so remove this #define from evil_locale.h and move it in another header file To avoid future problem, move similar defines to this header file Also clean all the header file mess in Evil Reviewers: cedric Subscribers: jpeg Differential Revision: https://phab.enlightenment.org/D3409
2015-11-30Evil: add support for LC_MESSAGES for setlocale()Vincent Torri
LC_MESSAGES is an extension to C ANSI and does not exist on Windows. So add LC_MESSAGES API and overload setlocale() to support it @feature