path: root/src/lib (unfollow)
AgeCommit message (Collapse)Author
2017-03-09ecore_ipc: avoid crash during shutdown due to Ecore_Event queue.Cedric BAIL
2017-03-09ecore_input: avoid crash during shutdown due to Ecore_Event queue.Cedric BAIL
2017-03-09ecore_imf: avoid crash during shutdown due to Ecore_Event queue.Cedric BAIL
2017-03-09ecore_evas: avoid crash during shutdown due to Ecore_Event queue.Cedric BAIL
2017-03-09ecore_drm: avoid crash during shutdown due to Ecore_Event queue.Cedric BAIL
2017-03-09ecore_cocoa: avoid crash during shutdown due to Ecore_Event queue.Cedric BAIL
2017-03-09ecore_con: avoid potential crash during shutdown due to Ecore_Event queue.Cedric BAIL
2017-03-09ecore: avoid potential crash on shutdown in Ecore_ExeCedric BAIL
2017-03-09ecore: add ecore_event_type_flush.Cedric BAIL
During shutdown it is possible that some event are still in ecore events queue and get processed after the shutdown of the module that did emit them. This would lead to crash in some case. The answer to this problem is to normally manually track all ecore event in the queue and destroy them before shutdown... Of course that make the API difficult to use and basically nobody got it right. This new API do actually as it says remove all the ecore event of a certain type from ecore events queue. It is to be called on shutdown. @fix
2017-03-09ecore_cocoa: fix windows initial renderingJean Guyomarc'h
We need to refresh the Cocoa's content view when showing the window. In some particular cases (including the elementary_test initial window), the content view is redrawn because of external events (the entry animator). When no action at all is performed, the window and the content view are resized... nice... but not drew... Such a simple fix for this hell of a bug! Fixes T5210
2017-03-09ecore_cocoa: factorize a little access to the cocoa windowJean Guyomarc'h
2017-03-09ecore_wl2: Fix up xdgv6 ack_configuresDerek Foreman
We've been immediately acking configure with the correct serial number, then later at commit time sending an incorrect serial (generating a new one). Remove the extra ack, and save that serial for later, and don't overwrite it with a current serial when we get a toplevel configure. Oddly, compositors were letting us get away with this behaviour, so this probably looks functionally the same as before.
2017-03-09ecore_wl2: Fix initial maximized/fullscreen stateDerek Foreman
This defers the fullscreen/maximized states if we don't have a shell surface, and sets them in the first shell surface commit. ref T5044
2017-03-09ecore_wl2: Rename badly named APIDerek Foreman
Oops, I broke naming convention with this, but it's unreleased and beta so I hope nobody notices as long as I change it now...
2017-03-09ecore_wl2: Remove wl_shell client supportDerek Foreman
We're never going to encounter a compositor without at least xdg v5 support, so remove wl_shell support.
2017-03-09ecore-anim: Remove unused variableChris Michael
Gcc reports 'i' as unused here and checking the code confirms that, so remove unused variable. Signed-off-by: Chris Michael <>
2017-03-09Revert "ecore_input - dont try update modifiers and locks on mouse events"Derek Foreman
This reverts commit f654714d75afdd07ad851bf278a39ddf8de6caba. Modifiers do influence mouse events, though a mouse input can't change them... This commit broke modifer+drag on windows in E, so I'm reverting it.
2017-03-09evas filters: Save selected render op of the final objectJean-Philippe Andre
If an object is meant to use COPY mode (for evil purposes, most likely), then its filtered output should also be using COPY mode. @fix
2017-03-09win32: removed duplicate winsock2.h and added WIN32_LEAN_AND_MEAN in Ecore.hIvan Furs
Summary: winsock2.h is dublicate in src/lib/ecore/ecore_main.c Reviewers: NikaWhite, an.kroitor, cedric, raster, rimmed, vtorri Subscribers: cedric, jpeg Differential Revision:
2017-03-09popup: hides the popup when hide effect is finishedTaehyub Kim
Summary: When popup hides and shows fast, sometimes popup is not shown because of the difference visible value between popup and notify (case: popup visible state: 1, popup_notify visible state: 0) To sync this value I added the visible set code in elc_popup.c @fix Test Plan: 1. run elementary_text -to popup 2. shows the hide popup 3. hides popup using the hide button 4. repeat 2,3 step 5. popup will be shown well Reviewers: jpeg, cedric, Hermet, raster Subscribers: Blackmole, woohyun Differential Revision:
2017-03-09ecore_input - dont try update modifiers and locks on mouse eventsCarsten Haitzler (Rasterman)
mouse events have nothing to do with modifiers or locks, so dont try modify them on mouse events. a total waste of cpu and time. this should also fix T5251
2017-03-09multibuttonentry : fix box indicated item correctly in item_insert_before ↵JEONGHYUN YUN
and item_insert_after Summary: If user added item with item_insert_before and item_insert_after, item was not displayed. For this reason, fixed box indicated item correctly from reference->button to VIEW(reference). Additionally, remove the unused variable button in _Multibuttonentry_Item struct. Reviewers: woohyun, CHAN, cedric, jpeg Reviewed By: CHAN Subscribers: cedric, jpeg Differential Revision:
2017-03-09evas: Check for null pointer derefBryce Harrington
Summary: Earlier places in the function are testing if obj->layer is null, so should be checked here as well before it's used. @fix CID1371826 Reviewers: jpeg Reviewed By: jpeg Subscribers: cedric, jpeg Differential Revision:
2017-03-09evas image cache - add lots more locking to try stamp out any thread bugCarsten Haitzler (Rasterman)
this definitely fixes T5223 because it adds an engine lock around the code segemtnt that does compare time stamps... and hopefulyl a few more things too. @fix
2017-03-09ecore_cocoa: pass the right window to ecore_evasJean Guyomarc'h
2017-03-08eina: force copy of not copied virtualized file while doing an eina_file_dup.Cedric Bail
The other way around is pretty much impossible as you don't know who does an eina_file_dup and for how long they keep there reference. T5234
2017-03-08ecore-wl2: Clarify post-condition for global lookup in _ecore_wl2_shell_bindBryce Harrington
Summary: The !global test is a post-condition that _ecore_wl2_global_find provided valid data, so the code is clearer if this is kept separate from the subsequent if chain for looking up the shell. Since this post-condition returns from the function on error, it can stand alone. Signed-off-by: Bryce Harrington <> Reviewers: devilhorns, ManMower Reviewed By: ManMower Subscribers: jpeg, cedric Differential Revision:
2017-03-08evas: clean up GL images for emojis when GL context is free'dYoungbok Shin
If GL context is free'd before processing font shutdown, textures for emoji glyph's GL images will be free'd without clean up its GL images. It causes eina mempool infinite loop issue when emoji's GL images are free'd in shutdown process. So, the patch will make a list for emoji's GL images in context and clean up them when the context is free'd. Just like font textures in context. @fix Differential Revision: Signed-off-by: Jean-Philippe Andre <>
2017-03-08evas gl: Add missing GLES 3.1 definitionsJean-Philippe Andre
Evas_GL_API supports the GLES 3.1 functions but the required macros were not present. Thanks Brokenshakles for the tip.
2017-03-08naviframe: keep unfocusable state of item before finishing item push/popYoungbok Shin
If item pop was started without focus at a naviframe object and the naviframe object got focus before finising item pop, the naviframe object could give focus to its first object of prev item. It could ruin focus orders and failed to restore previous focused object in the item. To keep consistency of focus policy, same logic will be applied to item push scenario. @fix Change-Id: Ia74bdce3620bd59622ef32a0cedf5fbd84815400
2017-03-08evas: Print CRI message in case of bad event usageJean-Philippe Andre
This will abort E when using Bryce and EINA_LOG_ABORT is enabled (it is enabled by default when running a non-release version of E). That's on purpose, as that code needs fixing :) Ref T3144
2017-03-08ecore_evas: process mouse move even when there is no cursorJean Guyomarc'h
2017-03-08evas: Set thread name for preloadJean-Philippe Andre
This can be useful during debugging.
2017-03-07ecore: switch back to use ecore_thread_wait.Cedric BAIL
We need to make sure that we wait properly on the animator thread otherwise we end up with the animator finish callback being called later on during the shutdown process which means trouble.
2017-03-07ecore-wl2: Remove some debugging printoutsChris Michael
These prints were left over from 5b9374583e3fd450ac53c566095c398f0d6c5cfe and should not have been pushed. Signed-off-by: Chris Michael <>
2017-03-07evas: Fix layer usage count and deletionJean-Philippe Andre
When using smart objects (quite likely, isn't it?), the internal layer usage count was not perfectly tracked. This was especially true if layer_set() was called on a (top-level) smart object. As a consequence, there could be no objects in the layer but the usage would still be > 0. Thus, the layer was not deleted, not removed from the inlist of layers, and efl_gfx_stack_above_get() could return NULL as the layer above a certain object was empty. Fixes T5201
2017-03-06elementary: fix tests build.Cedric Bail
2017-03-07ecore: fix build when debugging threadsJean Guyomarc'h
2017-03-06eina_file: delete handle->fm(handel of function CreateFileMapping)Ivan Furs
Summary: CreateFileMapping return handle. The handle before use is always closed. This handle can be immediately closed after use. Reviewers: cedric, raster, vtorri, rimmed, an.kroitor, FurryMyad, NikaWhite Reviewed By: raster Subscribers: artem.popov, cedric, jpeg Tags: #windows Differential Revision:
2017-03-06eet_lib: changed unlink to eina_file_unlinkIvan Furs
Summary: changed unlink to eina_file_unlink Reviewers: cedric, raster, an.kroitor, rimmed, FurryMyad, NikaWhite, vtorri Subscribers: artem.popov, cedric, jpeg Differential Revision:
2017-03-06evas: Fix non-disappearance of text entry cursorJean-Philippe Andre
The mouse cursor in a text entry tends to not disappear even when the mouse moves out of the entry. This seems to happen more when the cursor was visible for a single frame only (although I'm not 100% sure about this condition). One important difference with previous versions of EFL is that the cursor is now part of the theme, so it is an image object and not set by the compositor (it looks vastly different). Anyway, when processing the list of pending_objects, we look at the flags render_pre and rect_del which were (re)set during the previous frame. Those flags are then (re)set during phase 1 which happens after processing the pending objects list... only if needed. So, phase 1 sets the condition to invalidate the current lists of objects but that condition is checked for before phase 1. This patch adds a check on delete_me which should hopefully make it a rare enough case, for performance, but still force correct rendering. This is all spaghetti code, sorry if this explanation also reads like pasta. Note that exactness tests may still be broken because earlier versions of EFL simply did not have the cursor inside the canvas itself. Fixes T5231
2017-03-06tests: Remove CPU affinity from all threadsJean-Philippe Andre
I believe that all the threads created in our test suite should be spawned without any special CPU affinity. The default parameter is not 0 (corresponds to the first CPU, known as CPU 0) but -1. Similarily the default priority is NORMAL (1), not 0 (URGENT). This also affects two unused code paths: evas render2 and gl preload. @fix
2017-03-04elm_code: Fix missing syntax for .eo filesAndy Williams
This was accidentally removed in the transition from edi. using text/x-eolian which is not well reported by the FS yet. @fix
2017-03-03Revert "ecore: forcefully flush pending event when ecore_shutdown is called."Mike Blumenkrantz
This reverts commit 2c6808e4eed28d5b93d2f10b558b168aa365364e. this breaks a number of expectations and guarantees in efl: * causes unexpected event iteration during app startup before main loop begins - leads to event loss * causes unexpected event iteration during app shutdown after main loop quits - leads to invalid memory access * causes recursive event iteration during event handler callbacks - leads to ????????????????????????????????????????????????????????????????? all of these can be easily seen by running enlightenment, and all of these cause unexpected behaviors in enlightenment including, but not limited to, a lot of crashes fix T5232
2017-03-02ecore_thread: do not override the data field of a threadMarcel Hollerbach
otherwise a currently executed ecore_thread is going to pass a complete wrong data to its callbacks. fix T5175 fix T5173
2017-03-02Efl.Canvas.Object: Multi-seat API should not be exposed to legacy.Guilherme Iscaro
Summary: This new kind of APIs should be EO only. Reviewers: jpeg, cedric, barbieri, bdilly, stefan_schmidt Reviewed By: cedric, barbieri Subscribers: cedric, jpeg Differential Revision: Signed-off-by: Cedric BAIL <>
2017-03-02evas: Fix double clipping issue with mapjiin.moon
If object's parent has map and object also has map, the evas clip would be applied twice. The context already applied clip area when drawing on map_surface. So don't need more clipping when drawing map_image. Also, make sure to apply the framespace clip when drawing the map surface onto the final canvas. Thanks @jiin.moon for the initial patch (see D4694). @fix Signed-off-by: Jean-Philippe Andre <>
2017-03-02genlist: Remove weird behavior about item_show, bring_inJiwon Kim
Summary: When if item_show / bring_in is proceeded as 'deferred_show' sequence, Scrollto_Type does not be checked perfectly. As a result, ELM_GENLIST_ITEM_SCROLLTO_NONE and any other integer values are worked such as ELM_GENLIST_ITEM_SCROLLTO_BRING_IN. As doxygen of Elm_Genlist_Item_Scrollto_Type, ELM_GENLIST_ITEM_SCROLLTO_NONE and other incorrect number should not work. Fixes T4854 @fix Reviewers: SanghyeonLee, woohyun, jpeg Reviewed By: jpeg Subscribers: id213sin, conr2d, cedric Maniphest Tasks: T4854 Differential Revision:
2017-03-02doc: Fix invalid group classification for Edje_AudioJeeyong Um
Summary: Edje_Audio group should belong to Edje group. Reviewers: cedric, jpeg Reviewed By: jpeg Differential Revision:
2017-03-02ecore: Fix typo in error messageBryce Harrington
Reviewers: cedric, jpeg Reviewed By: jpeg Subscribers: jpeg, cedric Differential Revision: