path: root/src/modules/ecore_imf (follow)
AgeCommit message (Collapse)Author
2019-12-06imf - make xim+scim the defaults not xim+ibus due to ibus being brokenCarsten Haitzler (Rasterman)
at leats ibus seems to just not work for me on arch at least - even with gtk apps, but scim does, so maybe make scim the main thing again? also allows glib to be off by default. :)
2019-08-15meson: add xkbcommon to the build depsMarcel Hollerbach
Summary: fix T8064 Reviewers: cedric, zmike, devilhorns Reviewed By: devilhorns Subscribers: #reviewers, #committers Tags: #efl Maniphest Tasks: T8064 Differential Revision:
2019-07-15ecore_imf: remove code to use deprecated API in wayland immoduleJihoon Kim
Signed-off-by: Jihoon Kim <>
2019-07-10ecore_imf: deprecate ambigous or unused APIsJihoon Kim
ecore_imf_context_show ecore_imf_context_hide ecore_imf_context_control_panel_show ecore_imf_context_control_panel_hide ecore_imf_context_preedit_start_event_add ecore_imf_context_preedit_end_event_add ecore_imf_context_preedit_changed_event_add ecore_imf_context_commit_event_add ecore_imf_context_delete_surrounding_event_add Signed-off-by: Jihoon Kim <>
2019-05-29ecore-imf/xim: only call ecore_x_shutdown if init was previously calledMike Blumenkrantz
Summary: this isn't a perfect fix, but it's probably the best that can be done given the current ecore-imf module api which calls the exit() module function unconditionally during module cleanup even if the module was never initialized @fix Depends on D9003 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision:
2019-04-23meson: enable strict linkingMarcel Hollerbach
Summary: with this commit you can compile efl with -Wl,-z,defs. Reviewers: zmike Reviewed By: zmike Subscribers: simotek, cedric, #reviewers, #committers Tags: #efl Differential Revision:
2019-04-17build: use only BUILD_ECORE_IMF_XIM as a defineMike Blumenkrantz
Summary: meson and autotools were a bit out of sync with this, resulting in unexpected behavior Reviewers: billiob Reviewed By: billiob Subscribers: billiob, cedric, #reviewers, #committers Tags: #efl Differential Revision:
2019-04-10ecore_imf: do not loop forever on shutdown when there is no more a displayBoris Faure
2019-04-10meson: set ENABLE_XIM if the xim module is compiledBoris Faure
2019-03-03ecore imf - scim module - fix string handling to stop warningsCarsten Haitzler (Rasterman)
so blind use of strncpy was again wrong - it limited to the length of the src not the dest buffer and gcc warnings pointed out this silliness. so instead go back to strcpy with proper length checks before and now it's clear that it's correct and not trying to hide behind strncpy which was wrong.
2018-11-17meson - fix ecore imf scim build to detect scim fully and work againCarsten Haitzler (Rasterman)
2018-11-09ecore imf - xim module - use proper prorotypes and returns for ximCarsten Haitzler (Rasterman)
2018-11-09ecore imf - ibus - fill all struct fieldsCarsten Haitzler (Rasterman)
2018-11-09ecore imf - wl - fill all stgruct fields with something...Carsten Haitzler (Rasterman)
2018-11-09ecore imf modules - check ecore x display state beofre doing x thingsCarsten Haitzler (Rasterman)
using an uninitted x display is not good/useful so ... don't do it. leads to crashes.
2018-10-02here comes mesonMarcel Hollerbach
a new shiny buildtool that currently completes in the total of ~ 4 min.. 1 min. conf time 2:30 min. build time Where autotools takes: 1:50 min. conf time 3:40 min. build time. meson was taken because it went quite good for enlightenment, and is a traction gaining system that is also used by other mayor projects. Additionally, the DSL that is defined my meson makes the configuration of the builds a lot easier to read. Further informations can be gathered from the README.meson Right now, bindings & windows support are missing. It is highly recommented to use meson 0.48 due to optimizations in meson that reduced the time the meson call would need. Co-authored-by: Mike Blumenkrantz <> Differential Revision: Depends on D7011
2018-07-06ecore_wl2: Remove ecore_wl2_display_window_findDerek Foreman
Summary: This is now totally trivial and needs not exist. Depends on D6522 Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #committers, zmike Tags: #efl Differential Revision:
2018-07-06ecore_wl2: Replace window ids with pointersDerek Foreman
Summary: There's no benefit to generating ids instead of just using the Ecore_Wl2_Window pointer in events. This has the added benefit of working around a really nasty hash collision bug when multiple ecore_evas engines are used at once. ref T7053 ref T6222 @beta_break Depends on D6521 Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #committers, zmike Tags: #efl Maniphest Tasks: T7053, T6222 Differential Revision:
2018-02-09wayland_imf: Clear hide timer when deleting contextDerek Foreman
Otherwise the callback can fire after the module is unloaded leading to some very entertaining to debug crashes at shutdown.
2018-02-07ecore-imf: do ecore-x init during ctx creation instead of module initMike Blumenkrantz
this avoids a number of issues with efl under wayland, msot notably the automatic triggering of xwayland during every app startup @fix
2018-02-07disable async mode (use sync mode) for ibus when keymap changesCarsten Haitzler (Rasterman)
so scenario: 1. use ibus 2. have at least english input and japanese input (or korean etc.) 3. have 2 kbd layouts (english and greek). 4. enable "use system keyboard layout" in ibus advanced settings 5. switch to english input mode 6. switch to greek key layout 7. type and get english, not greek input as you should @fix for both terminology and elm/efl entry/ytext input.
2017-12-13efl: drop deprecated Encoding key from desktop filesRoss Vandegrift
Summary: The Encoding key is no longer required, all desktop files are assumed to be UTF-8 encoded. See details at: Fix various typos and misspellings lintian, Debian's package checker, uses strings to check for common typos in compiled binaries. This change fixes the ones it identified in 1.20.6. Reviewers: cedric Reviewed By: cedric Subscribers: cedric, jpeg Differential Revision: Signed-off-by: Cedric BAIL <>
2017-08-12ecore_imf/wayland: Check the return value of memory allocation functionJihoon Kim
2017-06-02ecore-imf-wayland: Check xkb_keysym_to_utf8Bryce Harrington
Summary: Coverity reports an error "Calling "xkb_keysym_to_utf8" without checking return value (as is done elsewhere 4 out of 5 times)." fixes: cid1375673 Reviewers: zmike Subscribers: cedric, jpeg Differential Revision:
2017-05-19wayland: move pointer-related functions to ecore_wl2_input namespaceMike Blumenkrantz
windows do not have pointers or cursors under wayland, seats do. due to lack of multiseat support, most components simply use the "default" seat with these functions, but this should make the corresponding code more easily adaptable
2017-03-03ecore_imf/xim: Fix memory leakJihoon Kim
64 bytes in 1 blocks are definitely lost in loss record 152 of 258 at 0x4C2AB80: malloc (vg_replace_malloc.c:296) by 0xC786A77: ??? (in /usr/lib/x86_64-linux-gnu/ by 0xC78747B: _XimDecodeIMATTRIBUTE (in /usr/lib/x86_64-linux-gnu/ by 0xC77A7EF: ??? (in /usr/lib/x86_64-linux-gnu/ by 0xC767771: XGetIMValues (in /usr/lib/x86_64-linux-gnu/ by 0x113CFE09: ??? by 0x113D08F7: ??? by 0x83DD329: ecore_imf_context_client_window_set (ecore_imf_context.c:240) by 0x530779D: _edje_entry_real_part_init (edje_entry.c:2937) by 0x5311C20: _edje_object_file_set_internal (edje_load.c:1079) by 0x5328665: _edje_object_efl_file_mmap_set (edje_smart.c:438) by 0x775BD3A: efl_file_mmap_set (in /usr/local/lib/
2017-03-02ecore_imf/ibus: Fix memory leak allocated by ibus_bus_newJihoon Kim
2017-02-28ecore-imf-wayland: Reduce calls to set_cursor_rectangleChris Michael
Avoid calls to zwp_text_input_v1_set_cursor_rectangle if we do not need to. Previous code here would always call this function even if the cursor rectangle was in the same position. Now we set a flag on the cursor_location field to let us know that it needs updating. ref T5226 @fix Signed-off-by: Chris Michael <>
2017-02-28ecore-imf-wayland: Remove duplicate header includeChris Michael
wayland_imcontext.h already includes this header, so no need to re-include. Also add missing (void) to function declaration @fix Signed-off-by: Chris Michael <>
2017-02-28ecore-imf-wayland: Formatting fixesChris Michael
NB: No functional changes Signed-off-by: Chris Michael <>
2017-02-28ecore_imf/ibus: fix memory leakJihoon Kim
2017-02-27ecore_imf/ibus: Fix memory leakJihoon Kim
2017-02-27ecore_imf/wayland: Fix memory leak in immoduleJihoon Kim
==1321== 156 bytes in 1 blocks are definitely lost in loss record 7,687 of 9,703 ==1321== at 0x4847E64: calloc (vg_replace_malloc.c:623) ==1321== by 0x92EA7E9: wayland_im_context_new (wayland_imcontext.c:1094) ==1321== by 0x92E66DD: im_module_create (wayland_module.c:132) ==1321== by 0x4D521E7: ecore_imf_module_context_create (ecore_imf_module.c:152) ==1321== by 0x4D51EF7: ecore_imf_context_add (ecore_imf_context.c:141)
2017-01-18ecore_imf/wayland: Auto generate wayland text-input protocolDerek Foreman
Needed to do some fairly invasive changes because naming conventions changed since we checked in the header. Also, since I'm done converting protocol, change the gitignore to use wildcards for wayland protocol. This fixes a long standing bug in text-input binding and restores previous OSK behaviour.
2017-01-09ecore_imf: remove unnecessary exported symbols in immodulesJihoon Kim
Signed-off-by: Jihoon Kim <>
2016-11-17ecore imf - xim module - fix domain check to be be gteq 0Carsten Haitzler (Rasterman)
minor correctness fix.
2016-07-30ecore imf - ibus - fix destroy/disconnect handling that crashesCarsten Haitzler (Rasterman)
restart e or have ibus input get destroyed and come back... the ibus module will do bad things to its pants... because the wrong things were passed to the signal callbacks... this fixers that along with ensuring a freed string ptr is NULL. @fix
2016-07-24ecore-imf - remove usueless checks for context - CID 1351451Carsten Haitzler (Rasterman)
useless checks for ic in code. fix
2016-07-04efl - fix lots of little init/shutdown pairs that are wrongCarsten Haitzler (Rasterman)
i've fixed almost all the eina init/shutdown pairs to do the right thing now... except one (ecore_shutdown) with comment inline where eo_shutdown is not called. if this is called we are in crash land. this needs further inspection.
2016-05-27efl - ecore c+ ecore-imf - fix odd case input when faking a real eventCarsten Haitzler (Rasterman)
so ibus module for ecore-imf likes to send an x event back to ourselves faking a key... this works unless we are looking at modifiers that make make for odd combos with keysyms turned into keycodes. so actualyl use the correct original keycode plus state unless we are having to explicitly send a keysym from ibus core. this fixes T3703 @fix
2016-05-18ecore_imf: Add multiline hint in input hintJihoon Kim
2016-05-17ecore_imf/wayland: Change sequence to call preedit changed and end callbackJihoon Kim
preedit changed and end callback should be called before commit callback
2016-04-18ecore_imf/wayland: Fix bug language changed event is always calledJihoon Kim
Change-Id: I0e1ab14736a3d3849becb7cbeea81fe7b61053b7
2016-03-24ecore_imf/wayland: fix IME flickering issue when input_panel_hide and show ↵Jihoon Kim
is called sequentially Change-Id: Ieafa9cd921cc8d68c64af6b72404ef52e7bbf724
2016-03-21ecore_imf/wayland: use default preedit styleJihoon Kim
Change-Id: Iffb2d450923bbde191c4928253f133b13608a8e8
2016-02-12ecore_imf/wayland: send cursor position before requesting to showJihoon Kim
2016-02-12ecore_imf/wayland: Fix not to show IME in touching entry after hiding IMEJihoon Kim
2016-02-04ecore_imf/wayland: Fix IME hide -> show issue in case of focus-out and then ↵Haifeng Deng
focus-in Change-Id: I1d3d7023dbd10b78f510380ff3c46087228f9180
2016-02-04ecore_imf/wayland: do not check input panel enable in show or hideJihoon Kim
Input panel enable is already being checked in ecore_imf API.